Conversation
| @@ -20,7 +20,8 @@ export const addons = [ | |||
| }, | |||
There was a problem hiding this comment.
Do you have a specific use case or workflow in mind for adding this? It certainly looks cool. But our controls tend to be very static so most of the metrics should look boringly good. What do we hope to get from adding it?
There's not much harm in adding it, though the Storybook deps tend to have vulnerabilities and require manual intervention to update them, so fewer is generally better.
There was a problem hiding this comment.
No specific use case in mind… mostly that it looked cool, and I agree that most of our components are fairly static, but for the ones that aren't, we go pretty hard on performance - this might make it easier to help folks understand what matters (fps, load time, etc.) vs vanity metrics.
It also doesn't appear to be adding many dependencies, so that's definitely dodging a bullet
"peerDependencies": {
"@storybook/icons": "^2.0.0",
"@storybook/react": "^10.0.0",
"react": "^19",
"storybook": "^10"
},
Pull Request
🤨 Rationale
Adds the
@github-ui/storybook-addon-performance-panelto Storybook. This addon provides a real-time "⚡ Performance" panel in Storybook showing frame timing, input responsiveness, layout stability, memory usage, and other browser-level metrics for every story.👩💻 Implementation
@github-ui/storybook-addon-performance-panelas a dev dependency inpackages/storybook/package.json..storybook/main.jsusing the./universalsubpath (appropriate for non-React / HTML/Web Components frameworks). The string is used directly rather than wrapped ingetAbsolutePath(), sincegetAbsolutePathresolves<pkg>/package.jsonand the subpath export does not have a nestedpackage.json.addonPerformancePanel()decorator topreview.jsso it applies to all stories automatically.🧪 Testing
✅ Checklist