commonjs-extension-resolution-loader: add experimental-specifier-resolution tests#11
Merged
GeoffreyBooth merged 5 commits intomainfrom Sep 25, 2022
Merged
Conversation
…follow experimental-specifier-resolution behavior of searching for .mjs extensions in addition to legacy CommonJS ones
JakobJingleheimer
approved these changes
Sep 25, 2022
| export function resolve(specifier, context, defaultResolve) { | ||
| const resolveAsync = promisify(resolveCallback); | ||
|
|
||
| const baseURL = pathToFileURL(cwd() + '/').href; |
Member
There was a problem hiding this comment.
TLDR: you might need to wrap the cwd() in a try/catch.
In internal/process/esm_loader.js, this cwd is wrapped in a try/catch. I don't remember why (I asked and Bradley answered, and I think I forgot document the reason in a comment).
| basedir: dirname(parentPath), | ||
| // For whatever reason, --experimental-specifier-resolution=node doesn't search for .mjs extensions | ||
| // but it does search for index.mjs files within directories | ||
| extensions: ['.js', '.json', '.node', '.mjs'], |
Member
There was a problem hiding this comment.
Nit: no need to re-construct this list every time resolve runs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR follows up #10 with adding the Node codebase’s tests for
--experimental-specifier-resolution=node, modified only to run without the full Node test harness (sopath.joininstead offixtures.path, etc.) and replacing--experimental-specifier-resolution=nodewith--loader=./loader.jsto use the loader in this repo.Adding these tests led to two discoveries which caused minor changes in the loader:
--experimental-specifier-resolution=nodeincludes.mjsas one of the extensions it searches for (who knew!)ERR_MODULE_NOT_FOUNDrather thanMODULE_NOT_FOUND.With those updates, all the
--experimental-specifier-resolution=nodetests pass with thecommonjs-extension-resolution-loaderloader in this repo. I think this means that this loader can be considered a feature-complete replacement for--experimental-specifier-resolution=node.