deps: update V8 to 14.4 #61002
Open
deps: update V8 to 14.4 #61002
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Review requested:
|
nodejs-github-bot
added
build
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
aduh95
added
the
semver-major
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
joyeecheung
added a commit
to joyeecheung/v8
that referenced
this pull request
Dec 15, 2025
Previously TransitionsAccessor::InsertHelper() can grow the transition array without making sure it's sorted after the size crosses kMaxElementsForLinearSearch, leading to search failures or duplicate entries in bigger transition arrays. See nodejs/node#61002 (comment) Change-Id: I3f45816b7d65bbbcfedeb7074d0c6907cbc08edf
hubot
pushed a commit
to v8/v8
that referenced
this pull request
Dec 17, 2025
Previously, after the TransitionArray is rehashed, TransitionsAccessor::InsertHelper() can grow the transition array without making sure it's sorted after the size crosses kMaxElementsForLinearSearch, leading to search failures or duplicate entries in bigger transition arrays. See nodejs/node#61002 (comment) Change-Id: I3f45816b7d65bbbcfedeb7074d0c6907cbc08edf Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7252791 Commit-Queue: Joyee Cheung <[email protected]> Reviewed-by: Igor Sheludko <[email protected]> Cr-Commit-Position: refs/heads/main@{#104384}
targos
pushed a commit
to targos/node
that referenced
this pull request
Dec 18, 2025
Original commit message:
[runtime] sort transition array after it grows beyond linear search size
Previously, after the TransitionArray is rehashed,
TransitionsAccessor::InsertHelper() can grow the transition
array without making sure it's sorted after the size crosses
kMaxElementsForLinearSearch, leading to search failures or
duplicate entries in bigger transition arrays.
See nodejs#61002 (comment)
Change-Id: I3f45816b7d65bbbcfedeb7074d0c6907cbc08edf
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7252791
Commit-Queue: Joyee Cheung <[email protected]>
Reviewed-by: Igor Sheludko <[email protected]>
Cr-Commit-Position: refs/heads/main@{#104384}
Refs: v8/v8@0ce9f16
targos
pushed a commit
to targos/node
that referenced
this pull request
Dec 22, 2025
Original commit message:
[runtime] sort transition array after it grows beyond linear search size
Previously, after the TransitionArray is rehashed,
TransitionsAccessor::InsertHelper() can grow the transition
array without making sure it's sorted after the size crosses
kMaxElementsForLinearSearch, leading to search failures or
duplicate entries in bigger transition arrays.
See nodejs#61002 (comment)
Change-Id: I3f45816b7d65bbbcfedeb7074d0c6907cbc08edf
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7252791
Commit-Queue: Joyee Cheung <[email protected]>
Reviewed-by: Igor Sheludko <[email protected]>
Cr-Commit-Position: refs/heads/main@{#104384}
Refs: v8/v8@0ce9f16
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
PR-URL: nodejs#54077 Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Paolo Insogna <[email protected]> Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]>
It's causing linker errors with node.lib in node-gyp and potentially breaks other 3rd party tools PR-URL: nodejs#56238 Refs: nodejs#55784 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Paolo Insogna <[email protected]> Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]>
GCC emits warnings because of the trailing backslashes. PR-URL: nodejs#58070 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Paolo Insogna <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]>
PR-URL: nodejs#58070 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Paolo Insogna <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]>
illumos pointers are VA48, can allocate from the top of the 64-bit range as well. PR-URL: nodejs#59805 Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
In illumos, madvise(3C) now takes `void *` for its first argument post-illumos#14418, but uses `caddr_t` pre-illumos#14418. This fix will detect if the illumos mman.h file in use is pre-or-post-illumos#14418 so builds can work either way. PR-URL: nodejs#58237 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
Original commit message:
GCC 15 removed avx10.2-512 target
PiperOrigin-RevId: 823560321
Refs: google/highway@989a498
PR-URL: nodejs#60682
Fixes: nodejs#60566
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Xuguang Mei <[email protected]>
Original commit message:
Fix GCC Build
Move explicit specializations of Utf8::IsAsciiOneByteString to namespace scope
C++ forbids explicit template specializations inside class scope.
The specializations for IsAsciiOneByteString<uint8_t> and
IsAsciiOneByteString<uint16_t> were defined inside class unibrow::Utf8,
riggering "explicit specialization in non-namespace scope"
compile errors.
Fix type mismatch in EXPECT_EQ comparisons for std::pair values
The tests failed because EXPECT_EQ was comparing pairs with mismatched
template parameters — std::pair<int, unsigned int> vs.
std::pair<unsigned int, unsigned char> — which have no valid operator==.
I corrected the expected values to use the same unsigned types as the
actual data, ensuring the pair comparison compiles cleanly.
Fix build failure on GCC 12 by replacing std::format with ostringstream
GCC 12's libstdc++ does not implement <format>, causing compile errors when
using std::format. Replaced all std::format calls with equivalent
Change-Id: I5c31f91065eccf6f4c14172902ffcd99863ebbb9
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7138905
Commit-Queue: Clemens Backes <[email protected]>
Reviewed-by: Jakob Kummerow <[email protected]>
Reviewed-by: Clemens Backes <[email protected]>
Commit-Queue: Jakob Kummerow <[email protected]>
Cr-Commit-Position: refs/heads/main@{#104280}
Refs: v8/v8@ee2873a
Original commit message:
[runtime] sort transition array after it grows beyond linear search size
Previously, after the TransitionArray is rehashed,
TransitionsAccessor::InsertHelper() can grow the transition
array without making sure it's sorted after the size crosses
kMaxElementsForLinearSearch, leading to search failures or
duplicate entries in bigger transition arrays.
See nodejs#61002 (comment)
Change-Id: I3f45816b7d65bbbcfedeb7074d0c6907cbc08edf
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7252791
Commit-Queue: Joyee Cheung <[email protected]>
Reviewed-by: Igor Sheludko <[email protected]>
Cr-Commit-Position: refs/heads/main@{#104384}
Refs: v8/v8@0ce9f16
Original commit message:
[runtime] zero-initialize descriptor array padding
So that snapshot and code cache stay reproducible.
See nodejs/node-v8#304
Change-Id: Ic30970097ab46a26fa5bcf0f73e0fe62089890cc
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7271645
Reviewed-by: Patrick Thier <[email protected]>
Commit-Queue: Joyee Cheung <[email protected]>
Cr-Commit-Position: refs/heads/main@{#104436}
Refs: v8/v8@6eff00a
Original commit message:
Move ByteReverse helpers under src/base
This patch is needed to fix compilation errors on BE platforms after
this change: http://crrev.com/c/7203818
Bug: 448409803
Change-Id: Ife2e582f641c465c070ab397ca3c64f619715976
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7209841
Reviewed-by: Michael Lippautz <[email protected]>
Commit-Queue: Milad Farazmand <[email protected]>
Cr-Commit-Position: refs/heads/main@{#104029}
Refs: v8/v8@8ca4ae9
Original commit message:
Fix arg_buffer under Generate_WasmFXSuspend
Also change the tmp register passed to LoadJumpBuffer to avoid
overwriting arg_buffer.
Change-Id: I72b83edf722481ca7018731d36e1939620612e97
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7212934
Reviewed-by: John <[email protected]>
Commit-Queue: Milad Farazmand <[email protected]>
Cr-Commit-Position: refs/heads/main@{#104032}
Refs: v8/v8@6c3fce9
Original commit message:
[temporal] enable v8_enable_temporal_support on ppc64 and s390x
Change-Id: Iaa5f46913b6aabf00b0440dba3d524427667b06e
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7216074
Reviewed-by: Manish Goregaokar <[email protected]>
Reviewed-by: Michael Achenbach <[email protected]>
Commit-Queue: Manish Goregaokar <[email protected]>
Cr-Commit-Position: refs/heads/main@{#104066}
Refs: v8/v8@fab6b87
Original commit message:
Fix builds with no `__builtin_bswap64` support
Currently getting `'kBitsPerByte' was not declared in this scope`.
Change-Id: Ied391ac9e859f0f3548d88fd1cc57f490d99e39a
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7310534
Reviewed-by: Clemens Backes <[email protected]>
Commit-Queue: Milad Farazmand <[email protected]>
Cr-Commit-Position: refs/heads/main@{#104481}
Refs: v8/v8@d58ce5a
Original commit message:
[builtins] disallow ArrayBuffer transfer with a detach key
This allows embedder to disallow `ArrayBuffer.prototype.transfer()` on
an arraybuffer that is not detachable. This also fix the check on
`ArrayBufferCopyAndDetach` step 8 of `ArrayBuffer.prototype.transfer`.
Refs: nodejs#61362
Refs: https://tc39.es/ecma262/#sec-arraybuffercopyanddetach
Change-Id: I3c6e156a8fad007fd100218d8b16aed5c4e1db68
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7454288
Commit-Queue: Chengzhong Wu <[email protected]>
Reviewed-by: Olivier Flückiger <[email protected]>
Cr-Commit-Position: refs/heads/main@{#104697}
Refs: v8/v8@c5ff7c4
PR-URL: nodejs#61372
Fixes: nodejs#61362
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: René <[email protected]>
This comment was marked as outdated.
This comment was marked as outdated.
Member
Author
|
Ping @nodejs/platform-windows and
Edit: I think I found the solution for smartos/shared libs build |
Add args to `tools/make-v8.sh` for compiling Rust-based components, such as Temporal, for the Linux on ppc64le and s390x V8 CI builds.
Collaborator
Collaborator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.