-
-
Notifications
You must be signed in to change notification settings - Fork 34.5k
lib: use bracket notation instead of String.prototype.startWith for locks
#61492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kimtaejin3
wants to merge
2
commits into
nodejs:main
Choose a base branch
from
kimtaejin3:lib/prefer-primordials-in-locks
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
lib: use bracket notation instead of String.prototype.startWith for locks
#61492
kimtaejin3
wants to merge
2
commits into
nodejs:main
from
kimtaejin3:lib/prefer-primordials-in-locks
+2
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use StringPrototypeStartsWith from primordials instead of String.prototype.startsWith to prevent prototype pollution. Refs: nodejs#59699
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #61492 +/- ##
==========================================
- Coverage 89.82% 89.78% -0.04%
==========================================
Files 667 672 +5
Lines 203693 203908 +215
Branches 39163 39194 +31
==========================================
+ Hits 182963 183076 +113
- Misses 13061 13161 +100
- Partials 7669 7671 +2
🚀 New features to boost your workflow:
|
aduh95
approved these changes
Jan 23, 2026
Collaborator
ljharb
reviewed
Jan 23, 2026
cjihrig
approved these changes
Jan 24, 2026
Collaborator
Co-authored-by: Jordan Harband <ljharb@gmail.com>
String.prototype.startWith for locks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
needs-ci
PRs that need a full CI run.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use StringPrototypeStartsWith from primordials instead of String.prototype.startsWith to prevent prototype pollution.