Skip to content

typings: add signal_wrap internal binding types #65229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
leah-1ee wants to merge 1 commit into
base: main
Choose a base branch
from
+18 −0
Open

typings: add signal_wrap internal binding types #65229

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions typings/globals.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ import { ProcessBinding } from './internalBinding/process';
import { ProcessWrapBinding } from './internalBinding/process_wrap';
import { SeaBinding } from './internalBinding/sea';
import { SerdesBinding } from './internalBinding/serdes';
import { SignalWrapBinding } from './internalBinding/signal_wrap';
import { StringDecoderBinding } from './internalBinding/string_decoder';
import { SymbolsBinding } from './internalBinding/symbols';
import { TimersBinding } from './internalBinding/timers';
Expand Down Expand Up @@ -63,6 +64,7 @@ interface InternalBindingMap {
process_wrap: ProcessWrapBinding;
sea: SeaBinding;
serdes: SerdesBinding;
signal_wrap: SignalWrapBinding;
string_decoder: StringDecoderBinding;
symbols: SymbolsBinding;
timers: TimersBinding;
Expand Down
16 changes: 16 additions & 0 deletions typings/internalBinding/signal_wrap.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
declare namespace InternalSignalWrapBinding {
class Signal {
constructor();
onsignal?: (signum: number) => void;
start(signum: number): number;

@daeyeon daeyeon Aug 15, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
start(signum: number): number;
start(signum: number): number | undefined;

This may be more accurate, though it only applies to a special case:

node/src/signal_wrap.cc

Lines 111 to 120 in 2929417

#if defined(__POSIX__) && HAVE_INSPECTOR
if (signum == SIGPROF) {
Environment* env = Environment::GetCurrent(args);
if (env->inspector_agent()->IsListening()) {
ProcessEmitWarning(env,
"process.on(SIGPROF) is reserved while debugging");
return;
}
}
#endif

stop(): number;
close(callback?: () => void): void;
hasRef(): boolean;
ref(): void;
unref(): void;
}
}

export interface SignalWrapBinding {
Signal: typeof InternalSignalWrapBinding.Signal;
}
Loading