Skip to content

fix: the fetch function uses hyperquest in dist-indexer.js #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
anupamme wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: the fetch function uses hyperquest in dist-indexer.js #96

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 14 additions & 5 deletions src/dist-indexer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,15 @@ const modVersionUrl = [
]
const ltsVersionUrl = `${githubContentUrl}/src/node_version.h`
const isSecurityUrl = 'https://github.com/nodejs/{repo}/commits/{gitref}.atom'
const MAX_RESPONSE_SIZE = 1 * 1024 * 1024 // 1MB limit

function sanitizePart (part) {
if (typeof part === 'string' && (part.includes('..') || part.startsWith('/'))) {
throw new Error('Path traversal attempt detected')
}
return part
}

const githubOptions = {
headers: {
accept: 'text/plain,application/vnd.github.v3.raw'
Expand Down Expand Up @@ -93,7 +102,7 @@ function fetch (url, gitref, callback) {
url = url.replace('{gitref}', refparts[1])
.replace('{repo}', repo) +
`?rev=${refparts[1]}`
hyperquest.get(url, githubOptions).pipe(bl((err, data) => {
hyperquest.get(url, githubOptions).pipe(bl({ limit: MAX_RESPONSE_SIZE }, (err, data) => {
if (err) {
return callback(err)
}
Expand Down Expand Up @@ -390,14 +399,14 @@ function fetchSecurity (gitref, callback) {
}

function dirDate (dir, callback) {
fs.readdir(path.join(argv.dist, dir), (err, files) => {
fs.readdir(path.join(argv.dist, sanitizePart(dir)), (err, files) => {
if (err) {
return callback(err)
}

const mtime = (file, callback) => {
const ignoreDirectoryDate = new Date('2019-10-01')
fs.stat(path.join(argv.dist, dir, file), (err, stat) => {
fs.stat(path.join(argv.dist, sanitizePart(dir), sanitizePart(file)), (err, stat) => {
if (err || !stat) {
return callback(err)
}
Expand Down Expand Up @@ -425,7 +434,7 @@ function dirDate (dir, callback) {

function dirFiles (dir, callback) {
// TODO: look in SHASUMS.txt as well for older versions
fs.readFile(path.join(argv.dist, dir, 'SHASUMS256.txt'), 'utf8', (err, contents) => {
fs.readFile(path.join(argv.dist, sanitizePart(dir), 'SHASUMS256.txt'), 'utf8', (err, contents) => {
if (err) {
return callback(err)
}
Expand Down Expand Up @@ -456,7 +465,7 @@ function inspectDir (dir, callback) {
let date

if (!gitref) {
return fs.stat(path.join(argv.dist, dir), (err, stat) => {
return fs.stat(path.join(argv.dist, sanitizePart(dir)), (err, stat) => {
if (err) {
return callback(err)
}
Expand Down