Skip to content

Add subdomain for staging - #989

Merged
avivkeller merged 2 commits into
mainfrom
flakey5/20260801/staging
Aug 3, 2026
Merged

Add subdomain for staging#989
avivkeller merged 2 commits into
mainfrom
flakey5/20260801/staging

Conversation

@flakey5

@flakey5 flakey5 commented Aug 1, 2026

Copy link
Copy Markdown
Member

No description provided.

Signed-off-by: flakey5 <73616808+flakey5@users.noreply.github.com>
@flakey5
flakey5 requested a review from a team as a code owner August 1, 2026 18:15
@cursor

cursor Bot commented Aug 1, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
Deploy/routing-only Wrangler changes for staging; no application logic or prod route changes.

Overview
Staging now gets a dedicated Cloudflare route so the dist worker is served at r2.staging.nodejs.org/* on the nodejs.org zone, mirroring prod’s r2.nodejs.org pattern for isolated staging traffic.

workers_dev is no longer set inside vars (where it didn’t belong); it’s defined at the staging env level alongside routes and bindings, keeping Wrangler config aligned with how prod handles workers_dev.

Reviewed by Cursor Bugbot for commit 93b4c0b. Bugbot is set up for automated code reviews on this repo. Configure here.

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Want fixes drafted automatically? Bugbot Autofix can create code changes for findings. A team admin can enable Autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit b4f4817. Configure here.

Comment thread wrangler.jsonc
Signed-off-by: flakey5 <73616808+flakey5@users.noreply.github.com>
@avivkeller
avivkeller merged commit fd85777 into main Aug 3, 2026
7 checks passed
@avivkeller
avivkeller deleted the flakey5/20260801/staging branch August 3, 2026 15:21
@MattIPv4

MattIPv4 commented Aug 3, 2026

Copy link
Copy Markdown
Member

👀 @flakey5 was this ready to merge? Not sure the conversation in Slack concluded on this?

avivkeller added a commit that referenced this pull request Aug 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants