feat: add node 26 support and bump current#1938
Conversation
WalkthroughNode.js major version 26 is added to the distributions repository's setup and testing infrastructure. The CI workflow matrices are expanded to include version 26 across three job types, new setup scripts for Debian and RPM systems are created, script generators are updated to target version 26 as current, and NSolid installation checks are skipped for both versions 25 and 26. ChangesNode.js 26 Support
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@scripts/deb/setup_26.x`:
- Around line 92-110: The deb configure_repo should only add N|Solid APT pinning
and print the "To install N|solid" success/info messages when the current Node
major version is in the LTS set; update the configure_repo logic to check the
Node version (e.g., via the existing NODE_MAJOR or NODE_VERSION variable or an
is_lts_version helper) and wrap the blocks that write
/etc/apt/preferences.d/nsolid and the log calls that reference N|solid (the echo
lines creating nsolid pin files and the log "To install N|solid Runtime..." /
"You can use N|solid Runtime..." messages) so they run only when the version is
LTS, matching the RPM script behavior.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 81d95fda-d774-49e8-9604-fc10e852371d
📒 Files selected for processing (7)
.github/workflows/ci.yamlscripts/deb/script_generator/generator.shscripts/deb/setup_26.xscripts/deb/setup_current.xscripts/rpm/script_generator/generator.shscripts/rpm/setup_26.xscripts/rpm/setup_current.x
Summary by CodeRabbit
New Features
Chores