Skip to content

fix for sf7#457

Merged
norberttech merged 1 commit into
norberttech:1.xfrom
metabolism:1.x
Sep 12, 2025
Merged

fix for sf7#457
norberttech merged 1 commit into
norberttech:1.xfrom
metabolism:1.x

Conversation

@jerome-barbato
Copy link
Copy Markdown
Contributor

Change Log

Fixed

  • Changed declaration of NorbertTech\StaticContentGeneratorBundle\DependencyInjection\Configuration::getConfigTreeBuilder() to be compatible with Symfony\Component\Config\Definition\ConfigurationInterface::getConfigTreeBuilder()
  • Changed method signature from `callable $callback = null` to `?callable $callback = null` to explicitly accept null and avoid type errors. Supported since PHP 7.1.

@norberttech norberttech merged commit 2d805ab into norberttech:1.x Sep 12, 2025
11 of 14 checks passed
@norberttech
Copy link
Copy Markdown
Owner

Thank @jerome-barbato for pointing this out! I took a liberty to also bump minimum required php version to 8.2 will tag new version soon

@jerome-barbato
Copy link
Copy Markdown
Contributor Author

My pleasure ! Your plugin helped me a lot ! Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants