Skip to content

added proper typing for icon class names#1538

Open
Yusra89hash wants to merge 1 commit intonpmx-dev:mainfrom
Yusra89hash:main
Open

added proper typing for icon class names#1538
Yusra89hash wants to merge 1 commit intonpmx-dev:mainfrom
Yusra89hash:main

Conversation

@Yusra89hash
Copy link

@Yusra89hash Yusra89hash commented Feb 18, 2026

No description provided.

@vercel
Copy link

vercel bot commented Feb 18, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Ready Preview, Comment Feb 18, 2026 3:53am
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Preview Feb 18, 2026 3:53am
npmx-lunaria Ignored Ignored Feb 18, 2026 3:53am

Request Review

@codecov
Copy link

codecov bot commented Feb 18, 2026

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
app/pages/package/[[org]]/[name].vue 0.00% 0 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 18, 2026

📝 Walkthrough

Walkthrough

This pull request comprises two distinct type and reactivity improvements. The first change introduces a new StartIcon type alias in the Button Base component, narrowing the classicon prop's type from a generic string to specific icon namespace literals, enhancing type safety. The second change modifies the clipboard handling in the package page, converting the copyVersion source from a static value to a reactive function, ensuring the clipboard consistently retrieves the current resolved version each time the copy action is triggered.

Possibly related PRs

  • feat: add copy button for package versions #1447: Directly related through clipboard handling modifications—this PR makes the copyVersion source reactive whilst the related PR initially introduced the copyVersion clipboard feature with a non-reactive implementation.

Suggested reviewers

  • nicolo-ribaudo
  • ghostdevv
🚥 Pre-merge checks | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive The pull request has no description provided by the author, but the PR objectives clarify the intent to add proper typing for icon class names. The author should add a description to the pull request explaining the changes made, such as the type alias introduction and prop type updates for stricter icon validation.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Tip

Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

})

//copy version name
//orginally only copied name and not version number
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Typo and stale comment should be removed.

"orginally" is a misspelling of "originally". More broadly, the comment describes the old (broken) behaviour rather than the current intent — it reads as a leftover PR note and adds noise as permanent inline documentation.

🔧 Proposed fix
-//orginally only copied name and not version number
 const { copied: copiedVersion, copy: copyVersion } = useClipboard({
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
//orginally only copied name and not version number
const { copied: copiedVersion, copy: copyVersion } = useClipboard({

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments