fix typo in _legend.py : obj.ncol should be obj.ncols#579
Open
elicox0 wants to merge 1 commit intonschloe:mainfrom
Open
fix typo in _legend.py : obj.ncol should be obj.ncols#579elicox0 wants to merge 1 commit intonschloe:mainfrom
elicox0 wants to merge 1 commit intonschloe:mainfrom
Conversation
|
This duplicates (at least) #574, #565 and #558 and just has not been merged yet, see #574 (comment) as well. This is no typo, but a change from |
This was referenced Apr 18, 2023
|
Why is this not merged? |
|
Because maintenance is more or less stalled at the moment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes an AttributeError when a user calls
plt.legend()and then saves a figure withtikzplotlib.save. Sinceobjin the relevant line is of typematplotlib.legend.Legend(), the attribute isncolsand notncol(see https://matplotlib.org/stable/api/legend_api.html#matplotlib.legend.Legend).