Conversation
7c64cd4 to
754e13a
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #3934 +/- ##
==========================================
- Coverage 26.82% 26.81% -0.01%
==========================================
Files 670 670
Lines 44294 44296 +2
==========================================
- Hits 11881 11880 -1
- Misses 31309 31311 +2
- Partials 1104 1105 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
pkg/services/object/server.go
Outdated
| } | ||
| } | ||
| //nolint:exhaustive | ||
| switch f.MatchType { |
There was a problem hiding this comment.
this is correct and match previous behavior. But i also see that we do this in
neofs-node/pkg/core/object/metadata.go
Lines 712 to 715 in 943599a
i'd either apply proposed change there or deduplicate these checks in the future (not a critical point, but still)
There was a problem hiding this comment.
Well, the reality is that we don't get any error in https://rest.fs.neo.org/Aku38wpn2xEqfEPxmwyAa7N3VnAkMV8PEVkpLqwKM1z3/5141-1775829634/index.html#suites/87d8da5f92824d091055170c29079bc0/5e5dbbff96715ad4/ after search became and alias to searchv2.
There was a problem hiding this comment.
Huh
neofs-node/pkg/services/object/server.go
Lines 2047 to 2053 in 943599a
There was a problem hiding this comment.
don't we test the same for searchv2?
There was a problem hiding this comment.
Reworked a bit, should be better now.
Turns out, V1 search (deleted in e4a034c) had this check and we have some tests for it. V2 also has some of it internally, but this was hidden by unreachable query error (returning nothing instead of an error). Signed-off-by: Roman Khimov <roman@nspcc.ru>
Unused since e4a034c. Signed-off-by: Roman Khimov <roman@nspcc.ru>
754e13a to
d242cab
Compare
Follow-up to #3931.