feat(vi): support deleting chars backward with X#1067
Open
sim590 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add support for the
Xcommand in vi normal mode, which deletes the character before the cursor and places it in the cut buffer, mirroring the behavior ofXin vim.This partially addresses #621.
Changes
XasCommand::DeleteCharBackwardin the vi command parserMoveLeft+CutCharto delete the character before the cursor and place it in the cut bufferCutSelection(consistent withxbehavior)Xand2XKnown limitation
When used with a multiplier (e.g.
3X), each character is cut individually, so only the last deleted character remains in the cut buffer. This is a pre-existing limitation shared withxand will be addressed in a follow-up PR.