Nh replace with alphabet position #52
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
W-Ely
reviewed
Apr 12, 2024
Comment on lines
+5
to
+10
| position_index = ["a","b","c","d","e","f","g","h","i","j","k","l","m","n","o","p","q","r","s","t","u","v","w","x","y","z"] | ||
| positions = "" | ||
| for character in characters: | ||
| if character.isalpha(): | ||
| positions += f"{position_index.index(character) + 1} " | ||
| return positions.rstrip() |
Collaborator
There was a problem hiding this comment.
I don't readily see how the spaces are being added to positions?
The .index(character) method isn't very efficient, it has to look through the whole list to find the index. Since it has to be written out anyway, you might use a dict like {"a": 1, "b": 2...}. The lookup would then be o(1) instead of needing to search the whole alphabet each time.
There is probably also a way to use the built in ord method on the lower letter and some math to get the number.
Collaborator
There was a problem hiding this comment.
Oh I see f"{position_index.index(character) + 1} " has a space at the end that is then trimmed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.