PIV unlock should fetch management key alg instead of using firmware default - #36
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates YubiKey PIV unlocking to authenticate using the management key algorithm actually configured on the device (via PIV metadata), rather than always assuming the firmware default. This improves compatibility with devices configured with non-default management key algorithms (e.g., AES).
Changes:
- Read the management key algorithm from the PIV management slot metadata when available, falling back to the device firmware default when not supported.
- Refactor management-key construction to use the discovered algorithm during
unlock(). - Extend
yubikey::pivimports to include management-slot/metadata algorithm types needed for the lookup.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
obelisk
approved these changes
Jul 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, PIV assumes the management key algorithm is the default based on the firmware version. This PR dynamically fetches the algorithm from the Yubikey.
Tested with:
Reviewed by Opus 5 and Copilot.