Add logging level configuration - #784
Open
afausti wants to merge 2 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds documented and Helm-configurable control of Kafdrop’s Spring Boot logging levels via environment variables, addressing requests to reduce log noise (issues #422 and #644).
Changes:
- Documented
LOGGING_LEVEL_*environment variables and/actuator/loggersendpoint usage in the README. - Added logging level defaults to Helm
values.yaml. - Injected
LOGGING_LEVEL_*env vars into the Helm Deployment template.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| README.md | Documents environment-variable-based logging level configuration and references the actuator loggers endpoint. |
| chart/values.yaml | Introduces Helm values for root and Kafdrop package-specific logging levels. |
| chart/templates/deployment.yaml | Wires Helm logging values into container LOGGING_LEVEL_* environment variables. |
Suppressed comments (1)
chart/templates/deployment.yaml:77
- Same upgrade/backward-compat concern as above: accessing
.Values.logging.kafdrop.service/controllerwill break when upgrading with--reuse-values(nologgingkey). Use safe lookups with defaults.
- name: LOGGING_LEVEL_KAFDROP_SERVICE
value: {{ .Values.logging.kafdrop.service.level | upper | quote }}
- name: LOGGING_LEVEL_KAFDROP_CONTROLLER
value: {{ .Values.logging.kafdrop.controller.level | upper | quote }}
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+69
to
+73
| value: {{ .Values.logging.root.level | upper | quote }} | ||
| - name: LOGGING_LEVEL_KAFDROP | ||
| value: {{ .Values.logging.kafdrop.level | upper | quote }} | ||
| - name: LOGGING_LEVEL_KAFDROP_CONFIG | ||
| value: {{ .Values.logging.kafdrop.config.level | upper | quote }} |
Collaborator
|
@afausti Thanks for your contribution! Copilot made a comment that sounds logical to me. Can you follow-up? After that, the PR can be merged and join the upcoming release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Address issues #422 and #644.
Add section in the README on how to configure Kafdrop logging level using environment variables.
Add logging level configuration to the Helm chart.