Skip to content

Add logging level configuration - #784

Open
afausti wants to merge 2 commits into
obsidiandynamics:masterfrom
afausti:logging
Open

Add logging level configuration#784
afausti wants to merge 2 commits into
obsidiandynamics:masterfrom
afausti:logging

Conversation

@afausti

@afausti afausti commented Oct 7, 2025

Copy link
Copy Markdown

Address issues #422 and #644.
Add section in the README on how to configure Kafdrop logging level using environment variables.
Add logging level configuration to the Helm chart.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds documented and Helm-configurable control of Kafdrop’s Spring Boot logging levels via environment variables, addressing requests to reduce log noise (issues #422 and #644).

Changes:

  • Documented LOGGING_LEVEL_* environment variables and /actuator/loggers endpoint usage in the README.
  • Added logging level defaults to Helm values.yaml.
  • Injected LOGGING_LEVEL_* env vars into the Helm Deployment template.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
README.md Documents environment-variable-based logging level configuration and references the actuator loggers endpoint.
chart/values.yaml Introduces Helm values for root and Kafdrop package-specific logging levels.
chart/templates/deployment.yaml Wires Helm logging values into container LOGGING_LEVEL_* environment variables.
Suppressed comments (1)

chart/templates/deployment.yaml:77

  • Same upgrade/backward-compat concern as above: accessing .Values.logging.kafdrop.service/controller will break when upgrading with --reuse-values (no logging key). Use safe lookups with defaults.
          - name: LOGGING_LEVEL_KAFDROP_SERVICE
            value: {{ .Values.logging.kafdrop.service.level | upper | quote }}
          - name: LOGGING_LEVEL_KAFDROP_CONTROLLER
            value: {{ .Values.logging.kafdrop.controller.level | upper | quote }}

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment on lines +69 to +73
value: {{ .Values.logging.root.level | upper | quote }}
- name: LOGGING_LEVEL_KAFDROP
value: {{ .Values.logging.kafdrop.level | upper | quote }}
- name: LOGGING_LEVEL_KAFDROP_CONFIG
value: {{ .Values.logging.kafdrop.config.level | upper | quote }}
@Bert-R

Bert-R commented Aug 8, 2026

Copy link
Copy Markdown
Collaborator

@afausti Thanks for your contribution! Copilot made a comment that sounds logical to me. Can you follow-up? After that, the PR can be merged and join the upcoming release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants