Requests: Give correct MIME in GetSourceScreenshot#1337
Open
andrewsoncha wants to merge 1 commit intoobsproject:masterfrom
Open
Requests: Give correct MIME in GetSourceScreenshot#1337andrewsoncha wants to merge 1 commit intoobsproject:masterfrom
GetSourceScreenshot#1337andrewsoncha wants to merge 1 commit intoobsproject:masterfrom
Conversation
Added code to look up the correct MIME type for the requested image format and return the base64 with the correct MIME format in GetSourceScreenshot
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds to
GetSourceScreenshotthe code to look up the correct MIME type for the requested image format and returns the base64 string with the correct MIME type. The lookup of the correct MIME types for each file formats is done using Qt library's QMimeDatabase Object.Motivation and Context
This PR solves this issue.
The original code for
GetSourceScreenshotgot the MIME type by simply appending the requested image format toimage/.In some cases, this causes the response MIME type to be an invalid MIME type.
For Example, when making a
GetSourceScreenshotrequest with the image format parameter of{'imageFormat': 'jpg'}, the original code returns a base64 string with the MIME typeimage/jpg, which is not an official valid MIME type.This causes issues in rendering with certain browsers or software.
How Has This Been Tested?
Tested OS(s): macOS 26.02, Windows 11
Made
GetSourceScreenshotrequests with each supported image format and confirmed that the response is a base64 string starting with the official MIME typesFor Example, both requests made with
{'imageFormat': 'jpg'}and{'imageFormat': 'jpeg'}respond with the valid MIME typeimage/jpegTypes of changes
Bug fix (non-breaking change which fixes an issue)
Checklist:
masteror arelease/*branch.