Skip to content

rename DEFAULT_PAGE_SIZE to PAGE_SIZE#6471

Open
Carlyle-Foster wants to merge 3 commits into
odin-lang:masterfrom
Carlyle-Foster:master
Open

rename DEFAULT_PAGE_SIZE to PAGE_SIZE#6471
Carlyle-Foster wants to merge 3 commits into
odin-lang:masterfrom
Carlyle-Foster:master

Conversation

@Carlyle-Foster
Copy link
Copy Markdown
Contributor

to reflect that it's often not just a default

@Kelimion Kelimion requested a review from gingerBill March 24, 2026 23:43
@Kelimion
Copy link
Copy Markdown
Member

And we have another hardcoded one in core:mem/alloc.odin.

DEFAULT_PAGE_SIZE ::
	64 * 1024 when ODIN_ARCH == .wasm32 || ODIN_ARCH == .wasm64p32 else
	16 * 1024 when ODIN_OS == .Darwin && ODIN_ARCH == .arm64 else
	4 * 1024

@gingerBill may want to consider whether and how to consolidate these.

@Carlyle-Foster
Copy link
Copy Markdown
Contributor Author

And we have another hardcoded one in core:mem/alloc.odin.

DEFAULT_PAGE_SIZE ::
	64 * 1024 when ODIN_ARCH == .wasm32 || ODIN_ARCH == .wasm64p32 else
	16 * 1024 when ODIN_OS == .Darwin && ODIN_ARCH == .arm64 else
	4 * 1024

@gingerBill may want to consider whether and how to consolidate these.

my latest commits are a draft of consolidation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants