[IMP] Time Off: Allocations#18598
Closed
larm-odoo wants to merge 1 commit into
Closed
Conversation
Collaborator
|
|
Contributor
Author
|
Hi @stepperpig - this is ready for a review. Thanks! |
stepperpig
approved these changes
Jun 25, 2026
stepperpig
left a comment
stepperpig
left a comment
Contributor
There was a problem hiding this comment.
Hi @larm-odoo, looks mostly good to me! There's a few places where I wasn't clear about the UI so I'd suggest taking a look at those comments. Otherwise, mostly minor suggestions. Feel free to move this to final review when done!
larm-odoo
added
canceled
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updating images, new workflow/button for group allocations, and dividing the 2 request methods into their own sections.
Original task card for this PR.