[IMP] Time Off: My time#18604
Open
larm-odoo wants to merge 1 commit into
Open
Conversation
Collaborator
|
|
Contributor
Author
|
Hi @theRealThagomizer - this is ready for a review. Thanks! |
theRealThagomizer
approved these changes
Jun 26, 2026
theRealThagomizer
left a comment
theRealThagomizer
left a comment
Contributor
There was a problem hiding this comment.
Hiya, @larm-odoo! Changes look good overall! I had a few suggestions and caught a few typos, but I think this is ready to move on otherwise.
Comment on lines
+22
to
+23
| current day highlighted in a red circle. The weeks are notated in light grey, in the far left column | ||
| of each month. |
Contributor
There was a problem hiding this comment.
Might be worth adding a picture for this, just because it might take folks a moment for it to click that the grey NUMBER is the week. I thought this meant the grey columns denoting Saturday and Sunday, for instance.
Comment on lines
+30
to
+33
| The calendar displays weekends by default. For companies that only operate from Monday through | ||
| Friday, it may be desired to hide weekends since they are non-working days. To hide the weekends, | ||
| click the :guilabel:`Year` :icon:`fa-caret-down` button, and click :icon:`fa-check` | ||
| :guilabel:`Show Weekends`. The dashboard reloads, and the weekends are hidden from view. |
Contributor
There was a problem hiding this comment.
Suggested change
| The calendar displays weekends by default. For companies that only operate from Monday through | |
| Friday, it may be desired to hide weekends since they are non-working days. To hide the weekends, | |
| click the :guilabel:`Year` :icon:`fa-caret-down` button, and click :icon:`fa-check` | |
| :guilabel:`Show Weekends`. The dashboard reloads, and the weekends are hidden from view. | |
| The calendar displays weekends by default. To hide the weekends, click | |
| the :guilabel:`Year` :icon:`fa-caret-down` button, and click :icon:`fa-check` | |
| :guilabel:`Show Weekends`. The dashboard automatically reloads, and | |
| the weekends are hidden from view. |
Lil' tighter.
| :guilabel:`Allocated` to view a list of allocations granted. To request more time, click | ||
| :guilabel:`new request` and a :ref:`New Allocation pop-up window loads | ||
| <time_off/request-allocation>`. | ||
| - :guilabel:`Approved`: The total amount of time off that has been approved |
Contributor
There was a problem hiding this comment.
Suggested change
| - :guilabel:`Approved`: The total amount of time off that has been approved | |
| - :guilabel:`Approved`: The total amount of time off that has been approved. |
| - :guilabel:`Approved`: The total amount of time off that has been approved | ||
| - :guilabel:`Planned`: The total amount of time off that has been scheduled for the future. | ||
| - :guilabel:`Available`: The total amount of time off available to the employee after the approved | ||
| and planned tie off are factored in. |
Contributor
There was a problem hiding this comment.
Suggested change
| and planned tie off are factored in. | |
| and planned time off are factored in. |
| New allocation requests can also be made from the :guilabel:`Dashboard`. Click the :guilabel:`New | ||
| Allocation Request` button to request more time off, and a :ref:`New Allocation | ||
| New allocation requests can also be made from the :guilabel:`Dashboard`. Click the :guilabel:`NEW | ||
| ALLOCATION REQUEST` button to request more time off, and a :ref:`New Allocation |
Contributor
There was a problem hiding this comment.
Suggested change
| ALLOCATION REQUEST` button to request more time off, and a :ref:`New Allocation | |
| ALLOCATION REQUEST` link to request more time off, and a :ref:`New Allocation |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updating new pop-ups, including the warning, and new visual layout for My Time Off and My Allocations.
Original task card for this PR.