feat: add __enter__ and __aenter__ for context manager support - #642
Closed
Pawansingh3889 wants to merge 1 commit into
Closed
feat: add __enter__ and __aenter__ for context manager support#642Pawansingh3889 wants to merge 1 commit into
Pawansingh3889 wants to merge 1 commit into
Conversation
Client and AsyncClient had __exit__/__aexit__ and close() methods but were missing __enter__/__aenter__, so `with Client() as c:` and `async with AsyncClient() as c:` would raise TypeError. Closes #532
This was referenced Apr 6, 2026
ParthSareen
self-requested a review
April 22, 2026 07:55
Ghraven
added a commit
to Ghraven/ollama-python
that referenced
this pull request
May 3, 2026
Fixes ollama#642 While `BaseClient` inherits from both `AbstractContextManager` and `AbstractAsyncContextManager`, it only defined `__exit__` and `__aexit__`. `AbstractContextManager` provides a default `__enter__` that returns `self`, but `AbstractAsyncContextManager.__aenter__` is abstract and must be implemented explicitly — meaning `async with AsyncClient() as c:` raised `TypeError` at runtime. This commit adds explicit `__enter__` and `__aenter__` methods that both return `self`, completing the context manager protocol for both sync and async clients and making `with Client() as c:` and `async with AsyncClient() as c:` work as expected.
Author
|
Closing this as I tidy up my open PRs and refocus my contributions. Happy for anyone to pick it up if it's useful. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds missing enter and aenter to BaseClient. close()/exit already existed but without entry methods,
with Client() as c:raised TypeError.