Add browser profile picker to web app setup - #9679
Open
cbullard wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--profile-directorydirectly in the generated desktop launcherAutomaticas the default, preserving current behaviorThe direct launcher binding keeps the choice visible and portable, requires no separate runtime profile store, and lets other desktop-entry work inspect the selected profile.
Browser support
Profile discovery follows the browsers already supported by
omarchy-launch-webapp: Chromium, Chrome, Brave, Brave Origin, Edge, Opera, Vivaldi, and Helium. Unsupported default browsers continue to use Chromium's profile state because web apps already fall back to Chromium.Related work
#6105 proposes a broader profile-aware runtime for the older
devbranch, including remembered launch-time choices. This is an independent, narrower Quattro implementation: it binds a profile only during web app creation and writes the choice into the launcher itself.Testing
bash test/shell.d/webapp-browser-profile-test.shbash test/shell.d/webapp-install-test.shbash test/shell.d/webapp-name-test.shbash test/shell.d/webapp-install-escaping-test.sh./test/cli./test/shell— 221 of 226 files passed; the same five unrelated graphical/package-coverage failures reproduce on untouchedorigin/quattroLocal State; generated launcher passeddesktop-file-validateand preservedProfile 2as one argument