Skip to content

Fix test timing issue in ImageCacheTests #2401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
onevcat merged 1 commit into from
Jun 22, 2025
Merged

Fix test timing issue in ImageCacheTests #2401

onevcat merged 1 commit into from
Jun 22, 2025

Conversation

@onevcat
Copy link
Owner

@onevcat onevcat commented Jun 22, 2025 •
edited
Loading

Summary

  • Increased delay from 1 to 2 seconds in testCleanDiskCacheWithUsedSpaceInsufficient test
  • Fixes CI test stability issues caused by disk cache file writing timing

Test plan

  • Run test suite locally with bundle exec fastlane tests
  • Verify CI tests pass consistently
  • Confirm the test no longer fails intermittently

@onevcat
Fix test timing issue in ImageCacheTests
62532ad 
Increase delay from 1 to 2 seconds in testCleanDiskCacheWithUsedSpaceInsufficient to accommodate file writing in disk cache which has an approximate (round) creating time. This resolves CI test stability issues.
@onevcat onevcat merged commit 2d051fa into master Jun 22, 2025
48 checks passed
@onevcat onevcat deleted the fix-test-timing-issue branch June 22, 2025 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@onevcat