Prom exporter update #7934
Prom exporter update #7934
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #7934 +/- ##
============================================
+ Coverage 90.09% 90.10% +0.01%
- Complexity 7432 7447 +15
============================================
Files 834 835 +1
Lines 22537 22574 +37
Branches 2236 2240 +4
============================================
+ Hits 20304 20340 +36
+ Misses 1532 1531 -1
- Partials 701 703 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| * @deprecated {@code otel_scope_*} attributes are always generated. | ||
| */ | ||
| /** Set if the {@code otel_scope_*} attributes are generated. Default is {@code true}. */ | ||
| @SuppressWarnings("UnusedReturnValue") |
There was a problem hiding this comment.
These suppressions should go on the caller, not this method. If we wanted to inform callers that the response can safely be ignored, we'd use @CanIgnoreReturnValue.
https://errorprone.info/bugpattern/CheckReturnValue
I think you probably copy / pasted this. It must have slipped through the cracks.
| import javax.annotation.Nullable; | ||
|
|
||
| /** Builder for {@link PrometheusMetricReader}. */ | ||
| public final class PrometheusMetricReaderBuilder { |
There was a problem hiding this comment.
IIRC, the PrometheusMetricReader isn't part of the spec. I suppose it makes sense to keep the configuration options in sync with PrometheusHttpServer. Is that the idea here?
| counter.add(1); | ||
| } | ||
|
|
||
| @SuppressWarnings("resource") |
There was a problem hiding this comment.
I know you didn't write this but this suppression is redundant since this warning is already suppressed at the class level
jack-berg
left a comment
jack-berg
left a comment
There was a problem hiding this comment.
Couple of nits but looks good. Thanks!
2 participants
Update to latest declarative configuration.
See open-telemetry/opentelemetry-configuration#474 for a clarification in semantics.