Skip to content

fix: defer getWorkingTreeState call and clean up process exit handling #415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fix2015 wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −6
Open

fix: defer getWorkingTreeState call and clean up process exit handling #415

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion plugins/codex/scripts/lib/git.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,6 @@ export function resolveReviewTarget(cwd, options = {}) {

const requestedScope = options.scope ?? "auto";
const baseRef = options.base ?? null;
const state = getWorkingTreeState(cwd);
const supportedScopes = new Set(["auto", "working-tree", "branch"]);

if (baseRef) {
Expand Down Expand Up @@ -172,6 +171,8 @@ export function resolveReviewTarget(cwd, options = {}) {
};
}

const state = getWorkingTreeState(cwd);

if (state.isDirty) {
return {
mode: "working-tree",
Expand Down
5 changes: 1 addition & 4 deletions plugins/codex/scripts/lib/state.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import os from "node:os";
import path from "node:path";

import { resolveWorkspaceRoot } from "./workspace.mjs";
import { nowIso } from "./tracked-jobs.mjs";

const STATE_VERSION = 1;
const PLUGIN_DATA_ENV = "CLAUDE_PLUGIN_DATA";
Expand All @@ -12,10 +13,6 @@ const STATE_FILE_NAME = "state.json";
const JOBS_DIR_NAME = "jobs";
const MAX_JOBS = 50;

function nowIso() {
return new Date().toISOString();
}

function defaultState() {
return {
version: STATE_VERSION,
Expand Down
2 changes: 1 addition & 1 deletion plugins/codex/scripts/session-lifecycle-hook.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,5 +129,5 @@ async function main() {

main().catch((error) => {
process.stderr.write(`${error instanceof Error ? error.message : String(error)}\n`);
process.exit(1);
process.exitCode = 1;
});