fix(cli): make --llms-full complete and accurate - #474
Conversation
|
@codex review |
|
Security review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
|
Codex Review: Didn't find any major issues. Nice work! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5789da8956
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
|
Security review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d2e63a0a1d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| INCUR_VALUE_OPTIONS.has(argument) && | ||
| argv[index + 1] !== undefined |
There was a problem hiding this comment.
When an accepted equals-form global option precedes the command path, such as codex-security --filter-output=scan scans show --llms-full, this exact lookup does not consume it. renderFullMarkdownManifest consequently treats the option as the first command argument and leaves the scope empty, producing a root heading and root operating guide even though Incur selected only scans show; handle equals forms for --filter-output, --token-limit, and --token-offset before deriving the scope.
Useful? React with 👍 / 👎.
| if (options && property.type === "array") { | ||
| details.push("Repeat this flag for multiple values."); | ||
| if (Array.isArray(property.default)) { | ||
| details.push(`Default: ${codeValue(property.default)}.`); | ||
| } |
There was a problem hiding this comment.
Every repeatable option such as --path, --knowledge-base, and --codex is an array whose string items have a minimum length, but Zod places that constraint under property.items and this branch only describes repetition and the outer default. Because Incur does not render these constraints itself, the full manifest omits that empty repeated values are rejected; include applicable item-level constraints when documenting arrays.
Useful? React with 👍 / 👎.
…/codex/fix-llms-full-manifest
|
@codex review Please review the current head, |
|
Security review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 59ae515c1f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| { commands: [{ name: command }] }, | ||
| [command], | ||
| ); | ||
| expect(scoped).toMatch(/--filter-output.*only to command results/u); |
There was a problem hiding this comment.
The latest commit reintroduces an assertion on exact generated English by requiring the words “only to command results,” so a harmless copy edit will fail this test even when filtering behavior and documented restrictions remain correct. Assert a stable semantic property or source-of-truth value instead; this is fresh evidence after the earlier wording assertions were removed.
AGENTS.md reference: sdk/typescript/AGENTS.md:L29-L32
Useful? React with 👍 / 👎.
|
@codex review Please review the current head, |
|
Security review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
|
Codex Review: Didn't find any major issues. Nice work! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
zcrab-oai
left a comment
zcrab-oai
left a comment
There was a problem hiding this comment.
Reviewed the generated CLI reference against actual command schemas; verified scoped equals-form options and repeatable-value constraints.
|
@codex review Please review the current head, |
|
Security review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
|
Codex Review: Didn't find any major issues. Delightful! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
@codex review Please review exact head |
|
Codex Review: Didn't find any major issues. 🚀 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
@codex security review Please review the current head |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 025bf950a1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| ...commands.map((command) => { | ||
| const restrictions = commandResultRestrictions(command.name ?? ""); | ||
| return [ | ||
| Skill.generate(cli.name, [command]).replace(/^#/gmu, "###"), |
There was a problem hiding this comment.
The generated patch --llms-full reference lists these options independently, but the live handler in cli.ts rejects combining --linear-issue with --linear-project, requires --linear-project for --linear-filter, and requires either selector for --linear-api-key. Because patch has no hint containing those rules and scoped output omits the README operating guide, an agent following this reference can construct commands that are guaranteed to fail; derive these restrictions from the runtime rules or add shared command guidance.
AGENTS.md reference: sdk/typescript/AGENTS.md:L16-L16
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
I checked the exact head 025bf950 against main 37bf87a6. The patch option checks on main and the missing command hint are unchanged by this PR. The new reference uses the live command schemas and hints; scoped output deliberately points to the root operating guide.
A shared runtime/reference hint could improve discoverability, but the independent source review found no introduced regression or violation of the schema-derived reference contract. I have left this as a follow-up suggestion rather than changing the command-validation model during the CI/conflict repair. Leaving the thread open for maintainer disposition.
2 participants
Summary
Make
--llms-fulla complete reference for the installed CLI. The reference uses the live command schemas and documents the options, constraints, and output modes that the CLI supports.Changes
Testing
Current head
025bf950:Earlier full-suite, package, and review results remain historical evidence, not results for this merge.
Risk and rollout
This keeps Incur's live parser schemas and the existing command-result policy. There is no dependency, persisted-state, or bundled-plugin-version change. Current-head cross-platform CI, required human review, and disposition of older source-fixed review threads remain merge conditions. This update does not merge or release anything.
Public disclosure review
Newly authored material and the current public PR surface were reviewed for disclosure. Existing automated review comments contain access-restricted report references; maintainer cleanup remains outstanding.