feat(cli): show patch tasks in Codex desktop - #477
Conversation
mldangelo-oai
left a comment
There was a problem hiding this comment.
Non-blocking follow-up to my earlier comment on 43fd1b26. The installed package's normal patch and resume path worked. The additional protocol tests found three cases worth covering: a child task can finish the parent command, a server request for user input can go unanswered, and an early disconnect can return success.
The full local suite passed 1,288 tests with 11 skipped, and the current GitHub checks are green. I left the observed behavior and suggested regression tests inline. A small app-server helper shared with #471 would give these cases one place to live.
|
Non-blocking design summary for #475, #477, #471, and #461. I think the split is right: keep the pinned scan runtime isolated, share task visibility, and let the user continue a saved patch task. I'd keep the implementation small:
Across the four PR heads and a #475+#477 integration tree, five full local suite runs produced 6,336 passes and 55 skips. The real-model patch and saved-task resume paths worked with synthetic fixtures. The current heads do not yet provide one complete Linear issue to GitHub PR workflow; I did not use live Linear or create an external PR. My suggested follow-up order is the #477 lifecycle tests, the #471 naming and Windows cleanup, then the common patch result and publication recovery. After those pieces are joined, one explicitly scoped live acceptance test would close the remaining gap. |
zcrab-oai
left a comment
There was a problem hiding this comment.
Found a project-isolation regression in the transition from ephemeral patch execution to persistent desktop tasks.
kmbroai
left a comment
There was a problem hiding this comment.
Preapproving - should fix some of the comments
Summary
Patch tasks did not appear in Codex desktop because the CLI created ephemeral
codex execsessions. The desktop app also excludes savedexecsessions from its task list.Changes
Testing
Risk and rollout
Saved patch tasks can contain finding details. User configuration and explicitly trusted project configuration remain active. Patching does not grant project trust. The workspace-write sandbox and
neverapproval policy remain enforced. The desktop app is optional.Public disclosure review