fix: Add Chat Completions choices data in traces when using streaming #725
Conversation
|
seratch
left a comment
seratch
left a comment
There was a problem hiding this comment.
Thanks for sending this patch!
I have a few points on the suggested changes:
- my comment on the conversion logic maintenance cost
- add unit tests covering the scenario
| ) { | ||
| response.choices = event.response.output | ||
| .flatMap((o): OpenAI.Chat.Completions.ChatCompletion.Choice[] => { | ||
| if (o.type === 'function_call') { |
There was a problem hiding this comment.
The logic here requires updates when the platform adds new types. We'd like to explore more robust way to handle the conversion here.
There was a problem hiding this comment.
Yeah, I was worried about that too. Do you have any suggestions? This is the first time I've actually looked into this API!
There was a problem hiding this comment.
@seratch do you have any preferences on how to handle the conversion here?
seratch
changed the title
|
This PR is stale because it has been open for 10 days with no activity. |
2 participants
This PR attempts to fix the issue described at the bottom of #652 - the
choicesare missing from spans for Chat Completions, forGenerationspans.I'm unsure if this is the best way to do this, so I'm opening this to get a discussion going!