Conversation
adding pyyaml
…roShoot params and the format is the same
pradal
commented
Jun 16, 2026
| json.dump(data, f, indent=4) | ||
|
|
||
|
|
||
| class Parameter: |
Contributor
Author
There was a problem hiding this comment.
For Parameter, I would use a Data Class.
Look at it
| self.uid = uid | ||
| self.uri = uri | ||
|
|
||
| def to_dict(self): |
Contributor
Author
There was a problem hiding this comment.
this is also directly managed by dataclass
https://docs.python.org/3/library/dataclasses.html
| def __str__(self): | ||
| return f"name={self.name}, value={self.value}, unit={self.unit}, param_type={self.param_type}, description={self.description}, uid={self.uid}, uri={self.uri}" | ||
|
|
||
| class MyModelUnit: |
Contributor
Author
There was a problem hiding this comment.
The My in MyModel is just for tutos.
Rename it!
Like ModelUnitConfig
| return f"name={self.name}, value={self.value}, unit={self.unit}, param_type={self.param_type}, description={self.description}, uid={self.uid}, uri={self.uri}" | ||
|
|
||
| class MyModelUnit: | ||
| def __init__(self, name, parameters: list): |
| def __str__(self): | ||
| return f"name={self.name}, value={self.value}, unit={self.unit}, param_type={self.param_type}, description={self.description}, uid={self.uid}, uri={self.uri}" | ||
|
|
||
| class MyModelUnit: |
Contributor
Author
There was a problem hiding this comment.
You can also inherit from dict, no?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.