Allow sqlutils clients to register their own loggers.#13
Open
kamil-holubicki wants to merge 1 commit intoopenark:masterfrom
Open
Allow sqlutils clients to register their own loggers.#13kamil-holubicki wants to merge 1 commit intoopenark:masterfrom
kamil-holubicki wants to merge 1 commit intoopenark:masterfrom
Conversation
Problem: sqlutils emits error logs directly through log.Errore() calls. These logs contain only basic information like query, but are missing the caller context (who in which contexts executes the particular query) Solution: Allow registering client side logger which will be used instead of internal logging. Client-side logger can add context information to logs and format logs in the desired way.
|
Thank you! I'm in a bit of a sabbatical from maintaining my personal OSS projects, so with regrets I won't be reviewing/merging this, even though the change is likely good and trivial, and I do appreciate your time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
sqlutils emits error logs directly through log.Errore() calls. These logs contain only basic information like query, but are missing the caller context (who in which contexts executes the particular query)
Solution:
Allow registering client side logger which will be used instead of internal logging. Client-side logger can add context information to logs and format logs in the desired way.