Skip to content

Conversation

@jawad-khan
Copy link
Member

Description

Removed unused deprecated DEFAULT_HASHING_ALGORITHM django settings from repo.

Useful information to include:

  • This will not effect any user.

Supporting information

This PR solves issue

Deadline

"None"

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the deprecated DEFAULT_HASHING_ALGORITHM Django setting from the edx-platform repository. This setting was previously used to control session hash algorithms but is no longer needed after upgrading to Django 4.x where the setting no longer applies.

Key changes:

  • Removed DEFAULT_HASHING_ALGORITHM setting from all configuration files
  • Removed legacy hash verification code that handled fallback to older hashing algorithms
  • Cleaned up related test methods that validated hash algorithm switching behavior

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.

Show a summary per file
File Description
openedx/envs/common.py Removed deprecated DEFAULT_HASHING_ALGORITHM='sha256' setting
cms/envs/common.py Removed deprecated DEFAULT_HASHING_ALGORITHM='sha256' setting
lms/envs/mock.yml Removed DEFAULT_HASHING_ALGORITHM: sha256 configuration
cms/envs/mock.yml Removed DEFAULT_HASHING_ALGORITHM: sha256 configuration
openedx/core/djangoapps/safe_sessions/tests/test_middleware.py Removed test code wrapping verification with DEFAULT_HASHING_ALGORITHM setting
openedx/core/djangoapps/cache_toolbox/tests/test_middleware.py Removed test helper method and test cases for hash algorithm switching; removed unused imports
openedx/core/djangoapps/cache_toolbox/middleware.py Removed monitoring of DEFAULT_HASHING_ALGORITHM and legacy hash verification fallback logic

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants