Skip to content

Conversation

@farhan
Copy link
Contributor

@farhan farhan commented Dec 30, 2025

Ticket: openedx/public-engineering#471

Move editor_saved to VideoConfigService

This moves edx-platform-specific logic out of the VideoBlock, in preparation for the VideoBlock extraction:
#36282

Legacy Video Editor changes in this PR:

Removed:

  • studio_view() method

Not removed:

  1. editor_saved
  2. get_context() method
  3. EditingMixin usage

Why these methods still retained?
Removing these method breaks:

  1. Transcript uploads on the Video Block in the Content Library (Beta/V2).
  2. Fetching uploaded transcripts on authoring mfe video editor window.

To avoid this regression, they have been kept for now.

Below are the details of the testing.

Here are my testing notes:

Testing on LMS/Studio:

A. Uploading transcript

  1. Go to any course, add a video (youtube video) into the course
  2. Add the transcript via settings
  3. Transcript should be uploaded successfully
  4. Transcript should render successfully on the studio
  5. Publish the course
  6. Video Block and transcript should render successfully on the LMS

B. Deleting transcript

  1. After performing above steps, now delete the transcript from the video block.
  2. Transcript should be deleted successfully and should stop appearing on the studio.
  3. Publish the course.
  4. Transcript should stop appearing on the lms as well

Testing on Content Library (Beta/V2):

C. Uploading transcript

  1. Go to any content library > Units tab
image
  1. Create a new unit and video block as a content in the unit.
image
  1. Save the video and then edit the video again to upload/add the transcript. Transcript should be uploaded/added successfully.
image
  1. Video and transcript should be render successfully in the content library preview.

  2. Go to any course, Add the block/unit from the library via 'Use unit from library' button

  3. Transcript should render successfully on the studio

  4. Publish the course transcript should render successfully on the studio

D. Deleting transcript

  1. After performing above steps, now delete the transcript from the video block in the content library.
  2. Transcript should be deleted successfully in the content library preview.
  3. Sync the block in the course with the content library version.
  4. Transcript should stop appearing on the course as well.
  5. Publish the course.
  6. Transcript should stop appearing on the lms as well

All the fields of the Video XBlock Editor Window should be edited properly for both studio and content library.

Sample screen shot:

Screenshot 2026-01-02 at 7 36 38 PM

Copy/Paste of the Video Block from Course to the Content Library and vice versa should work properly.

All testing has been done with in this PR sandbox.

* This moves edx-platform-specific logic out of the VideoBlock,
in preparation for the VideoBlock extraction
@farhan farhan changed the title move editor_saved to VideoConfigService move editor_saved to VideoConfigService - 2 Dec 30, 2025
@farhan farhan added the create-sandbox open-craft-grove should create a sandbox environment from this PR label Dec 30, 2025
@open-craft-grove
Copy link

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

@farhan farhan changed the title move editor_saved to VideoConfigService - 2 Move editor_saved to VideoConfigService Dec 31, 2025
@farhan farhan marked this pull request as ready for review January 2, 2026 14:43
@farhan farhan requested a review from ttqureshi January 2, 2026 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

create-sandbox open-craft-grove should create a sandbox environment from this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants