Move editor_saved to VideoConfigService #37829
Open
+71
−59
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: openedx/public-engineering#471
Move editor_saved to VideoConfigService
This moves edx-platform-specific logic out of the VideoBlock, in preparation for the VideoBlock extraction:
#36282
Legacy Video Editor changes in this PR:
Removed:
Not removed:
Why these methods still retained?
Removing these method breaks:
To avoid this regression, they have been kept for now.
Below are the details of the testing.
Here are my testing notes:
Testing on LMS/Studio:
A. Uploading transcript
B. Deleting transcript
Testing on Content Library (Beta/V2):
C. Uploading transcript
Video and transcript should be render successfully in the content library preview.
Go to any course, Add the block/unit from the library via 'Use unit from library' button
Transcript should render successfully on the studio
Publish the course transcript should render successfully on the studio
D. Deleting transcript
All the fields of the Video XBlock Editor Window should be edited properly for both studio and content library.
Sample screen shot:
Copy/Paste of the Video Block from Course to the Content Library and vice versa should work properly.
All testing has been done with in this PR sandbox.