Skip to content

Conversation

@pine919
Copy link

@pine919 pine919 commented Feb 10, 2026

Description

Fixes issue where Studio's edit popup shows incorrect weight for legacy XML problems with multiple sub-problems.

Problem: When importing courses with legacy XML problems containing multiple response fields (e.g., 3 multiple-choice questions), the problem correctly displays "3 points possible" and grades properly, but clicking "Edit" in Studio shows "1 point" instead of "3 points" in the settings popup.

Root Cause: Problems imported without an explicit weight attribute don't have the field stored in block settings. The own_metadata() function only returns explicitly set fields, so Studio's edit popup shows the default weight (1) instead of the calculated value from max_score().

Solution: Modified get_block_info() to populate weight from max_score() for problem blocks without explicit weight. This only affects metadata returned for Studio editing, not stored data or grading behavior.

Impact:

  • Course Authors: Studio edit popup now shows correct weight for imported legacy problems
  • No changes to learner experience or grading (already working correctly)
  • Backward compatible with existing problems

Supporting information

Fixes #37993

Testing instructions

  1. Import a course with a legacy XML problem containing multiple sub-problems (or create one with multiple <multiplechoiceresponse> tags)
  2. Navigate to the course outline in Studio
  3. Verify the problem shows "X points possible" where X > 1
  4. Click "Edit" on the problem
  5. Verify the settings popup now shows the correct weight (X points) instead of 1 point

Unit Tests:

pytest cms/djangoapps/contentstore/xblock_storage_handlers/tests/test_problem_weight_fix.py

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Feb 10, 2026
@openedx-webhooks
Copy link

Thanks for the pull request, @pine919!

This repository is currently maintained by @openedx/wg-maintenance-openedx-platform.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Submit a signed contributor agreement (CLA)

⚠️ We ask all contributors to the Open edX project to submit a signed contributor agreement or indicate their institutional affiliation.
Please see the CONTRIBUTING file for more information.

If you've signed an agreement in the past, you may need to re-sign.
See The New Home of the Open edX Codebase for details.

Once you've signed the CLA, please allow 1 business day for it to be processed.
After this time, you can re-run the CLA check by adding a comment below that you have signed it.
If the CLA check continues to fail, you can tag the @openedx/cla-problems team in a comment for further assistance.

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@pine919 pine919 force-pushed the pine919/fix-simplify-content-gropups-api branch 2 times, most recently from ee632a2 to 8f5d099 Compare February 11, 2026 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

open-source-contribution PR author is not from Axim or 2U

Projects

Status: Needs Triage

Development

Successfully merging this pull request may close these issues.

Legacy Problem weight issue when importing

3 participants