feanil/add pyproject file#15
Merged
Merged
Conversation
This is the minimal amount needed to start using this file in the project.
Moving the necessary dynamic settings from setup.py to pyproject.toml A few settings were not migrated because their values are the default when a pyproject.toml file is used and a few were not moved because they were deprecated. Full list that I used for reference is here: https://setuptools.pypa.io/en/latest/userguide/pyproject_config.html#setuptools-specific-configuration The constraint.txt reference is not PEP508 compliant so is not supported for the files that are read in by setuptools. So I moved the constraint into the makefile call for base.in so it could still serve as the source of truth for dependencies for this project.
Replace with pyproject.toml references as appropriate.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #15 +/- ##
=======================================
Coverage 88.20% 88.20%
=======================================
Files 13 13
Lines 407 407
Branches 16 16
=======================================
Hits 359 359
Misses 40 40
Partials 8 8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This replaces everything in setup.py with the equivalent pyproject.toml tooling. It still uses setuptools under the hood.
Along with CI, I also tested this by installing the package and comparing the list of files that were packaged in the built package.