Skip to content

Add Alliance Extension Handling#3903

Merged
evanpelle merged 1 commit into
openfrontio:mainfrom
babyboucher:AllyingHotKeyFix
May 12, 2026
Merged

Add Alliance Extension Handling#3903
evanpelle merged 1 commit into
openfrontio:mainfrom
babyboucher:AllyingHotKeyFix

Conversation

@babyboucher
Copy link
Copy Markdown
Contributor

Description:

Allows the Alliance hotkey to extend an alliance as expected by https://discord.com/channels/1284581928254701718/1503351192921571409

Please complete the following:

  • I have added screenshots for all UI updates
  • I process any text displayed to the user through translateText() and I've added it to the en.json file
  • I have added relevant tests to the test directory
  • I confirm I have thoroughly tested these changes and take full responsibility for any bugs introduced

Please put your Discord username so you can be contacted if a bug or regression is found:

babyboucher

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 11, 2026

Review Change Stack
No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 78e5a6b6-b46f-40fc-a4d9-75d6ab80a24b

📥 Commits

Reviewing files that changed from the base of the PR and between 2b04c56 and 99ae37c.

📒 Files selected for processing (1)
  • src/client/ClientGameRunner.ts

Walkthrough

ClientGameRunner now supports alliance extension intents. When requesting an alliance under the cursor, if the alliance can be extended, an additional SendAllianceExtensionIntentEvent is emitted alongside the existing alliance request event.

Changes

Alliance Extension Intent Support

Layer / File(s) Summary
Event Type Import
src/client/ClientGameRunner.ts
SendAllianceExtensionIntentEvent is added to the transport event imports.
Alliance Extension Handler
src/client/ClientGameRunner.ts
doRequestAllianceUnderCursor now checks allianceInfo?.canExtend and emits SendAllianceExtensionIntentEvent when an alliance can be extended.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🤝 Alliances now stretch and grow,
Extension intents begin to flow,
When cursor clicks on bonds to share,
New ties form with extra care. ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and directly describes the main change: adding alliance extension handling functionality.
Description check ✅ Passed The description explains the purpose (enabling Alliance hotkey to extend alliances), references the related Discord discussion, and confirms checklist items completed including tests and translations.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

  • Generate code and open pull requests
  • Plan features and break down work
  • Investigate incidents and troubleshoot customer tickets together
  • Automate recurring tasks and respond to alerts with triggers
  • Summarize progress and report instantly

Built for teams:

  • Shared memory across your entire org—no repeating context
  • Per-thread sandboxes to safely plan and execute work
  • Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-project-automation github-project-automation Bot moved this from Triage to Final Review in OpenFront Release Management May 12, 2026
@evanpelle evanpelle added this to the v32 milestone May 12, 2026
@evanpelle evanpelle merged commit 5279f9b into openfrontio:main May 12, 2026
12 of 13 checks passed
@github-project-automation github-project-automation Bot moved this from Final Review to Complete in OpenFront Release Management May 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Complete

Development

Successfully merging this pull request may close these issues.

2 participants