Fixes and QoL changes for the "Strait of Malacca" map

[RickD004]

Description:

Fixes:

Various rivers with pixel-gap errors, that made players and ships unable to boat out of the river into the sea. This error was reported in the Discord server

Also changes:

• Better Terrain (old version had no brown terrain and smidges of white terrain, which made almost all the map practically green terrain). The coastlines and terrain area remain the exact same ( the small land change in manifest was because the old map had little random pixel lakes all around)

• More Nations (NPCs) , more consistent names for them, and an extra flag (Aceh)

Please complete the following:

• I have added screenshots for all UI updates
• I process any text displayed to the user through translateText() and I've added it to the en.json file
• I have added relevant tests to the test directory
• I confirm I have thoroughly tested these changes and take full responsibility for any bugs introduced

Please put your Discord username so you can be contacted if a bug or regression is found:

tri.star1011

[coderabbitai]

Walkthrough

This PR updates the Strait of Malacca map data across three files: Aceh is registered as a distinct country/region, map display names are standardized to title case, and the nations array is expanded with detailed Indonesian regional entries while removing generic groupings. Map tile counts are adjusted to reflect the updated geographic coverage.

Changes

Strait of Malacca Map Data Update

Layer / File(s)	Summary
Add Aceh to global country registry resources/countries.json	Aceh is added as a new country/region entry with code "Aceh", continent "Asia", and name "Aceh".
Update map source metadata and nations map-generator/assets/maps/straitofmalacca/info.json	Display name changes from "straitofmalacca" to "Strait Of Malacca". Nations array is expanded to include specific Indonesian regions (North Sumatra, West Sumatra, Riau, Bangka Belitung, Lampung, Bengkulu, South Sumatra, Jambi, Riau Islands) with updated coordinates. Aceh's flag value changes from "id" to "Aceh". Generic entries (Sumatra, Burmese Pythons, Samosir, Barisan) are removed.
Sync map manifest metadata and tile counts resources/maps/straitofmalacca/manifest.json	Display name updates to "Strait Of Malacca". Land tile counts are adjusted for map, map16x, and map4x variants. Nations array is synchronized with the expanded Indonesian regional entries from the source file.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🗺️ From one great mass, a map takes shape,
Aceh stands proud on every escapescape,
Indonesian regions bloom with fresh detail—
Coordinates dance, tile counts scale,
A Strait of clearer boundaries now set sail! 🌊

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately summarizes the main changes: fixes to rivers and quality-of-life improvements to the Strait of Malacca map, which aligns with the changeset modifications to map metadata, nations data, and terrain.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Description check	✅ Passed	The PR description clearly relates to the changeset, detailing fixes for river pixel-gap errors, terrain improvements, and NPC nation changes that directly correspond to the map metadata and configuration file updates shown in the summary.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

Warning

Review ran into problems

🔥 Problems

Git: Failed to clone repository. Please run the @coderabbitai full review command to re-trigger a full review. If the issue persists, set path_filters to include or exclude specific files.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[RickD004]

Thanks @evanpelle but do you think it could be possible to cherrypick this for v31 since it fixes an error that affects gameplay ? People are putting ports on landlocked rivers which makes them waste money and get no trade