Change name of map "The Straits" into "Danish Straits"

[RickD004]

Description:

Renames TheStraits map. The people that suggested this map told me they would prefer a more specific name for the map, rather than the generic one it has right now. So im renaming it into Danish Straits

This map is for v32, it has not been released, it should be fine to rename

Please complete the following:

• I have added screenshots for all UI updates
• I process any text displayed to the user through translateText() and I've added it to the en.json file
• I have added relevant tests to the test directory
• I confirm I have thoroughly tested these changes and take full responsibility for any bugs introduced

Please put your Discord username so you can be contacted if a bug or regression is found:

tri.star1011

[coderabbitai]

Walkthrough

Rename the straits map from TheStraits to DanishStraits throughout the codebase. Update the core enum and category in Game.ts, the generator registry in main.go, metadata and translation keys in config files, and the playlist frequency map in MapPlaylist.ts.

Changes

Map Rename from TheStraits to DanishStraits

Layer / File(s)	Summary
Core game type definition src/core/game/Game.ts	GameMapType enum replaces TheStraits with DanishStraits, and mapCategories.regional is updated to use the new enum value.
Map generator registry map-generator/main.go	Registry adds danishstraits entry and removes thestraits so the map generator recognizes the renamed map.
Map metadata and localization map-generator/assets/maps/danishstraits/info.json, resources/maps/danishstraits/manifest.json, resources/lang/en.json	Map name fields and translation keys updated from thestraits/"The Straits" to danishstraits/"Danish Straits" across metadata and i18n.
Playlist frequency configuration src/server/MapPlaylist.ts	FREQUENCY map adds DanishStraits with value 5 and removes TheStraits to control map rotation in public playlists.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

• openfrontio/OpenFrontIO#3920: Both PRs touch the same map-enablement plumbing—adding/updating GameMapType and mapCategories.regional in src/core/game/Game.ts and inserting/removing entries in src/server/MapPlaylist.ts's FREQUENCY to control which maps appear in the generator/playlist—just for different maps.

Suggested reviewers

• evanpelle

Poem

🗺️ The straits now bear a Danish name,
Through types and configs, all the same,
From enum to playlist, files align,
A map rename, clean and fine! ✨

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately summarizes the main change: renaming the map from 'The Straits' to 'Danish Straits' across all relevant files.
Description check	✅ Passed	The description clearly explains the purpose of the rename, provides context about the map's status (v32, unreleased), and details the author's testing and documentation efforts.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 golangci-lint (2.12.2)

level=error msg="[linters_context] typechecking error: pattern ./...: directory prefix . does not contain main module or its selected dependencies"

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@src/core/game/Game.ts`:
- Line 174: You renamed an enum value from TheStraits to DanishStraits but
didn't add/update tests under core; update unit tests that reference the old
enum value (search for TheStraits) and add a small test asserting the enum
contains DanishStraits (and any serialization/deserialization or string-mapping
behavior that depends on it), and update any existing tests or fixtures that
used TheStraits to use DanishStraits so CI covers this core change.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: dcc53ee1-e29f-46f9-92f4-f582a0443214

📥 Commits

Reviewing files that changed from the base of the PR and between 7359e2b and 3f0b0d4.

⛔ Files ignored due to path filters (4)

• map-generator/assets/maps/danishstraits/image.png is excluded by !**/*.png
• resources/maps/danishstraits/map.bin is excluded by !**/*.bin
• resources/maps/danishstraits/map16x.bin is excluded by !**/*.bin
• resources/maps/danishstraits/map4x.bin is excluded by !**/*.bin

📒 Files selected for processing (7)

• map-generator/assets/maps/danishstraits/info.json
• map-generator/main.go
• resources/lang/en.json
• resources/maps/danishstraits/manifest.json
• resources/maps/danishstraits/thumbnail.webp
• src/core/game/Game.ts
• src/server/MapPlaylist.ts

[RickD004]

Requested change by Rabbit has been clarified but it is not dismissing it, ignore it

[FloPinguin]

Thanks

[coderabbitai]

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[FloPinguin]

@coderabbitai approve

[coderabbitai]

✅ Actions performed

Comments resolved and changes approved.