Adds Indian Subcontinent map#3975
Conversation
WalkthroughThis PR adds the Indian Subcontinent as a new playable map: assets and manifest are added, the map is registered in the generator and GameMapType, playlist frequency and English label are set, and three region entries are added to the country list. ChangesIndian Subcontinent Map Onboarding
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@map-generator/assets/maps/indiansubcontinent/info.json`:
- Around line 51-52: Update the JSON entry where the "name" key currently has
the misspelled value "Andamar & Nicobar Islands" and change it to the correct
"Andaman & Nicobar Islands" so manifests and in-game labels are generated with
the correct nation name; locate the object containing the "name" key with that
exact value and replace only the value string.
In `@src/core/game/Game.ts`:
- Line 241: The GameMapType.IndianSubcontinent entry is currently placed in the
regional maps list but should be in the continental maps list; move the
GameMapType.IndianSubcontinent item from the regional/MapTypeRegional array into
the continental/MapTypeContinental collection (or change the classification
logic that builds continental vs regional lists to include
GameMapType.IndianSubcontinent) so it is categorized as continental and displays
under the correct map category.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 51900fe6-dda2-4e1a-a446-7c9abc7a339c
⛔ Files ignored due to path filters (7)
map-generator/assets/maps/indiansubcontinent/image.pngis excluded by!**/*.pngresources/flags/Azad Kashmir.svgis excluded by!**/*.svgresources/flags/Jammu and Kashmir.svgis excluded by!**/*.svgresources/flags/Sikkim.svgis excluded by!**/*.svgresources/maps/indiansubcontinent/map.binis excluded by!**/*.binresources/maps/indiansubcontinent/map16x.binis excluded by!**/*.binresources/maps/indiansubcontinent/map4x.binis excluded by!**/*.bin
📒 Files selected for processing (8)
map-generator/assets/maps/indiansubcontinent/info.jsonmap-generator/main.goresources/countries.jsonresources/lang/en.jsonresources/maps/indiansubcontinent/manifest.jsonresources/maps/indiansubcontinent/thumbnail.webpsrc/core/game/Game.tssrc/server/MapPlaylist.ts
There was a problem hiding this comment.
🧹 Nitpick comments (1)
map-generator/assets/maps/indiansubcontinent/info.json (1)
249-252: ⚡ Quick winConsider renaming "New Delhi" to "Delhi" for administrative consistency.
All other entries represent states, provinces, or administrative divisions (Kerala, Tamil Nadu, Punjab, etc.), but "New Delhi" is technically the capital city within the National Capital Territory of Delhi. For consistency with other administrative divisions on this map, consider using
"Delhi"or"National Capital Territory of Delhi"instead of"New Delhi".If highlighting the capital city is intentional for gameplay balance or recognition, this is fine—just noting the pattern difference.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@map-generator/assets/maps/indiansubcontinent/info.json` around lines 249 - 252, Rename the "name" value for the entry with coordinates [978, 550] (currently "New Delhi") to be consistent with other administrative divisions—use "Delhi" or "National Capital Territory of Delhi" in the "name" field; keep the rest of the object (coordinates and "flag": "in") unchanged so only the displayed label is updated.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@map-generator/assets/maps/indiansubcontinent/info.json`:
- Around line 249-252: Rename the "name" value for the entry with coordinates
[978, 550] (currently "New Delhi") to be consistent with other administrative
divisions—use "Delhi" or "National Capital Territory of Delhi" in the "name"
field; keep the rest of the object (coordinates and "flag": "in") unchanged so
only the displayed label is updated.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 222441d9-b15b-4581-bf60-07f987007ff4
📒 Files selected for processing (2)
map-generator/assets/maps/indiansubcontinent/info.jsonresources/maps/indiansubcontinent/manifest.json
✅ Files skipped from review due to trivial changes (1)
- resources/maps/indiansubcontinent/manifest.json
Description:
Adds Map of the Indian Subcontinent, with indian and pakistani states and surrounding countries, important rivers like the Ganges, Brahmaputra and Indus, and Tibet/ theHimalayas
2M land pixels and 52 Nations (i think its fitting that India has the most nations of a regional map, only continental maps have more)
Should be nice to boost whatever indian playerbase this game might have. This region also doesnt have any representation aside from continental maps
Elevation data from NASA DEM, already credited in CREDITS.md
No reference test is needed, the test suite automatically iterates over all GameMapType enum values — no map is hardcoded by name in the tests
Please complete the following:
Please put your Discord username so you can be contacted if a bug or regression is found:
tri.star1011