Add Korea Map

[crunchybbb2-hash]

Description:

Add map of korean peninsula. Size 1092x2149
Nations: 35
based on provinces

Please complete the following:

• I have added screenshots for all UI updates
• I process any text displayed to the user through translateText() and I've added it to the en.json file
• I have added relevant tests to the test directory
• I confirm I have thoroughly tested these changes and take full responsibility for any bugs introduced

Please put your Discord username so you can be contacted if a bug or regression is found:

DISCORD_USERNAME
crunchybbbbb @crunchybbbbb_59469

two teams nations war video https://www.youtube.com/watch?v=n4h7GAfAHTM

[coderabbitai]

Walkthrough

This pull request adds Korea as a new regional map option across the entire game stack. The Korea map type is registered in the game enum and category structure, added to the map generator registry with corresponding info and manifest metadata files, and integrated into the server's playlist selection system with localization support.

Changes

Korea Map Registration

Layer / File(s)	Summary
Game map type definition src/core/game/Game.ts	GameMapType.Korea enum member is added and included in mapCategories.regional alongside other regional maps.
Map generator setup map-generator/main.go, map-generator/assets/maps/korea/info.json, resources/maps/korea/manifest.json	Generator registry recognizes the korea map entry, and info.json provides map state (dimensions, crop data, nation records); manifest.json defines sizing for base and scaled variants plus nation coordinate/flag/strength metadata.
Server playlist and localization src/server/MapPlaylist.ts, resources/lang/en.json	MapPlaylist assigns Korea a frequency weight of 5 for playlist selection, and English language resources add the "korea" translation key.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

• openfrontio/OpenFrontIO#3920: Mirrors the end-to-end map registration pattern for the Northwest Passage map, following the same integration points across game types, generator, server playlist, and localization.

Suggested reviewers

• FloPinguin

Poem

🗺️ A kingdom arises on the map today,
Korea joins the regional fray,
From enum to manifest, a nations' display,
With frequency weights in the playlist at play. 🎮

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title 'Add Korea Map' clearly and concisely summarizes the main change—adding a new Korea map to the system.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Description check	✅ Passed	The pull request description clearly describes adding a Korea map with 1092x2149 dimensions and 35 nations based on provinces, directly aligned with the changeset.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🧹 Nitpick comments (2)

map-generator/main.go (1)

110-110: 💤 Low value

Consider maintaining alphabetical order in the maps registry.

The korea entry is added at the end of the list, but the registry appears to follow alphabetical ordering (e.g., japan, lemnos, lisbon). Placing it between japan (line 65) and lemnos (line 66) would maintain consistency and improve maintainability.

📋 Suggested placement

Move the korea entry to maintain alphabetical order:

   {Name: "japan"},
+  {Name: "korea"},
   {Name: "lemnos"},

Remove from line 110.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@map-generator/main.go` at line 110, The "korea" map entry is out of
alphabetical order in the maps registry; remove the existing {Name: "korea"}
entry at its current location and insert it between the "japan" and "lemnos"
entries so the slice stays alphabetically ordered (e.g., ... "japan", "korea",
"lemnos", ...).

src/core/game/Game.ts (1)

194-194: ⚡ Quick win

Remove unnecessary blank line.

This blank line appears to be an accidental addition within the continental array.

🧹 Proposed fix

     GameMapType.Oceania,
     GameMapType.Antarctica,
-  
   ],

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/core/game/Game.ts` at line 194, Remove the accidental blank line inside
the continental array literal in the Game class; locate the array declaration
named "continental" (the continental array within Game.ts) and delete the empty
line so the array entries are contiguous and formatted consistently.

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@map-generator/assets/maps/korea/info.json`:
- Around line 39-43: The "flag" value for the Nagasaki region is inconsistent:
it uses "Empire of Japan" while other Japanese regions use "jp"; update the
Nagasaki entry's "flag" property (the JSON object with "name": "Nagasaki" and
"coordinates": [963, 2093]) to use the standardized value "jp" so it matches
Fukuoka and Saga and avoids rendering inconsistencies.

---

Nitpick comments:
In `@map-generator/main.go`:
- Line 110: The "korea" map entry is out of alphabetical order in the maps
registry; remove the existing {Name: "korea"} entry at its current location and
insert it between the "japan" and "lemnos" entries so the slice stays
alphabetically ordered (e.g., ... "japan", "korea", "lemnos", ...).

In `@src/core/game/Game.ts`:
- Line 194: Remove the accidental blank line inside the continental array
literal in the Game class; locate the array declaration named "continental" (the
continental array within Game.ts) and delete the empty line so the array entries
are contiguous and formatted consistently.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 39e5a25b-249b-4f1d-8434-01590fc8a607

📥 Commits

Reviewing files that changed from the base of the PR and between 513057a and 91e7b5a.

⛔ Files ignored due to path filters (4)

• map-generator/assets/maps/korea/image.png is excluded by !**/*.png
• resources/maps/korea/map.bin is excluded by !**/*.bin
• resources/maps/korea/map16x.bin is excluded by !**/*.bin
• resources/maps/korea/map4x.bin is excluded by !**/*.bin

📒 Files selected for processing (7)

• map-generator/assets/maps/korea/info.json
• map-generator/main.go
• resources/lang/en.json
• resources/maps/korea/manifest.json
• resources/maps/korea/thumbnail.webp
• src/core/game/Game.ts
• src/server/MapPlaylist.ts