8200566: DistributionPointFetcher fails to fetch CRLs if the DistributionPoints field contains more than one DistributionPoint and the first one fails

[TheMangovnik]

Backport of JDK-8200566 - DistributionPointFetcher fails to fetch CRLs if the DistributionPoints field contains more than one DistributionPoint and the first one fails.

Conflicts

src/java.base/share/classes/sun/security/provider/certpath/DistributionPointFetcher.java

<<<<<<< HEAD
 * Copyright (c) 2002, 2017, Oracle and/or its affiliates. All rights reserved.
=======
 * Copyright (c) 2002, 2024, Oracle and/or its affiliates. All rights reserved.
>>>>>>> a04ebec66b4 (8200566: DistributionPointFetcher fails to fetch CRLs if the DistributionPoints field contains more than one DistributionPoint and the first one fails)

• Resolved in favor of incoming changes.

Extra changes

test/jdk/java/security/cert/CertPathValidator/crlDP/CheckAllCRLs.java

- import jdk.test.lib.security.CertificateBuilder;
+ import sun.security.testlibrary.CertificateBuilder;

- * @library /test/lib
- * @build CheckAllCRLs
+ * @library ../../../testlibrary
+ * @build CertificateBuilder CheckAllCRLs

• These changes were made because the package structure differs from jdk17.

Tests

Tests were run on Fedora 43.

Reproducer - PASSES

Confirmed that reproducer was failing before and is passing after the backport.

CheckAllCRLs.java - PASSES

==============================
Test summary
==============================
   TEST                                              TOTAL  PASS  FAIL ERROR
   jtreg:test/jdk/java/security/cert/CertPathValidator/crlDP/CheckAllCRLs.java
                                                         1     1     0     0
==============================
TEST SUCCESS

sun/security - PASSES

==============================
Test summary
==============================
   TEST                                              TOTAL  PASS  FAIL ERROR
   jtreg:test/jdk/sun/security                         666   666     0     0
==============================
TEST SUCCESS

Tier 1 - PASSES

==============================
Test summary
==============================
   TEST                                              TOTAL  PASS  FAIL ERROR
   jtreg:test/hotspot/jtreg:tier1                     1497  1497     0     0
   jtreg:test/jdk:tier1                               1900  1900     0     0
   jtreg:test/langtools:tier1                         3941  3941     0     0
   jtreg:test/nashorn:tier1                              0     0     0     0
   jtreg:test/jaxp:tier1                                 0     0     0     0
==============================
TEST SUCCESS

GTest - PASSES

==============================
Test summary
==============================
   TEST                                              TOTAL  PASS  FAIL ERROR
   gtest:all/server                                    504   504     0     0
==============================
TEST SUCCESS

GHA - RUNNING

https://github.com/TheMangovnik/jdk11u-dev/actions/runs/22617967245

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• JDK-8200566 needs maintainer approval
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8200566: DistributionPointFetcher fails to fetch CRLs if the DistributionPoints field contains more than one DistributionPoint and the first one fails (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/3165/head:pull/3165
$ git checkout pull/3165

Update a local copy of the PR:
$ git checkout pull/3165
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/3165/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3165

View PR using the GUI difftool:
$ git pr show -t 3165

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/3165.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back TheMangovnik! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 00: Full (823f136d)

[bridgekeeper]

@TheMangovnik This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[TheMangovnik]

/touch

[openjdk]

@TheMangovnik The pull request is being re-evaluated and the inactivity timeout has been reset.