Skip to content

NO-ISSUE: Update module github.com/golangci/golangci-lint to v2.11.4#1338

Open
red-hat-konflux[bot] wants to merge 1 commit intomasterfrom
konflux/mintmaker/master/linter
Open

NO-ISSUE: Update module github.com/golangci/golangci-lint to v2.11.4#1338
red-hat-konflux[bot] wants to merge 1 commit intomasterfrom
konflux/mintmaker/master/linter

Conversation

@red-hat-konflux
Copy link
Copy Markdown
Contributor

@red-hat-konflux red-hat-konflux bot commented Feb 18, 2026

This PR contains the following updates:

Package Change Age Confidence
github.com/golangci/golangci-lint v2.8.0v2.11.4 age confidence

Release Notes

golangci/golangci-lint (github.com/golangci/golangci-lint)

v2.11.4

Compare Source

Released on 2026-03-22

  1. Linters bug fixes
    • govet-modernize: from 0.42.0 to 0.43.0
    • noctx: from 0.5.0 to 0.5.1
    • sqlclosecheck: from 0.5.1 to 0.6.0

v2.11.3

Compare Source

Released on 2026-03-10

  1. Linters bug fixes

v2.11.2

Compare Source

Released on 2026-03-07

  1. Fixes
    • fmt: fix error when using the fmt command with explicit paths.

v2.11.1

Compare Source

Released on 2026-03-06

Due to an error related to AUR, some artifacts of the v2.11.0 release have not been published.

This release contains the same things as v2.11.0.

v2.11.0

Compare Source

Released on 2026-03-06

  1. Linters new features or changes
    • errcheck: from 1.9.0 to 1.10.0 (exclude crypto/rand.Read by default)
    • gosec: from 2.23.0 to 2.24.6 (new rules: G113, G118, G119, G120, G121, G122, G123, G408, G707)
    • noctx: from 0.4.0 to 0.5.0 (new detection: httptest.NewRequestWithContext)
    • prealloc: from 1.0.2 to 1.1.0
    • revive: from 1.14.0 to 1.15.0 (⚠️ Breaking change: package-related checks moved from var-naming to a new rule package-naming)
  2. Linters bug fixes
    • gocognit: from 1.2.0 to 1.2.1
    • gosec: from 2.24.6 to 2.24.7
    • unqueryvet: from 1.5.3 to 1.5.4

v2.10.1

Compare Source

Released on 2026-02-17

  1. Fixes
    • buildssa panic

v2.10.0

Compare Source

Released on 2026-02-17

  1. Linters new features or changes
    • ginkgolinter: from 0.22.0 to 0.23.0
    • gosec: from 2.22.11 to 2.23.0 (new rules: G117, G602, G701, G702, G703, G704, G705, G706)
    • staticcheck: from 0.6.1 to 0.7.0
  2. Linters bug fixes
    • godoclint: from 0.11.1 to 0.11.2

v2.9.0

Compare Source

Released on 2026-02-10

  1. Enhancements
    • 🎉 go1.26 support
  2. Linters new features or changes
    • arangolint: from 0.3.1 to 0.4.0 (new rule: detect potential query injections)
    • ginkgolinter: from 0.21.2 to 0.22.0 (support for wrappers)
    • golines: from 0.14.0 to 0.15.0
    • misspell: from 0.7.0 to 0.8.0
    • revive: from v1.13.0 to v1.14.0 (new rules: epoch-naming, use-slices-sort)
    • unqueryvet: from 1.4.0 to 1.5.3 (new options: check-n1, check-sql-injection, check-tx-leaks, allow, custom-rules)
    • wsl_v5: from 5.3.0 to 5.6.0 (new rule: after-block)
  3. Linters bug fixes
    • modernize: from 0.41.0 to 0.42.0
    • prealloc: from 1.0.1 to 1.0.2
    • protogetter: from 0.3.18 to 0.3.20
  4. Misc.
    • Log information about files when configuration verification
    • Emit an error when no linters enabled
    • Do not collect VCS information when loading code

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

To execute skipped test pipelines write comment /ok-to-test.


Documentation

Find out how to configure dependency updates in MintMaker documentation or see all available configuration options in Renovate documentation.

@red-hat-konflux red-hat-konflux bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. linter labels Feb 18, 2026
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 18, 2026
@openshift-ci-robot
Copy link
Copy Markdown

@red-hat-konflux[bot]: This pull request explicitly references no jira issue.

Details

In response to this:

This PR contains the following updates:

Package Change Age Confidence
github.com/golangci/golangci-lint v2.8.0 -> v2.10.1 age confidence

Release Notes

golangci/golangci-lint (github.com/golangci/golangci-lint)

v2.10.1

Compare Source

Released on 2026-02-17

  1. Fixes
  • buildssa panic

v2.10.0

Compare Source

Released on 2026-02-17

  1. Linters new features or changes
  • ginkgolinter: from 0.22.0 to 0.23.0
  • gosec: from 2.22.11 to 2.23.0 (new rules: G117, G602, G701, G702, G703, G704, G705, G706)
  • staticcheck: from 0.6.1 to 0.7.0
  1. Linters bug fixes
  • godoclint: from 0.11.1 to 0.11.2

v2.9.0

Compare Source

Released on 2026-02-10

  1. Enhancements
  • 🎉 go1.26 support
  1. Linters new features or changes
  • arangolint: from 0.3.1 to 0.4.0 (new rule: detect potential query injections)
  • ginkgolinter: from 0.21.2 to 0.22.0 (support for wrappers)
  • golines: from 0.14.0 to 0.15.0
  • misspell: from 0.7.0 to 0.8.0
  • revive: from v1.13.0 to v1.14.0 (new rules: epoch-naming, use-slices-sort)
  • unqueryvet: from 1.4.0 to 1.5.3 (new options: check-n1, check-sql-injection, check-tx-leaks, allow, custom-rules)
  • wsl: from 5.3.0 to 5.6.0 (new rule: after-block)
  1. Linters bug fixes
  • modernize: from 0.41.0 to 0.42.0
  • prealloc: from 1.0.1 to 1.0.2
  • protogetter: from 0.3.18 to 0.3.20
  1. Misc.
  • Log information about files when configuration verification
  • Emit an error when no linters enabled
  • Do not collect VCS information when loading code

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

To execute skipped test pipelines write comment /ok-to-test.


Documentation

Find out how to configure dependency updates in MintMaker documentation or see all available configuration options in Renovate documentation.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Feb 18, 2026

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review

Walkthrough

Updated the golangci-lint installation in Dockerfile.assisted_installer_agent-build from v2.8.0 to v2.11.1. No other files or build steps were changed.

Changes

Cohort / File(s) Summary
Build Tool Version Update
Dockerfile.assisted_installer_agent-build
Bumped golangci-lint installation from v2.8.0 to v2.11.1.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes


Important

Pre-merge checks failed

Please resolve all errors before merging. Addressing warnings is optional.

❌ Failed checks (1 error, 1 warning)

Check name Status Explanation Resolution
Stable And Deterministic Test Names ❌ Error Test files use fmt.Sprintf() to dynamically construct test names with variable values, violating the requirement for stable and deterministic test names. Replace dynamic test name construction with static descriptive strings and move specific test case identifiers into the test body implementation.
Title check ⚠️ Warning The PR title claims to update golangci-lint to v2.11.4, but the summary and objectives confirm the actual update is to v2.11.1, creating a mismatch. Update the PR title to accurately reflect the actual version: 'NO-ISSUE: Update module github.com/golangci/golangci-lint to v2.11.1'
✅ Passed checks (3 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Test Structure And Quality ✅ Passed PR modifies only Dockerfile.assisted_installer_agent-build golangci-lint version; no test files changed, making test quality check inapplicable.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch konflux/mintmaker/master/linter

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 18, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 18, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 55.70%. Comparing base (d865e52) to head (67f9569).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1338   +/-   ##
=======================================
  Coverage   55.70%   55.70%           
=======================================
  Files          89       89           
  Lines        4445     4445           
=======================================
  Hits         2476     2476           
  Misses       1788     1788           
  Partials      181      181           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@red-hat-konflux red-hat-konflux bot changed the title NO-ISSUE: Update module github.com/golangci/golangci-lint to v2.10.1 NO-ISSUE: Update module github.com/golangci/golangci-lint to v2.10.1 - autoclosed Mar 2, 2026
@red-hat-konflux red-hat-konflux bot closed this Mar 2, 2026
@red-hat-konflux red-hat-konflux bot deleted the konflux/mintmaker/master/linter branch March 2, 2026 00:12
@red-hat-konflux red-hat-konflux bot changed the title NO-ISSUE: Update module github.com/golangci/golangci-lint to v2.10.1 - autoclosed NO-ISSUE: Update module github.com/golangci/golangci-lint to v2.10.1 Mar 2, 2026
@red-hat-konflux red-hat-konflux bot reopened this Mar 2, 2026
@red-hat-konflux red-hat-konflux bot force-pushed the konflux/mintmaker/master/linter branch 2 times, most recently from 8b6c441 to ce0be15 Compare March 2, 2026 04:17
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 2, 2026
@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Mar 2, 2026

New changes are detected. LGTM label has been removed.

@red-hat-konflux red-hat-konflux bot changed the title NO-ISSUE: Update module github.com/golangci/golangci-lint to v2.10.1 NO-ISSUE: Update module github.com/golangci/golangci-lint to v2.10.1 - autoclosed Mar 2, 2026
@red-hat-konflux red-hat-konflux bot closed this Mar 2, 2026
@red-hat-konflux red-hat-konflux bot changed the title NO-ISSUE: Update module github.com/golangci/golangci-lint to v2.10.1 - autoclosed NO-ISSUE: Update module github.com/golangci/golangci-lint to v2.10.1 Mar 2, 2026
@red-hat-konflux red-hat-konflux bot reopened this Mar 2, 2026
@red-hat-konflux red-hat-konflux bot force-pushed the konflux/mintmaker/master/linter branch 3 times, most recently from 94fb101 to cd0dfdb Compare March 6, 2026 16:08
@red-hat-konflux red-hat-konflux bot changed the title NO-ISSUE: Update module github.com/golangci/golangci-lint to v2.10.1 NO-ISSUE: Update module github.com/golangci/golangci-lint to v2.11.1 Mar 6, 2026
Copy link
Copy Markdown

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
Dockerfile.assisted_installer_agent-build (1)

5-5: Pin the installer script source instead of master to keep builds reproducible.

Line 5 executes a remote script from a mutable branch (master). That can change without notice and weakens supply-chain guarantees. Please pin the script URL to the same version tag (or a commit SHA), and keep the version in one variable.

Suggested patch
+ARG GOLANGCI_LINT_VERSION=v2.11.1
-RUN curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(go env GOPATH)/bin v2.11.1 && \
+RUN curl -sSfL "https://raw.githubusercontent.com/golangci/golangci-lint/${GOLANGCI_LINT_VERSION}/install.sh" | sh -s -- -b "$(go env GOPATH)/bin" "${GOLANGCI_LINT_VERSION}" && \
         go install golang.org/x/tools/cmd/goimports@v0.34.0 && \
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@Dockerfile.assisted_installer_agent-build` at line 5, The Dockerfile
currently downloads the golangci-lint installer from the mutable master branch;
create a single variable (e.g., GOLANGCI_LINT_VERSION) and pin the installer URL
to the corresponding release tag/commit (matching v2.11.1), then use that
variable for both the remote script path and the version argument to the
installer (replace the raw.githubusercontent.com/.../master/install.sh with the
taged path and pass -s -- -b $(go env GOPATH)/bin v${GOLANGCI_LINT_VERSION});
update the RUN that invokes curl to reference this variable so builds are
reproducible.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@Dockerfile.assisted_installer_agent-build`:
- Line 5: The Dockerfile currently downloads the golangci-lint installer from
the mutable master branch; create a single variable (e.g.,
GOLANGCI_LINT_VERSION) and pin the installer URL to the corresponding release
tag/commit (matching v2.11.1), then use that variable for both the remote script
path and the version argument to the installer (replace the
raw.githubusercontent.com/.../master/install.sh with the taged path and pass -s
-- -b $(go env GOPATH)/bin v${GOLANGCI_LINT_VERSION}); update the RUN that
invokes curl to reference this variable so builds are reproducible.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: bf45f7cf-e790-45fe-8b20-4efce19297ba

📥 Commits

Reviewing files that changed from the base of the PR and between 94fb101 and cd0dfdb.

📒 Files selected for processing (1)
  • Dockerfile.assisted_installer_agent-build

@red-hat-konflux red-hat-konflux bot changed the title NO-ISSUE: Update module github.com/golangci/golangci-lint to v2.11.1 NO-ISSUE: Update module github.com/golangci/golangci-lint to v2.11.1 - autoclosed Mar 7, 2026
@red-hat-konflux red-hat-konflux bot closed this Mar 7, 2026
@red-hat-konflux red-hat-konflux bot changed the title NO-ISSUE: Update module github.com/golangci/golangci-lint to v2.11.3 NO-ISSUE: Update module github.com/golangci/golangci-lint to v2.11.3 - autoclosed Mar 18, 2026
@red-hat-konflux red-hat-konflux bot closed this Mar 18, 2026
@red-hat-konflux red-hat-konflux bot changed the title NO-ISSUE: Update module github.com/golangci/golangci-lint to v2.11.3 - autoclosed NO-ISSUE: Update module github.com/golangci/golangci-lint to v2.11.3 Mar 18, 2026
@red-hat-konflux red-hat-konflux bot reopened this Mar 18, 2026
@red-hat-konflux red-hat-konflux bot force-pushed the konflux/mintmaker/master/linter branch 2 times, most recently from 0fd5b18 to 4c89ff1 Compare March 18, 2026 16:08
@red-hat-konflux red-hat-konflux bot changed the title NO-ISSUE: Update module github.com/golangci/golangci-lint to v2.11.3 NO-ISSUE: Update module github.com/golangci/golangci-lint to v2.11.3 - autoclosed Mar 19, 2026
@red-hat-konflux red-hat-konflux bot closed this Mar 19, 2026
@red-hat-konflux red-hat-konflux bot changed the title NO-ISSUE: Update module github.com/golangci/golangci-lint to v2.11.3 - autoclosed NO-ISSUE: Update module github.com/golangci/golangci-lint to v2.11.3 Mar 19, 2026
@red-hat-konflux red-hat-konflux bot reopened this Mar 19, 2026
@red-hat-konflux red-hat-konflux bot force-pushed the konflux/mintmaker/master/linter branch 2 times, most recently from 4c89ff1 to a6fe656 Compare March 19, 2026 20:20
@red-hat-konflux red-hat-konflux bot changed the title NO-ISSUE: Update module github.com/golangci/golangci-lint to v2.11.3 NO-ISSUE: Update module github.com/golangci/golangci-lint to v2.11.3 - autoclosed Mar 21, 2026
@red-hat-konflux red-hat-konflux bot closed this Mar 21, 2026
@red-hat-konflux red-hat-konflux bot changed the title NO-ISSUE: Update module github.com/golangci/golangci-lint to v2.11.3 - autoclosed NO-ISSUE: Update module github.com/golangci/golangci-lint to v2.11.3 Mar 21, 2026
@red-hat-konflux red-hat-konflux bot reopened this Mar 21, 2026
@red-hat-konflux red-hat-konflux bot force-pushed the konflux/mintmaker/master/linter branch 2 times, most recently from a6fe656 to 2a14c57 Compare March 21, 2026 16:17
@red-hat-konflux red-hat-konflux bot changed the title NO-ISSUE: Update module github.com/golangci/golangci-lint to v2.11.3 NO-ISSUE: Update module github.com/golangci/golangci-lint to v2.11.3 - autoclosed Mar 22, 2026
@red-hat-konflux red-hat-konflux bot closed this Mar 22, 2026
@red-hat-konflux red-hat-konflux bot changed the title NO-ISSUE: Update module github.com/golangci/golangci-lint to v2.11.3 - autoclosed NO-ISSUE: Update module github.com/golangci/golangci-lint to v2.11.3 Mar 22, 2026
@red-hat-konflux red-hat-konflux bot reopened this Mar 22, 2026
@red-hat-konflux red-hat-konflux bot force-pushed the konflux/mintmaker/master/linter branch 3 times, most recently from 3dc4b63 to f6bb8d9 Compare March 22, 2026 20:17
@red-hat-konflux red-hat-konflux bot changed the title NO-ISSUE: Update module github.com/golangci/golangci-lint to v2.11.3 NO-ISSUE: Update module github.com/golangci/golangci-lint to v2.11.4 Mar 22, 2026
@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Apr 12, 2026

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: red-hat-konflux[bot]

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Apr 12, 2026

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: red-hat-konflux[bot]

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com>
@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Apr 16, 2026

@red-hat-konflux[bot]: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/edge-lint 67f9569 link true /test edge-lint

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. linter size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant