NO-ISSUE: Update module github.com/golangci/golangci-lint to v2.11.4#1338
NO-ISSUE: Update module github.com/golangci/golangci-lint to v2.11.4#1338red-hat-konflux[bot] wants to merge 1 commit intomasterfrom
Conversation
|
@red-hat-konflux[bot]: This pull request explicitly references no jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
WalkthroughUpdated the golangci-lint installation in Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 error, 1 warning)
✅ Passed checks (3 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1338 +/- ##
=======================================
Coverage 55.70% 55.70%
=======================================
Files 89 89
Lines 4445 4445
=======================================
Hits 2476 2476
Misses 1788 1788
Partials 181 181 🚀 New features to boost your workflow:
|
8b6c441 to
ce0be15
Compare
|
New changes are detected. LGTM label has been removed. |
94fb101 to
cd0dfdb
Compare
There was a problem hiding this comment.
🧹 Nitpick comments (1)
Dockerfile.assisted_installer_agent-build (1)
5-5: Pin the installer script source instead ofmasterto keep builds reproducible.Line 5 executes a remote script from a mutable branch (
master). That can change without notice and weakens supply-chain guarantees. Please pin the script URL to the same version tag (or a commit SHA), and keep the version in one variable.Suggested patch
+ARG GOLANGCI_LINT_VERSION=v2.11.1 -RUN curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(go env GOPATH)/bin v2.11.1 && \ +RUN curl -sSfL "https://raw.githubusercontent.com/golangci/golangci-lint/${GOLANGCI_LINT_VERSION}/install.sh" | sh -s -- -b "$(go env GOPATH)/bin" "${GOLANGCI_LINT_VERSION}" && \ go install golang.org/x/tools/cmd/goimports@v0.34.0 && \🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@Dockerfile.assisted_installer_agent-build` at line 5, The Dockerfile currently downloads the golangci-lint installer from the mutable master branch; create a single variable (e.g., GOLANGCI_LINT_VERSION) and pin the installer URL to the corresponding release tag/commit (matching v2.11.1), then use that variable for both the remote script path and the version argument to the installer (replace the raw.githubusercontent.com/.../master/install.sh with the taged path and pass -s -- -b $(go env GOPATH)/bin v${GOLANGCI_LINT_VERSION}); update the RUN that invokes curl to reference this variable so builds are reproducible.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@Dockerfile.assisted_installer_agent-build`:
- Line 5: The Dockerfile currently downloads the golangci-lint installer from
the mutable master branch; create a single variable (e.g.,
GOLANGCI_LINT_VERSION) and pin the installer URL to the corresponding release
tag/commit (matching v2.11.1), then use that variable for both the remote script
path and the version argument to the installer (replace the
raw.githubusercontent.com/.../master/install.sh with the taged path and pass -s
-- -b $(go env GOPATH)/bin v${GOLANGCI_LINT_VERSION}); update the RUN that
invokes curl to reference this variable so builds are reproducible.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: bf45f7cf-e790-45fe-8b20-4efce19297ba
📒 Files selected for processing (1)
Dockerfile.assisted_installer_agent-build
0fd5b18 to
4c89ff1
Compare
4c89ff1 to
a6fe656
Compare
a6fe656 to
2a14c57
Compare
3dc4b63 to
f6bb8d9
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: red-hat-konflux[bot] The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
1 similar comment
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: red-hat-konflux[bot] The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com>
|
@red-hat-konflux[bot]: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This PR contains the following updates:
v2.8.0→v2.11.4Release Notes
golangci/golangci-lint (github.com/golangci/golangci-lint)
v2.11.4Compare Source
Released on 2026-03-22
govet-modernize: from 0.42.0 to 0.43.0noctx: from 0.5.0 to 0.5.1sqlclosecheck: from 0.5.1 to 0.6.0v2.11.3Compare Source
Released on 2026-03-10
gosec: from v2.24.7 to619ce21v2.11.2Compare Source
Released on 2026-03-07
fmt: fix error when using thefmtcommand with explicit paths.v2.11.1Compare Source
Released on 2026-03-06
Due to an error related to AUR, some artifacts of the v2.11.0 release have not been published.
This release contains the same things as v2.11.0.
v2.11.0Compare Source
Released on 2026-03-06
errcheck: from 1.9.0 to 1.10.0 (excludecrypto/rand.Readby default)gosec: from 2.23.0 to 2.24.6 (new rules:G113,G118,G119,G120,G121,G122,G123,G408,G707)noctx: from 0.4.0 to 0.5.0 (new detection:httptest.NewRequestWithContext)prealloc: from 1.0.2 to 1.1.0revive: from 1.14.0 to 1.15.0 (var-namingto a new rulepackage-naming)gocognit: from 1.2.0 to 1.2.1gosec: from 2.24.6 to 2.24.7unqueryvet: from 1.5.3 to 1.5.4v2.10.1Compare Source
Released on 2026-02-17
v2.10.0Compare Source
Released on 2026-02-17
ginkgolinter: from 0.22.0 to 0.23.0gosec: from 2.22.11 to 2.23.0 (new rules:G117,G602,G701,G702,G703,G704,G705,G706)staticcheck: from 0.6.1 to 0.7.0godoclint: from 0.11.1 to 0.11.2v2.9.0Compare Source
Released on 2026-02-10
arangolint: from 0.3.1 to 0.4.0 (new rule: detect potential query injections)ginkgolinter: from 0.21.2 to 0.22.0 (support for wrappers)golines: from 0.14.0 to 0.15.0misspell: from 0.7.0 to 0.8.0revive: from v1.13.0 to v1.14.0 (new rules:epoch-naming,use-slices-sort)unqueryvet: from 1.4.0 to 1.5.3 (new options:check-n1,check-sql-injection,check-tx-leaks,allow,custom-rules)wsl_v5: from 5.3.0 to 5.6.0 (new rule:after-block)modernize: from 0.41.0 to 0.42.0prealloc: from 1.0.1 to 1.0.2protogetter: from 0.3.18 to 0.3.20Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
To execute skipped test pipelines write comment
/ok-to-test.Documentation
Find out how to configure dependency updates in MintMaker documentation or see all available configuration options in Renovate documentation.