CNTRLPLANE-2610: Create network policies for AUTH components#825
CNTRLPLANE-2610: Create network policies for AUTH components#825liouk wants to merge 4 commits intoopenshift:masterfrom
Conversation
|
@liouk: This pull request references CNTRLPLANE-2610 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
WalkthroughThis pull request introduces Kubernetes NetworkPolicy resources for the OAuth API server, OAuth server, and authentication operator components across multiple namespaces. It defines ingress and egress traffic rules to restrict communication between services and includes code changes to register these policies in the static resource provisioning system. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~15 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
/jira refresh |
|
@liouk: This pull request references CNTRLPLANE-2610 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
9711c7b to
d058feb
Compare
|
@liouk: This pull request references CNTRLPLANE-2610 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
d058feb to
97ba0b8
Compare
|
@liouk: This pull request references CNTRLPLANE-2610 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@coderabbitai help |
ChatThere are 3 ways to chat with CodeRabbit:
CodeRabbit commands
Other keywords and placeholders
CodeRabbit configuration file (
|
|
/retest |
|
I'd like a review from a member of each of the auth and network policy feature teams -- holding until we get both. Holding PR until we get:
/hold |
|
@liouk: This pull request references CNTRLPLANE-2610 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
| libraryoutputresources.ExactResource("networking.k8s.io", "v1", "networkpolicies", "openshift-authentication-operator", "authentication-operator-networkpolicy"), | ||
| libraryoutputresources.ExactResource("networking.k8s.io", "v1", "networkpolicies", "openshift-authentication-operator", "default-deny-all"), |
There was a problem hiding this comment.
Does MOM need to also know the manifests for deploying the cluster-authentication-operator itself?
There was a problem hiding this comment.
Actually good point, I don't believe OM needs these operator manifests.
97ba0b8 to
2321ed0
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@bindata/oauth-openshift/networkpolicy_oauth-server.yaml`:
- Around line 44-68: The NetworkPolicy in networkpolicy_oauth-server.yaml
currently uses a wide namespaceSelector: {} allowing ingress to port 6443 from
any namespace and an egress rule with only ports: - protocol: TCP (no `to`)
permitting all TCP egress; tighten or document this: replace namespaceSelector:
{} with a scoped namespaceSelector/podSelector or ipBlock that targets known
oauth-proxy/sidecar namespaces or pods (reference the ingress block targeting
port 6443), and restrict the egress rule (the egress entry listing ports with
protocol: TCP) by adding specific `to:` destinations (podSelector,
namespaceSelector or ipBlock) for kube-apiserver and configured IDPs;
alternatively, if the broad scope is intentional, add an explicit comment in the
manifest near the ingress (port 6443) and the TCP-only egress rule explaining
the rationale and approved clients/endpoints.
🧹 Nitpick comments (1)
bindata/oauth-apiserver/networkpolicy_oauth-apiserver.yaml (1)
77-80: Egress rule allows all TCP ports to any destination.This rule permits unrestricted TCP egress, which is quite permissive. The comment indicates this is for kube-apiserver communication, but kube-apiserver typically runs on port 6443. Consider whether this could be tightened to specific ports (e.g., 6443 for API server) to reduce attack surface, or document why unrestricted TCP is required.
everettraven
left a comment
There was a problem hiding this comment.
This LGTM in general.
We should probably run payload jobs for a sanity check that this won't cause component readiness issues and payload build failures.
/lgtm
|
Pushed changes to better align with the "Egress to the APIServer" guidance. |
| annotations: | ||
| include.release.openshift.io/self-managed-high-availability: "true" | ||
| include.release.openshift.io/single-node-developer: "true" | ||
| include.release.openshift.io/ibm-cloud-managed: "true" |
There was a problem hiding this comment.
Cesar warned against having these applied in hypershift since they already do their own network policies in the hosted control planes. I would suggest removing this include.release.openshift.io/ibm-cloud-managed: "true".
| annotations: | ||
| include.release.openshift.io/self-managed-high-availability: "true" | ||
| include.release.openshift.io/single-node-developer: "true" | ||
| include.release.openshift.io/ibm-cloud-managed: "true" |
37dd6ce to
af9a504
Compare
af9a504 to
e9f60f8
Compare
|
Pushed fixes as per comments from @dusk125 and also more alignment with guidance (allow all ingress to metrics, not just prometheus pods). |
|
/retest |
1 similar comment
|
/retest |
|
@liouk: This pull request references CNTRLPLANE-2610 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@liouk: This pull request references CNTRLPLANE-2610 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In
`@test-data/apply-configuration/overall/minimal-cluster/expected-output/Management/Create/namespaces/openshift-oauth-apiserver/networking.k8s.io/networkpolicies/fcd4-body-oauth-apiserver-networkpolicy.yaml`:
- Line 30: The NetworkPolicy named in the patch
(fcd4-body-oauth-apiserver-networkpolicy) currently uses "egress: - {}" which
permits all outbound traffic; replace that open egress rule with a constrained
egress entry that limits traffic to TCP only (e.g., specify protocol: TCP and an
appropriate ports list or port range) while preserving the hostNetwork exception
logic so the deny-by-default posture is maintained for the targeted pods.
In
`@test-data/apply-configuration/overall/oauth-server-staticresource/expected-output/Management/Create/namespaces/openshift-authentication/networking.k8s.io/networkpolicies/9eb2-body-oauth-server-networkpolicy.yaml`:
- Line 30: The network policy contains an empty egress rule ("egress: - {}")
that effectively allows all outbound traffic and defeats the intended
restrictive posture with "policyTypes: [Egress]"; remove the empty egress entry
from the NetworkPolicy (or replace it with explicit, scoped egress rules) so
only the intended DNS and OAuth API server egress rules remain; if an exception
is required (e.g., hostNetwork pods), implement a narrowly scoped egress rule
instead of using the empty rule.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 6e565ba7-1936-4f6a-b7a4-398a3f0992a1
📒 Files selected for processing (189)
test-data/apply-configuration/overall/minimal-cluster/expected-output/Management/Create/cluster-scoped-resources/config.openshift.io/clusteroperators/913e-body-authentication.yamltest-data/apply-configuration/overall/minimal-cluster/expected-output/Management/Create/cluster-scoped-resources/config.openshift.io/clusteroperators/913e-metadata-authentication.yamltest-data/apply-configuration/overall/minimal-cluster/expected-output/Management/Create/cluster-scoped-resources/core/namespaces/7360-body-openshift-oauth-apiserver.yamltest-data/apply-configuration/overall/minimal-cluster/expected-output/Management/Create/cluster-scoped-resources/core/namespaces/7360-metadata-openshift-oauth-apiserver.yamltest-data/apply-configuration/overall/minimal-cluster/expected-output/Management/Create/cluster-scoped-resources/core/namespaces/8528-body-openshift-authentication.yamltest-data/apply-configuration/overall/minimal-cluster/expected-output/Management/Create/cluster-scoped-resources/core/namespaces/8528-metadata-openshift-authentication.yamltest-data/apply-configuration/overall/minimal-cluster/expected-output/Management/Create/namespaces/openshift-authentication-operator/core/events/0bf3-body-authentication-operator.17fe72c59b829800.c1403ea8.yamltest-data/apply-configuration/overall/minimal-cluster/expected-output/Management/Create/namespaces/openshift-authentication-operator/core/events/0bf3-metadata-authentication-operator.17fe72c59b829800.c1403ea8.yamltest-data/apply-configuration/overall/minimal-cluster/expected-output/Management/Create/namespaces/openshift-authentication-operator/core/events/115f-body-authentication-operator.17fe72c59b829800.e6f3afa2.yamltest-data/apply-configuration/overall/minimal-cluster/expected-output/Management/Create/namespaces/openshift-authentication-operator/core/events/115f-metadata-authentication-operator.17fe72c59b829800.e6f3afa2.yamltest-data/apply-configuration/overall/minimal-cluster/expected-output/Management/Create/namespaces/openshift-authentication-operator/core/events/1225-body-authentication-operator.17fe72c59b829800.87c2a194.yamltest-data/apply-configuration/overall/minimal-cluster/expected-output/Management/Create/namespaces/openshift-authentication-operator/core/events/1225-metadata-authentication-operator.17fe72c59b829800.87c2a194.yamltest-data/apply-configuration/overall/minimal-cluster/expected-output/Management/Create/namespaces/openshift-authentication-operator/core/events/21ea-body-authentication-operator.17fe72c59b829800.103eb7f4.yamltest-data/apply-configuration/overall/minimal-cluster/expected-output/Management/Create/namespaces/openshift-authentication-operator/core/events/21ea-metadata-authentication-operator.17fe72c59b829800.103eb7f4.yamltest-data/apply-configuration/overall/minimal-cluster/expected-output/Management/Create/namespaces/openshift-authentication-operator/core/events/2bcd-body-authentication-operator.17fe72c59b829800.a18021d9.yamltest-data/apply-configuration/overall/minimal-cluster/expected-output/Management/Create/namespaces/openshift-authentication-operator/core/events/2bcd-metadata-authentication-operator.17fe72c59b829800.a18021d9.yamltest-data/apply-configuration/overall/minimal-cluster/expected-output/Management/Create/namespaces/openshift-authentication-operator/core/events/3f86-body-authentication-operator.17fe72c59b829800.05fbd8b8.yamltest-data/apply-configuration/overall/minimal-cluster/expected-output/Management/Create/namespaces/openshift-authentication-operator/core/events/3f86-metadata-authentication-operator.17fe72c59b829800.05fbd8b8.yamltest-data/apply-configuration/overall/minimal-cluster/expected-output/Management/Create/namespaces/openshift-authentication-operator/core/events/41f0-body-authentication-operator.17fe72c59b829800.adf05e91.yamltest-data/apply-configuration/overall/minimal-cluster/expected-output/Management/Create/namespaces/openshift-authentication-operator/core/events/41f0-metadata-authentication-operator.17fe72c59b829800.adf05e91.yamltest-data/apply-configuration/overall/minimal-cluster/expected-output/Management/Create/namespaces/openshift-authentication-operator/core/events/4287-body-authentication-operator.17fe72c59b829800.07abf400.yamltest-data/apply-configuration/overall/minimal-cluster/expected-output/Management/Create/namespaces/openshift-authentication-operator/core/events/4287-metadata-authentication-operator.17fe72c59b829800.07abf400.yamltest-data/apply-configuration/overall/minimal-cluster/expected-output/Management/Create/namespaces/openshift-authentication-operator/core/events/5196-body-authentication-operator.17fe72c59b829800.327a2f38.yamltest-data/apply-configuration/overall/minimal-cluster/expected-output/Management/Create/namespaces/openshift-authentication-operator/core/events/5196-metadata-authentication-operator.17fe72c59b829800.327a2f38.yamltest-data/apply-configuration/overall/minimal-cluster/expected-output/Management/Create/namespaces/openshift-authentication-operator/core/events/5203-body-authentication-operator.17fe72c59b829800.6c145ec7.yamltest-data/apply-configuration/overall/minimal-cluster/expected-output/Management/Create/namespaces/openshift-authentication-operator/core/events/5203-metadata-authentication-operator.17fe72c59b829800.6c145ec7.yamltest-data/apply-configuration/overall/minimal-cluster/expected-output/Management/Create/namespaces/openshift-authentication-operator/core/events/53aa-body-authentication-operator.17fe72c59b829800.ec96ffd6.yamltest-data/apply-configuration/overall/minimal-cluster/expected-output/Management/Create/namespaces/openshift-authentication-operator/core/events/53aa-metadata-authentication-operator.17fe72c59b829800.ec96ffd6.yamltest-data/apply-configuration/overall/minimal-cluster/expected-output/Management/Create/namespaces/openshift-authentication-operator/core/events/5b77-body-authentication-operator.17fe72c59b829800.49fb0e36.yamltest-data/apply-configuration/overall/minimal-cluster/expected-output/Management/Create/namespaces/openshift-authentication-operator/core/events/5b77-metadata-authentication-operator.17fe72c59b829800.49fb0e36.yamltest-data/apply-configuration/overall/minimal-cluster/expected-output/Management/Create/namespaces/openshift-authentication-operator/core/events/5db5-body-authentication-operator.17fe72c59b829800.c1353886.yamltest-data/apply-configuration/overall/minimal-cluster/expected-output/Management/Create/namespaces/openshift-authentication-operator/core/events/5db5-metadata-authentication-operator.17fe72c59b829800.c1353886.yamltest-data/apply-configuration/overall/minimal-cluster/expected-output/Management/Create/namespaces/openshift-authentication-operator/core/events/6393-body-authentication-operator.17fe72c59b829800.c879600c.yamltest-data/apply-configuration/overall/minimal-cluster/expected-output/Management/Create/namespaces/openshift-authentication-operator/core/events/6393-metadata-authentication-operator.17fe72c59b829800.c879600c.yamltest-data/apply-configuration/overall/minimal-cluster/expected-output/Management/Create/namespaces/openshift-authentication-operator/core/events/6471-body-authentication-operator.17fe72c59b829800.57eb8535.yamltest-data/apply-configuration/overall/minimal-cluster/expected-output/Management/Create/namespaces/openshift-authentication-operator/core/events/66df-body-authentication-operator.17fe72c59b829800.c605caf3.yamltest-data/apply-configuration/overall/minimal-cluster/expected-output/Management/Create/namespaces/openshift-authentication-operator/core/events/66df-metadata-authentication-operator.17fe72c59b829800.c605caf3.yamltest-data/apply-configuration/overall/minimal-cluster/expected-output/Management/Create/namespaces/openshift-authentication-operator/core/events/75eb-body-authentication-operator.17fe72c59b829800.b8ffb9fd.yamltest-data/apply-configuration/overall/minimal-cluster/expected-output/Management/Create/namespaces/openshift-authentication-operator/core/events/75eb-metadata-authentication-operator.17fe72c59b829800.b8ffb9fd.yamltest-data/apply-configuration/overall/minimal-cluster/expected-output/Management/Create/namespaces/openshift-authentication-operator/core/events/78e6-body-authentication-operator.17fe72c59b829800.9dfc3b5d.yamltest-data/apply-configuration/overall/minimal-cluster/expected-output/Management/Create/namespaces/openshift-authentication-operator/core/events/78e6-metadata-authentication-operator.17fe72c59b829800.9dfc3b5d.yamltest-data/apply-configuration/overall/minimal-cluster/expected-output/Management/Create/namespaces/openshift-authentication-operator/core/events/8379-body-authentication-operator.17fe72c59b829800.da44325f.yamltest-data/apply-configuration/overall/minimal-cluster/expected-output/Management/Create/namespaces/openshift-authentication-operator/core/events/8379-metadata-authentication-operator.17fe72c59b829800.da44325f.yamltest-data/apply-configuration/overall/minimal-cluster/expected-output/Management/Create/namespaces/openshift-authentication-operator/core/events/8daf-body-authentication-operator.17fe72c59b829800.a8ecfbce.yamltest-data/apply-configuration/overall/minimal-cluster/expected-output/Management/Create/namespaces/openshift-authentication-operator/core/events/8daf-metadata-authentication-operator.17fe72c59b829800.a8ecfbce.yamltest-data/apply-configuration/overall/minimal-cluster/expected-output/Management/Create/namespaces/openshift-authentication-operator/core/events/953f-body-authentication-operator.17fe72c59b829800.fd7c2a06.yamltest-data/apply-configuration/overall/minimal-cluster/expected-output/Management/Create/namespaces/openshift-authentication-operator/core/events/953f-metadata-authentication-operator.17fe72c59b829800.fd7c2a06.yamltest-data/apply-configuration/overall/minimal-cluster/expected-output/Management/Create/namespaces/openshift-authentication-operator/core/events/9a63-body-authentication-operator.17fe72c59b829800.f737230b.yamltest-data/apply-configuration/overall/minimal-cluster/expected-output/Management/Create/namespaces/openshift-authentication-operator/core/events/9a63-metadata-authentication-operator.17fe72c59b829800.f737230b.yamltest-data/apply-configuration/overall/minimal-cluster/expected-output/Management/Create/namespaces/openshift-authentication-operator/core/events/9bec-body-authentication-operator.17fe72c59b829800.9b8e044a.yamltest-data/apply-configuration/overall/minimal-cluster/expected-output/Management/Create/namespaces/openshift-authentication-operator/core/events/9bec-metadata-authentication-operator.17fe72c59b829800.9b8e044a.yamltest-data/apply-configuration/overall/minimal-cluster/expected-output/Management/Create/namespaces/openshift-authentication-operator/core/events/a2b3-body-authentication-operator.17fe72c59b829800.7cfd43de.yamltest-data/apply-configuration/overall/minimal-cluster/expected-output/Management/Create/namespaces/openshift-authentication-operator/core/events/a2b3-metadata-authentication-operator.17fe72c59b829800.7cfd43de.yamltest-data/apply-configuration/overall/minimal-cluster/expected-output/Management/Create/namespaces/openshift-authentication-operator/core/events/ab40-body-authentication-operator.17fe72c59b829800.44a05c38.yamltest-data/apply-configuration/overall/minimal-cluster/expected-output/Management/Create/namespaces/openshift-authentication-operator/core/events/ab40-metadata-authentication-operator.17fe72c59b829800.44a05c38.yamltest-data/apply-configuration/overall/minimal-cluster/expected-output/Management/Create/namespaces/openshift-authentication-operator/core/events/abe3-body-authentication-operator.17fe72c59b829800.cc404894.yamltest-data/apply-configuration/overall/minimal-cluster/expected-output/Management/Create/namespaces/openshift-authentication-operator/core/events/abe3-metadata-authentication-operator.17fe72c59b829800.cc404894.yamltest-data/apply-configuration/overall/minimal-cluster/expected-output/Management/Create/namespaces/openshift-authentication-operator/core/events/ad2e-body-authentication-operator.17fe72c59b829800.651f7f3f.yamltest-data/apply-configuration/overall/minimal-cluster/expected-output/Management/Create/namespaces/openshift-authentication-operator/core/events/ad2e-metadata-authentication-operator.17fe72c59b829800.651f7f3f.yamltest-data/apply-configuration/overall/minimal-cluster/expected-output/Management/Create/namespaces/openshift-authentication-operator/core/events/b8a3-body-authentication-operator.17fe72c59b829800.8953695d.yamltest-data/apply-configuration/overall/minimal-cluster/expected-output/Management/Create/namespaces/openshift-authentication-operator/core/events/b8a3-metadata-authentication-operator.17fe72c59b829800.8953695d.yamltest-data/apply-configuration/overall/minimal-cluster/expected-output/Management/Create/namespaces/openshift-authentication-operator/core/events/bffe-body-authentication-operator.17fe72c59b829800.df0f8e47.yamltest-data/apply-configuration/overall/minimal-cluster/expected-output/Management/Create/namespaces/openshift-authentication-operator/core/events/bffe-metadata-authentication-operator.17fe72c59b829800.df0f8e47.yamltest-data/apply-configuration/overall/minimal-cluster/expected-output/Management/Create/namespaces/openshift-authentication-operator/core/events/ccdf-body-authentication-operator.17fe72c59b829800.616f1c0f.yamltest-data/apply-configuration/overall/minimal-cluster/expected-output/Management/Create/namespaces/openshift-authentication-operator/core/events/ccdf-metadata-authentication-operator.17fe72c59b829800.616f1c0f.yamltest-data/apply-configuration/overall/minimal-cluster/expected-output/Management/Create/namespaces/openshift-authentication-operator/core/events/cedd-body-authentication-operator.17fe72c59b829800.96072a72.yamltest-data/apply-configuration/overall/minimal-cluster/expected-output/Management/Create/namespaces/openshift-authentication-operator/core/events/cedd-metadata-authentication-operator.17fe72c59b829800.96072a72.yamltest-data/apply-configuration/overall/minimal-cluster/expected-output/Management/Create/namespaces/openshift-authentication-operator/core/events/de10-body-authentication-operator.17fe72c59b829800.2a24f1b5.yamltest-data/apply-configuration/overall/minimal-cluster/expected-output/Management/Create/namespaces/openshift-authentication-operator/core/events/e212-body-authentication-operator.17fe72c59b829800.52f3c122.yamltest-data/apply-configuration/overall/minimal-cluster/expected-output/Management/Create/namespaces/openshift-authentication-operator/core/events/e212-metadata-authentication-operator.17fe72c59b829800.52f3c122.yamltest-data/apply-configuration/overall/minimal-cluster/expected-output/Management/Create/namespaces/openshift-authentication-operator/core/events/e2d5-body-authentication-operator.17fe72c59b829800.ce8a3f4a.yamltest-data/apply-configuration/overall/minimal-cluster/expected-output/Management/Create/namespaces/openshift-authentication-operator/core/events/e2d5-metadata-authentication-operator.17fe72c59b829800.ce8a3f4a.yamltest-data/apply-configuration/overall/minimal-cluster/expected-output/Management/Create/namespaces/openshift-authentication-operator/core/events/fb69-body-authentication-operator.17fe72c59b829800.2a6d0210.yamltest-data/apply-configuration/overall/minimal-cluster/expected-output/Management/Create/namespaces/openshift-authentication-operator/core/events/fb69-metadata-authentication-operator.17fe72c59b829800.2a6d0210.yamltest-data/apply-configuration/overall/minimal-cluster/expected-output/Management/Create/namespaces/openshift-authentication/core/configmaps/5f92-body-audit.yamltest-data/apply-configuration/overall/minimal-cluster/expected-output/Management/Create/namespaces/openshift-authentication/core/configmaps/5f92-metadata-audit.yamltest-data/apply-configuration/overall/minimal-cluster/expected-output/Management/Create/namespaces/openshift-authentication/core/configmaps/a742-body-v4-0-config-system-trusted-ca-bundle.yamltest-data/apply-configuration/overall/minimal-cluster/expected-output/Management/Create/namespaces/openshift-authentication/core/configmaps/a742-metadata-v4-0-config-system-trusted-ca-bundle.yamltest-data/apply-configuration/overall/minimal-cluster/expected-output/Management/Create/namespaces/openshift-authentication/core/secrets/4034-body-v4-0-config-system-ocp-branding-template.yamltest-data/apply-configuration/overall/minimal-cluster/expected-output/Management/Create/namespaces/openshift-authentication/core/secrets/4034-metadata-v4-0-config-system-ocp-branding-template.yamltest-data/apply-configuration/overall/minimal-cluster/expected-output/Management/Create/namespaces/openshift-authentication/core/serviceaccounts/a3dc-body-oauth-openshift.yamltest-data/apply-configuration/overall/minimal-cluster/expected-output/Management/Create/namespaces/openshift-authentication/core/serviceaccounts/a3dc-metadata-oauth-openshift.yamltest-data/apply-configuration/overall/minimal-cluster/expected-output/Management/Create/namespaces/openshift-authentication/core/services/31c0-body-oauth-openshift.yamltest-data/apply-configuration/overall/minimal-cluster/expected-output/Management/Create/namespaces/openshift-authentication/core/services/31c0-metadata-oauth-openshift.yamltest-data/apply-configuration/overall/minimal-cluster/expected-output/Management/Create/namespaces/openshift-authentication/networking.k8s.io/networkpolicies/4519-body-default-deny-all.yamltest-data/apply-configuration/overall/minimal-cluster/expected-output/Management/Create/namespaces/openshift-authentication/networking.k8s.io/networkpolicies/4519-metadata-default-deny-all.yamltest-data/apply-configuration/overall/minimal-cluster/expected-output/Management/Create/namespaces/openshift-authentication/networking.k8s.io/networkpolicies/9eb2-body-oauth-server-networkpolicy.yamltest-data/apply-configuration/overall/minimal-cluster/expected-output/Management/Create/namespaces/openshift-authentication/networking.k8s.io/networkpolicies/9eb2-metadata-oauth-server-networkpolicy.yamltest-data/apply-configuration/overall/minimal-cluster/expected-output/Management/Create/namespaces/openshift-config-managed/rbac.authorization.k8s.io/rolebindings/735c-body-system-COLON-openshift-COLON-oauth-servercert-trust.yamltest-data/apply-configuration/overall/minimal-cluster/expected-output/Management/Create/namespaces/openshift-config-managed/rbac.authorization.k8s.io/rolebindings/735c-metadata-system-COLON-openshift-COLON-oauth-servercert-trust.yamltest-data/apply-configuration/overall/minimal-cluster/expected-output/Management/Create/namespaces/openshift-config-managed/rbac.authorization.k8s.io/roles/a92b-body-system-COLON-openshift-COLON-oauth-servercert-trust.yamltest-data/apply-configuration/overall/minimal-cluster/expected-output/Management/Create/namespaces/openshift-config-managed/rbac.authorization.k8s.io/roles/a92b-metadata-system-COLON-openshift-COLON-oauth-servercert-trust.yamltest-data/apply-configuration/overall/minimal-cluster/expected-output/Management/Create/namespaces/openshift-oauth-apiserver/networking.k8s.io/networkpolicies/312e-body-default-deny-all.yamltest-data/apply-configuration/overall/minimal-cluster/expected-output/Management/Create/namespaces/openshift-oauth-apiserver/networking.k8s.io/networkpolicies/312e-metadata-default-deny-all.yamltest-data/apply-configuration/overall/minimal-cluster/expected-output/Management/Create/namespaces/openshift-oauth-apiserver/networking.k8s.io/networkpolicies/fcd4-body-oauth-apiserver-networkpolicy.yamltest-data/apply-configuration/overall/minimal-cluster/expected-output/Management/Create/namespaces/openshift-oauth-apiserver/networking.k8s.io/networkpolicies/fcd4-metadata-oauth-apiserver-networkpolicy.yamltest-data/apply-configuration/overall/minimal-cluster/expected-output/Management/Create/namespaces/openshift-oauth-apiserver/policy/poddisruptionbudgets/9c75-body-oauth-apiserver-pdb.yamltest-data/apply-configuration/overall/minimal-cluster/expected-output/Management/Create/namespaces/openshift-oauth-apiserver/policy/poddisruptionbudgets/9c75-metadata-oauth-apiserver-pdb.yamltest-data/apply-configuration/overall/minimal-cluster/expected-output/Management/UpdateStatus/cluster-scoped-resources/config.openshift.io/clusteroperators/7130-body-authentication.yamltest-data/apply-configuration/overall/minimal-cluster/expected-output/Management/UpdateStatus/cluster-scoped-resources/config.openshift.io/clusteroperators/7130-metadata-authentication.yamltest-data/apply-configuration/overall/minimal-cluster/expected-output/UserWorkload/Create/cluster-scoped-resources/apiextensions.k8s.io/customresourcedefinitions/c340-body-rolebindingrestrictions.authorization.openshift.io.yamltest-data/apply-configuration/overall/minimal-cluster/expected-output/UserWorkload/Create/cluster-scoped-resources/apiextensions.k8s.io/customresourcedefinitions/c340-metadata-rolebindingrestrictions.authorization.openshift.io.yamltest-data/apply-configuration/overall/minimal-cluster/expected-output/UserWorkload/Create/cluster-scoped-resources/certificates.k8s.io/certificatesigningrequests/a204-body-system-COLON-openshift-COLON-openshift-authenticator-.yamltest-data/apply-configuration/overall/minimal-cluster/expected-output/UserWorkload/Create/cluster-scoped-resources/certificates.k8s.io/certificatesigningrequests/a204-metadata-system-COLON-openshift-COLON-openshift-authenticator-.yamltest-data/apply-configuration/overall/minimal-cluster/expected-output/UserWorkload/Create/cluster-scoped-resources/rbac.authorization.k8s.io/clusterrolebindings/4b1b-body-system-COLON-openshift-COLON-openshift-authentication.yamltest-data/apply-configuration/overall/minimal-cluster/expected-output/UserWorkload/Create/cluster-scoped-resources/rbac.authorization.k8s.io/clusterrolebindings/4b1b-metadata-system-COLON-openshift-COLON-openshift-authentication.yamltest-data/apply-configuration/overall/minimal-cluster/expected-output/UserWorkload/Create/cluster-scoped-resources/rbac.authorization.k8s.io/clusterrolebindings/af44-body-system-COLON-openshift-COLON-oauth-apiserver.yamltest-data/apply-configuration/overall/minimal-cluster/expected-output/UserWorkload/Create/cluster-scoped-resources/rbac.authorization.k8s.io/clusterrolebindings/af44-metadata-system-COLON-openshift-COLON-oauth-apiserver.yamltest-data/apply-configuration/overall/minimal-cluster/expected-output/UserWorkload/Create/cluster-scoped-resources/rbac.authorization.k8s.io/clusterrolebindings/c9fd-body-system-COLON-openshift-COLON-useroauthaccesstoken-manager.yamltest-data/apply-configuration/overall/minimal-cluster/expected-output/UserWorkload/Create/cluster-scoped-resources/rbac.authorization.k8s.io/clusterrolebindings/c9fd-metadata-system-COLON-openshift-COLON-useroauthaccesstoken-manager.yamltest-data/apply-configuration/overall/minimal-cluster/expected-output/UserWorkload/Create/cluster-scoped-resources/rbac.authorization.k8s.io/clusterroles/e7c9-body-system-COLON-openshift-COLON-useroauthaccesstoken-manager.yamltest-data/apply-configuration/overall/minimal-cluster/expected-output/UserWorkload/Create/cluster-scoped-resources/rbac.authorization.k8s.io/clusterroles/e7c9-metadata-system-COLON-openshift-COLON-useroauthaccesstoken-manager.yamltest-data/apply-configuration/overall/minimal-cluster/expected-output/UserWorkload/Create/namespaces/openshift-oauth-apiserver/core/serviceaccounts/47ac-body-oauth-apiserver-sa.yamltest-data/apply-configuration/overall/minimal-cluster/expected-output/UserWorkload/Create/namespaces/openshift-oauth-apiserver/core/serviceaccounts/47ac-metadata-oauth-apiserver-sa.yamltest-data/apply-configuration/overall/minimal-cluster/expected-output/UserWorkload/Create/namespaces/openshift-oauth-apiserver/core/services/0908-body-api.yamltest-data/apply-configuration/overall/minimal-cluster/expected-output/UserWorkload/Create/namespaces/openshift-oauth-apiserver/core/services/0908-metadata-api.yamltest-data/apply-configuration/overall/oauth-server-configobserver/expected-output/Management/Create/namespaces/openshift-authentication-operator/core/events/0dc4-body-authentication-operator.18599d2230299800.5f2cc1a1.yamltest-data/apply-configuration/overall/oauth-server-configobserver/expected-output/Management/Create/namespaces/openshift-authentication-operator/core/events/3f97-body-authentication-operator.18599d2230299800.a8ecfbce.yamltest-data/apply-configuration/overall/oauth-server-configobserver/expected-output/Management/Create/namespaces/openshift-authentication-operator/core/events/3f97-metadata-authentication-operator.18599d2230299800.a8ecfbce.yamltest-data/apply-configuration/overall/oauth-server-configobserver/expected-output/Management/Create/namespaces/openshift-authentication-operator/core/events/76e5-body-authentication-operator.18599d2230299800.6182ed8c.yamltest-data/apply-configuration/overall/oauth-server-configobserver/expected-output/Management/Create/namespaces/openshift-authentication-operator/core/events/76e5-metadata-authentication-operator.18599d2230299800.6182ed8c.yamltest-data/apply-configuration/overall/oauth-server-configobserver/expected-output/Management/Create/namespaces/openshift-authentication-operator/core/events/78cb-body-authentication-operator.18599d2230299800.44a05c38.yamltest-data/apply-configuration/overall/oauth-server-configobserver/expected-output/Management/Create/namespaces/openshift-authentication-operator/core/events/78cb-metadata-authentication-operator.18599d2230299800.44a05c38.yamltest-data/apply-configuration/overall/oauth-server-configobserver/expected-output/Management/Create/namespaces/openshift-authentication-operator/core/events/a240-body-authentication-operator.18599d2230299800.49fb0e36.yamltest-data/apply-configuration/overall/oauth-server-configobserver/expected-output/Management/Create/namespaces/openshift-authentication-operator/core/events/a240-metadata-authentication-operator.18599d2230299800.49fb0e36.yamltest-data/apply-configuration/overall/oauth-server-configobserver/expected-output/Management/Create/namespaces/openshift-authentication-operator/core/events/b702-body-authentication-operator.18599d2230299800.1d05f9ac.yamltest-data/apply-configuration/overall/oauth-server-configobserver/expected-output/Management/Create/namespaces/openshift-authentication-operator/core/events/b702-metadata-authentication-operator.18599d2230299800.1d05f9ac.yamltest-data/apply-configuration/overall/oauth-server-configobserver/expected-output/Management/Create/namespaces/openshift-authentication-operator/core/events/d9cf-body-authentication-operator.18599d2230299800.560dcb58.yamltest-data/apply-configuration/overall/oauth-server-configobserver/expected-output/Management/Create/namespaces/openshift-authentication-operator/core/events/d9cf-metadata-authentication-operator.18599d2230299800.560dcb58.yamltest-data/apply-configuration/overall/oauth-server-configobserver/expected-output/Management/Create/namespaces/openshift-authentication-operator/core/events/ebf1-body-authentication-operator.18599d2230299800.2df24af9.yamltest-data/apply-configuration/overall/oauth-server-configobserver/expected-output/Management/Create/namespaces/openshift-authentication-operator/core/events/ebf1-metadata-authentication-operator.18599d2230299800.2df24af9.yamltest-data/apply-configuration/overall/oauth-server-configobserver/expected-output/Management/Create/namespaces/openshift-authentication-operator/core/events/f4a3-body-authentication-operator.18599d2230299800.6d9ca9b2.yamltest-data/apply-configuration/overall/oauth-server-configobserver/expected-output/Management/Create/namespaces/openshift-authentication-operator/core/events/f4a3-metadata-authentication-operator.18599d2230299800.6d9ca9b2.yamltest-data/apply-configuration/overall/oauth-server-creation-minimal/expected-output/Management/Create/namespaces/openshift-authentication-operator/core/events/d8ba-body-authentication-operator.18599d2230299800.64fe3b99.yamltest-data/apply-configuration/overall/oauth-server-creation-minimal/expected-output/Management/Create/namespaces/openshift-authentication-operator/core/events/d8ba-metadata-authentication-operator.18599d2230299800.64fe3b99.yamltest-data/apply-configuration/overall/oauth-server-creation-minimal/expected-output/Management/Create/namespaces/openshift-authentication/apps/deployments/2280-body-oauth-openshift.yamltest-data/apply-configuration/overall/oauth-server-creation-minimal/expected-output/Management/Create/namespaces/openshift-authentication/apps/deployments/2280-metadata-oauth-openshift.yamltest-data/apply-configuration/overall/oauth-server-payloadcontroller/expected-output/Management/Create/namespaces/openshift-authentication-operator/core/events/407c-body-authentication-operator.18599d2230299800.18b41977.yamltest-data/apply-configuration/overall/oauth-server-payloadcontroller/expected-output/Management/Create/namespaces/openshift-authentication-operator/core/events/407c-metadata-authentication-operator.18599d2230299800.18b41977.yamltest-data/apply-configuration/overall/oauth-server-payloadcontroller/expected-output/Management/Create/namespaces/openshift-authentication/core/configmaps/2260-body-v4-0-config-system-cliconfig.yamltest-data/apply-configuration/overall/oauth-server-payloadcontroller/expected-output/Management/Create/namespaces/openshift-authentication/core/configmaps/2260-metadata-v4-0-config-system-cliconfig.yamltest-data/apply-configuration/overall/oauth-server-staticresource/expected-output/Management/Create/cluster-scoped-resources/core/namespaces/8528-body-openshift-authentication.yamltest-data/apply-configuration/overall/oauth-server-staticresource/expected-output/Management/Create/cluster-scoped-resources/core/namespaces/8528-metadata-openshift-authentication.yamltest-data/apply-configuration/overall/oauth-server-staticresource/expected-output/Management/Create/namespaces/openshift-authentication-operator/core/events/0517-body-authentication-operator.18599d2230299800.6c145ec7.yamltest-data/apply-configuration/overall/oauth-server-staticresource/expected-output/Management/Create/namespaces/openshift-authentication-operator/core/events/0517-metadata-authentication-operator.18599d2230299800.6c145ec7.yamltest-data/apply-configuration/overall/oauth-server-staticresource/expected-output/Management/Create/namespaces/openshift-authentication-operator/core/events/0a35-body-authentication-operator.18599d2230299800.c1403ea8.yamltest-data/apply-configuration/overall/oauth-server-staticresource/expected-output/Management/Create/namespaces/openshift-authentication-operator/core/events/0a35-metadata-authentication-operator.18599d2230299800.c1403ea8.yamltest-data/apply-configuration/overall/oauth-server-staticresource/expected-output/Management/Create/namespaces/openshift-authentication-operator/core/events/15fd-body-authentication-operator.18599d2230299800.ce8a3f4a.yamltest-data/apply-configuration/overall/oauth-server-staticresource/expected-output/Management/Create/namespaces/openshift-authentication-operator/core/events/15fd-metadata-authentication-operator.18599d2230299800.ce8a3f4a.yamltest-data/apply-configuration/overall/oauth-server-staticresource/expected-output/Management/Create/namespaces/openshift-authentication-operator/core/events/3257-body-authentication-operator.18599d2230299800.2a6d0210.yamltest-data/apply-configuration/overall/oauth-server-staticresource/expected-output/Management/Create/namespaces/openshift-authentication-operator/core/events/3257-metadata-authentication-operator.18599d2230299800.2a6d0210.yamltest-data/apply-configuration/overall/oauth-server-staticresource/expected-output/Management/Create/namespaces/openshift-authentication-operator/core/events/5409-body-authentication-operator.18599d2230299800.ec96ffd6.yamltest-data/apply-configuration/overall/oauth-server-staticresource/expected-output/Management/Create/namespaces/openshift-authentication-operator/core/events/5409-metadata-authentication-operator.18599d2230299800.ec96ffd6.yamltest-data/apply-configuration/overall/oauth-server-staticresource/expected-output/Management/Create/namespaces/openshift-authentication-operator/core/events/55c4-body-authentication-operator.18599d2230299800.df0f8e47.yamltest-data/apply-configuration/overall/oauth-server-staticresource/expected-output/Management/Create/namespaces/openshift-authentication-operator/core/events/55c4-metadata-authentication-operator.18599d2230299800.df0f8e47.yamltest-data/apply-configuration/overall/oauth-server-staticresource/expected-output/Management/Create/namespaces/openshift-authentication-operator/core/events/6114-body-authentication-operator.18599d2230299800.07abf400.yamltest-data/apply-configuration/overall/oauth-server-staticresource/expected-output/Management/Create/namespaces/openshift-authentication-operator/core/events/6114-metadata-authentication-operator.18599d2230299800.07abf400.yamltest-data/apply-configuration/overall/oauth-server-staticresource/expected-output/Management/Create/namespaces/openshift-authentication-operator/core/events/96ee-body-authentication-operator.18599d2230299800.a18021d9.yamltest-data/apply-configuration/overall/oauth-server-staticresource/expected-output/Management/Create/namespaces/openshift-authentication-operator/core/events/96ee-metadata-authentication-operator.18599d2230299800.a18021d9.yamltest-data/apply-configuration/overall/oauth-server-staticresource/expected-output/Management/Create/namespaces/openshift-authentication-operator/core/events/a4b0-body-authentication-operator.18599d2230299800.fd7c2a06.yamltest-data/apply-configuration/overall/oauth-server-staticresource/expected-output/Management/Create/namespaces/openshift-authentication-operator/core/events/a4b0-metadata-authentication-operator.18599d2230299800.fd7c2a06.yamltest-data/apply-configuration/overall/oauth-server-staticresource/expected-output/Management/Create/namespaces/openshift-authentication-operator/core/events/bcca-body-authentication-operator.18599d2230299800.327a2f38.yamltest-data/apply-configuration/overall/oauth-server-staticresource/expected-output/Management/Create/namespaces/openshift-authentication-operator/core/events/bcca-metadata-authentication-operator.18599d2230299800.327a2f38.yamltest-data/apply-configuration/overall/oauth-server-staticresource/expected-output/Management/Create/namespaces/openshift-authentication-operator/core/events/dbdf-body-authentication-operator.18599d2230299800.8953695d.yamltest-data/apply-configuration/overall/oauth-server-staticresource/expected-output/Management/Create/namespaces/openshift-authentication-operator/core/events/dbdf-metadata-authentication-operator.18599d2230299800.8953695d.yamltest-data/apply-configuration/overall/oauth-server-staticresource/expected-output/Management/Create/namespaces/openshift-authentication-operator/core/events/fd80-body-authentication-operator.18599d2230299800.e6f3afa2.yamltest-data/apply-configuration/overall/oauth-server-staticresource/expected-output/Management/Create/namespaces/openshift-authentication-operator/core/events/fd80-metadata-authentication-operator.18599d2230299800.e6f3afa2.yamltest-data/apply-configuration/overall/oauth-server-staticresource/expected-output/Management/Create/namespaces/openshift-authentication/core/configmaps/5f92-body-audit.yamltest-data/apply-configuration/overall/oauth-server-staticresource/expected-output/Management/Create/namespaces/openshift-authentication/core/configmaps/5f92-metadata-audit.yamltest-data/apply-configuration/overall/oauth-server-staticresource/expected-output/Management/Create/namespaces/openshift-authentication/core/configmaps/a742-body-v4-0-config-system-trusted-ca-bundle.yamltest-data/apply-configuration/overall/oauth-server-staticresource/expected-output/Management/Create/namespaces/openshift-authentication/core/configmaps/a742-metadata-v4-0-config-system-trusted-ca-bundle.yamltest-data/apply-configuration/overall/oauth-server-staticresource/expected-output/Management/Create/namespaces/openshift-authentication/core/secrets/4034-body-v4-0-config-system-ocp-branding-template.yamltest-data/apply-configuration/overall/oauth-server-staticresource/expected-output/Management/Create/namespaces/openshift-authentication/core/secrets/4034-metadata-v4-0-config-system-ocp-branding-template.yamltest-data/apply-configuration/overall/oauth-server-staticresource/expected-output/Management/Create/namespaces/openshift-authentication/core/serviceaccounts/a3dc-body-oauth-openshift.yamltest-data/apply-configuration/overall/oauth-server-staticresource/expected-output/Management/Create/namespaces/openshift-authentication/core/serviceaccounts/a3dc-metadata-oauth-openshift.yamltest-data/apply-configuration/overall/oauth-server-staticresource/expected-output/Management/Create/namespaces/openshift-authentication/core/services/31c0-body-oauth-openshift.yamltest-data/apply-configuration/overall/oauth-server-staticresource/expected-output/Management/Create/namespaces/openshift-authentication/core/services/31c0-metadata-oauth-openshift.yamltest-data/apply-configuration/overall/oauth-server-staticresource/expected-output/Management/Create/namespaces/openshift-authentication/networking.k8s.io/networkpolicies/4519-body-default-deny-all.yamltest-data/apply-configuration/overall/oauth-server-staticresource/expected-output/Management/Create/namespaces/openshift-authentication/networking.k8s.io/networkpolicies/4519-metadata-default-deny-all.yamltest-data/apply-configuration/overall/oauth-server-staticresource/expected-output/Management/Create/namespaces/openshift-authentication/networking.k8s.io/networkpolicies/9eb2-body-oauth-server-networkpolicy.yamltest-data/apply-configuration/overall/oauth-server-staticresource/expected-output/Management/Create/namespaces/openshift-authentication/networking.k8s.io/networkpolicies/9eb2-metadata-oauth-server-networkpolicy.yamltest-data/apply-configuration/overall/oauth-server-staticresource/expected-output/Management/Create/namespaces/openshift-config-managed/rbac.authorization.k8s.io/rolebindings/735c-body-system-COLON-openshift-COLON-oauth-servercert-trust.yamltest-data/apply-configuration/overall/oauth-server-staticresource/expected-output/Management/Create/namespaces/openshift-config-managed/rbac.authorization.k8s.io/rolebindings/735c-metadata-system-COLON-openshift-COLON-oauth-servercert-trust.yamltest-data/apply-configuration/overall/oauth-server-staticresource/expected-output/Management/Create/namespaces/openshift-config-managed/rbac.authorization.k8s.io/roles/a92b-body-system-COLON-openshift-COLON-oauth-servercert-trust.yamltest-data/apply-configuration/overall/oauth-server-staticresource/expected-output/Management/Create/namespaces/openshift-config-managed/rbac.authorization.k8s.io/roles/a92b-metadata-system-COLON-openshift-COLON-oauth-servercert-trust.yamltest-data/apply-configuration/overall/oauth-server-staticresource/expected-output/UserWorkload/Create/cluster-scoped-resources/apiextensions.k8s.io/customresourcedefinitions/c340-body-rolebindingrestrictions.authorization.openshift.io.yamltest-data/apply-configuration/overall/oauth-server-staticresource/expected-output/UserWorkload/Create/cluster-scoped-resources/apiextensions.k8s.io/customresourcedefinitions/c340-metadata-rolebindingrestrictions.authorization.openshift.io.yamltest-data/apply-configuration/overall/oauth-server-staticresource/expected-output/UserWorkload/Create/cluster-scoped-resources/rbac.authorization.k8s.io/clusterrolebindings/4b1b-body-system-COLON-openshift-COLON-openshift-authentication.yamltest-data/apply-configuration/overall/oauth-server-staticresource/expected-output/UserWorkload/Create/cluster-scoped-resources/rbac.authorization.k8s.io/clusterrolebindings/4b1b-metadata-system-COLON-openshift-COLON-openshift-authentication.yaml
💤 Files with no reviewable changes (12)
- test-data/apply-configuration/overall/oauth-server-configobserver/expected-output/Management/Create/namespaces/openshift-authentication-operator/core/events/b702-body-authentication-operator.18599d2230299800.1d05f9ac.yaml
- test-data/apply-configuration/overall/oauth-server-configobserver/expected-output/Management/Create/namespaces/openshift-authentication-operator/core/events/3f97-body-authentication-operator.18599d2230299800.a8ecfbce.yaml
- test-data/apply-configuration/overall/oauth-server-creation-minimal/expected-output/Management/Create/namespaces/openshift-authentication-operator/core/events/d8ba-body-authentication-operator.18599d2230299800.64fe3b99.yaml
- test-data/apply-configuration/overall/oauth-server-payloadcontroller/expected-output/Management/Create/namespaces/openshift-authentication-operator/core/events/407c-body-authentication-operator.18599d2230299800.18b41977.yaml
- test-data/apply-configuration/overall/oauth-server-configobserver/expected-output/Management/Create/namespaces/openshift-authentication-operator/core/events/76e5-body-authentication-operator.18599d2230299800.6182ed8c.yaml
- test-data/apply-configuration/overall/minimal-cluster/expected-output/Management/Create/namespaces/openshift-authentication-operator/core/events/de10-body-authentication-operator.17fe72c59b829800.2a24f1b5.yaml
- test-data/apply-configuration/overall/oauth-server-configobserver/expected-output/Management/Create/namespaces/openshift-authentication-operator/core/events/ebf1-body-authentication-operator.18599d2230299800.2df24af9.yaml
- test-data/apply-configuration/overall/oauth-server-configobserver/expected-output/Management/Create/namespaces/openshift-authentication-operator/core/events/78cb-body-authentication-operator.18599d2230299800.44a05c38.yaml
- test-data/apply-configuration/overall/minimal-cluster/expected-output/Management/Create/namespaces/openshift-authentication-operator/core/events/6471-body-authentication-operator.17fe72c59b829800.57eb8535.yaml
- test-data/apply-configuration/overall/oauth-server-configobserver/expected-output/Management/Create/namespaces/openshift-authentication-operator/core/events/0dc4-body-authentication-operator.18599d2230299800.5f2cc1a1.yaml
- test-data/apply-configuration/overall/oauth-server-configobserver/expected-output/Management/Create/namespaces/openshift-authentication-operator/core/events/f4a3-body-authentication-operator.18599d2230299800.6d9ca9b2.yaml
- test-data/apply-configuration/overall/oauth-server-configobserver/expected-output/Management/Create/namespaces/openshift-authentication-operator/core/events/a240-body-authentication-operator.18599d2230299800.49fb0e36.yaml
🚧 Files skipped from review as they are similar to previous changes (16)
- test-data/apply-configuration/overall/minimal-cluster/expected-output/Management/Create/namespaces/openshift-authentication-operator/core/events/ccdf-body-authentication-operator.17fe72c59b829800.616f1c0f.yaml
- test-data/apply-configuration/overall/oauth-server-staticresource/expected-output/Management/Create/namespaces/openshift-authentication/networking.k8s.io/networkpolicies/4519-metadata-default-deny-all.yaml
- test-data/apply-configuration/overall/minimal-cluster/expected-output/Management/Create/namespaces/openshift-oauth-apiserver/networking.k8s.io/networkpolicies/312e-metadata-default-deny-all.yaml
- test-data/apply-configuration/overall/minimal-cluster/expected-output/Management/Create/namespaces/openshift-authentication-operator/core/events/ccdf-metadata-authentication-operator.17fe72c59b829800.616f1c0f.yaml
- test-data/apply-configuration/overall/oauth-server-staticresource/expected-output/Management/Create/namespaces/openshift-authentication/networking.k8s.io/networkpolicies/4519-body-default-deny-all.yaml
- test-data/apply-configuration/overall/minimal-cluster/expected-output/Management/Create/namespaces/openshift-authentication-operator/core/events/6393-metadata-authentication-operator.17fe72c59b829800.c879600c.yaml
- test-data/apply-configuration/overall/minimal-cluster/expected-output/Management/Create/namespaces/openshift-authentication-operator/core/events/cedd-body-authentication-operator.17fe72c59b829800.96072a72.yaml
- test-data/apply-configuration/overall/minimal-cluster/expected-output/Management/Create/namespaces/openshift-authentication-operator/core/events/3f86-metadata-authentication-operator.17fe72c59b829800.05fbd8b8.yaml
- test-data/apply-configuration/overall/minimal-cluster/expected-output/Management/Create/namespaces/openshift-authentication-operator/core/events/fb69-body-authentication-operator.17fe72c59b829800.2a6d0210.yaml
- test-data/apply-configuration/overall/minimal-cluster/expected-output/Management/Create/namespaces/openshift-authentication/networking.k8s.io/networkpolicies/4519-metadata-default-deny-all.yaml
- test-data/apply-configuration/overall/oauth-server-configobserver/expected-output/Management/Create/namespaces/openshift-authentication-operator/core/events/d9cf-body-authentication-operator.18599d2230299800.560dcb58.yaml
- test-data/apply-configuration/overall/oauth-server-configobserver/expected-output/Management/Create/namespaces/openshift-authentication-operator/core/events/d9cf-metadata-authentication-operator.18599d2230299800.560dcb58.yaml
- test-data/apply-configuration/overall/minimal-cluster/expected-output/Management/Create/namespaces/openshift-authentication-operator/core/events/cedd-metadata-authentication-operator.17fe72c59b829800.96072a72.yaml
- test-data/apply-configuration/overall/minimal-cluster/expected-output/Management/Create/namespaces/openshift-authentication-operator/core/events/fb69-metadata-authentication-operator.17fe72c59b829800.2a6d0210.yaml
- test-data/apply-configuration/overall/minimal-cluster/expected-output/Management/Create/namespaces/openshift-authentication-operator/core/events/53aa-body-authentication-operator.17fe72c59b829800.ec96ffd6.yaml
- test-data/apply-configuration/overall/minimal-cluster/expected-output/Management/Create/namespaces/openshift-authentication-operator/core/events/6393-body-authentication-operator.17fe72c59b829800.c879600c.yaml
| podSelector: | ||
| matchLabels: | ||
| app: etcd | ||
| - {} |
There was a problem hiding this comment.
egress: - {} makes egress effectively unrestricted.
Line 30 allows all egress (any destination/port/protocol), which weakens the intended deny-by-default posture for selected pods. If the hostNetwork exception is the goal, constrain this to TCP-only instead of fully open egress.
Suggested fix
- - {}
+ - ports:
+ - protocol: TCP📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| - {} | |
| - ports: | |
| - protocol: TCP |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In
`@test-data/apply-configuration/overall/minimal-cluster/expected-output/Management/Create/namespaces/openshift-oauth-apiserver/networking.k8s.io/networkpolicies/fcd4-body-oauth-apiserver-networkpolicy.yaml`
at line 30, The NetworkPolicy named in the patch
(fcd4-body-oauth-apiserver-networkpolicy) currently uses "egress: - {}" which
permits all outbound traffic; replace that open egress rule with a constrained
egress entry that limits traffic to TCP only (e.g., specify protocol: TCP and an
appropriate ports list or port range) while preserving the hostNetwork exception
logic so the deny-by-default posture is maintained for the targeted pods.
| podSelector: | ||
| matchLabels: | ||
| app: openshift-oauth-apiserver | ||
| - {} |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
# Find and read the full network policy file
find . -name "9eb2-body-oauth-server-networkpolicy.yaml" -type fRepository: openshift/cluster-authentication-operator
Length of output: 500
🏁 Script executed:
# Read the full content of the file to understand context
cat -n "test-data/apply-configuration/overall/oauth-server-staticresource/expected-output/Management/Create/namespaces/openshift-authentication/networking.k8s.io/networkpolicies/9eb2-body-oauth-server-networkpolicy.yaml"Repository: openshift/cluster-authentication-operator
Length of output: 1753
🌐 Web query:
Kubernetes NetworkPolicy empty egress rule semantics "{}" all traffic
💡 Result:
In Kubernetes NetworkPolicy, an empty egress rule item:
spec:
policyTypes: [Egress]
egress:
- {}means “allow all egress” (all destinations, all ports, all protocols that your CNI enforces for NetworkPolicy). Kubernetes’ own example for “Allow all egress traffic” uses exactly egress: - {} and states that with it in place, outgoing connections from the selected pods cannot be denied by additional policies. [1] The same “empty rule matches all traffic” explanation is also shown in Google’s training material. [2]
By contrast, if you select pods for egress isolation but provide no allow rules, you get deny-all egress, e.g.:
spec:
podSelector: {}
policyTypes: [Egress]
# no egress: rulesKubernetes documents this as the “default deny all egress traffic” pattern. [1]
Summary: egress: - {} ⇒ allow-all egress; policyTypes: [Egress] with no egress rules ⇒ deny-all egress. [1]
Sources: [1] Kubernetes NetworkPolicy docs; [2] Google Kubernetes Engine Networking training PDF.
egress: - {} allows all egress traffic, defeating the restrictive intent of this policy.
The empty egress rule at line 30 permits outbound traffic to all destinations on all ports and protocols. With policyTypes: [Egress] set, this rule makes the specific DNS and OAuth apiserver rules above it redundant and undermines any default-deny egress posture. Remove this line unless there is a documented exception (e.g., hostNetwork pods requiring unrestricted egress); if an exception is necessary, explicitly scope it rather than using an empty rule.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In
`@test-data/apply-configuration/overall/oauth-server-staticresource/expected-output/Management/Create/namespaces/openshift-authentication/networking.k8s.io/networkpolicies/9eb2-body-oauth-server-networkpolicy.yaml`
at line 30, The network policy contains an empty egress rule ("egress: - {}")
that effectively allows all outbound traffic and defeats the intended
restrictive posture with "policyTypes: [Egress]"; remove the empty egress entry
from the NetworkPolicy (or replace it with explicit, scoped egress rules) so
only the intended DNS and OAuth API server egress rules remain; if an exception
is required (e.g., hostNetwork pods), implement a narrowly scoped egress rule
instead of using the empty rule.
|
@liouk: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/retest-required |
|
@gangwgr: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@gangwgr: trigger 14 job(s) of type blocking for the nightly release of OCP 4.21
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/8c2802b0-1bbc-11f1-992c-670fa0983e22-0 |
|
@gangwgr: trigger 14 job(s) of type blocking for the nightly release of OCP 4.21
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/91204e12-1bbc-11f1-9bd9-3709c9fb6888-0 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: everettraven, liouk The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/payload 4.22 nightly blocking |
|
@liouk: trigger 14 job(s) of type blocking for the nightly release of OCP 4.22
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/4d3a5cd0-1bbf-11f1-91c5-3168c8d0f85b-0 trigger 65 job(s) of type informing for the nightly release of OCP 4.22
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/4d3a5cd0-1bbf-11f1-91c5-3168c8d0f85b-1 |
This PR adds network policies to the authentication operator, oauth-server and oauth-apiserver. For each component, there are two policies:
All known and required connections must be reflected to respective allow rules.
Note that, in case of pods that require traffic to/from hostNetwork pods (such as the kube-apiserver), we need to allow all ingress/egress TCP traffic; NetworkPolicies do not affect pods on hostNetwork, but we still need a rule to allow ingress/egress from/to them.
In some cases there might be some overlap in the policy rules, but this is intentional for the sake of documentation/future reference.
Summary by CodeRabbit