Skip to content

Implementation of MCP e2e test#2882

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
blublinsky:mcp-e2e-tests
Apr 16, 2026
Merged

Implementation of MCP e2e test#2882
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
blublinsky:mcp-e2e-tests

Conversation

@blublinsky
Copy link
Copy Markdown
Contributor

@blublinsky blublinsky commented Apr 7, 2026

Description

This PR adds automated end-to-end tests for MCP (Model Context Protocol) integration, covering tool discovery, authentication methods (file-based, Kubernetes token passthrough, client-provided headers), tool filtering, graceful error handling, and tool approval workflows. The tests run both locally against a manually-started mock server and on-cluster in CI, where the mock server is deployed as a pod.

Test implemented:

  1. test_discovery_endpoint_lists_client_auth_servers |
  2. test_wrong_url_graceful_degradation mock-bad-url is unreachable
  3. test_query_without_client_headers
  4. test_query_with_client_headers
  5. test_readonly_tool_skips_approval
  6. test_tool_no_annotation_approved - Tool with no annotations requires approval; approving lets it execute (streaming)
  7. test_tool_readonly_false_approved -Tool with readOnlyHint=false requires approval; approving lets it execute (streaming)
  8. test_tool_approval_denied
  9. test_tool_approval_timeout

Type of change

  • Refactor
  • [x ] New feature
  • Bug fix
  • CVE fix
  • Optimization
  • Documentation Update
  • Configuration Update
  • Bump-up dependent library
  • Bump-up library or tool used for development (does not change the final image)
  • CI configuration change
  • Konflux configuration change

Related Tickets & Documents

Checklist before requesting a review

  • I have performed a self-review of my code.
  • PR has passed all pre-merge test jobs.
  • If it is a core feature, I have added thorough tests.

Testing

  • Please provide detailed steps to perform tests related to this code change.
  • How were the fix/results from this change verified? Please provide relevant screenshots or results.

@openshift-ci openshift-ci bot requested review from bparees and onmete April 7, 2026 12:24
@blublinsky blublinsky force-pushed the mcp-e2e-tests branch 2 times, most recently from 30535c7 to df7f67e Compare April 9, 2026 07:27
@blublinsky blublinsky changed the title initial implementation of MCP e2e test Implementation of MCP e2e test Apr 9, 2026
@blublinsky
Copy link
Copy Markdown
Contributor Author

/retest

@JoaoFula
Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 10, 2026
@blublinsky
Copy link
Copy Markdown
Contributor Author

/retest

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 15, 2026
@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Apr 15, 2026

@blublinsky: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@JoaoFula
Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 16, 2026
@blublinsky
Copy link
Copy Markdown
Contributor Author

/approve

@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Apr 16, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: blublinsky

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 16, 2026
@openshift-merge-bot openshift-merge-bot bot merged commit 81afbef into openshift:main Apr 16, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants