Skip to content

OCPBUGS-105461: allow baremetal to progress while MCO does #31511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
maschmid wants to merge 1 commit into
base: main
Choose a base branch
from
Open

OCPBUGS-105461: allow baremetal to progress while MCO does #31511

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions pkg/monitortests/clusterversionoperator/legacycvomonitortests/operators.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -650,8 +650,6 @@ func testUpgradeOperatorProgressingStateTransitions(events monitorapi.Intervals,
return fmt.Sprintf("%s completing its update within less than three minutes: %s", co, summary)
}
switch co {
case "baremetal":
return "https://issues.redhat.com/browse/OCPBUGS-66101"
case "cloud-controller-manager":
return "https://issues.redhat.com/browse/OCPBUGS-64852"
case "operator-lifecycle-manager":
Expand Down Expand Up @@ -710,6 +708,13 @@ func testUpgradeOperatorProgressingStateTransitions(events monitorapi.Intervals,

except = func(co string, reason string) string {
switch co {
case "baremetal":
// Since OCPBUGS-66101 was fixed, the baremetal operator intentionally reports Progressing=True
// during upgrades (reason SyncingResources, "Applying metal3 resources") while it syncs its
// metal3 resources, which legitimately overlaps with the machine-config progressing window.
if reason == "SyncingResources" {
return "baremetal is allowed to be Progressing=True while machine-config is progressing, as it applies metal3 resources during upgrades"
}
Comment thread
coderabbitai[bot] marked this conversation as resolved.
case "authentication":
if isTwoNode && (reason == "APIServerDeployment_NewGeneration" || reason == "APIServerDeployment_PodsUpdating") {
return "authentication operator may roll oauth-apiserver (APIServerDeployment_NewGeneration or APIServerDeployment_PodsUpdating) during DualReplica upgrades while machine-config is progressing"
Expand Down