OCPBUGS-100352: Set testdata CA expiry to 20 years from issue date (#4112) by simonpasquier · Pull Request #145 · openshift/prometheus-alertmanager

simonpasquier · 2026-07-31T07:10:35Z

Also add human-readable x509 text format.

Also add human-readable x509 text format. Signed-off-by: Daniel Swarbrick <daniel.swarbrick@gmail.com>

coderabbitai · 2026-07-31T07:22:11Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: f7ec2f0b-64e3-4e41-86c3-38d003ce24a7

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

_{Comment @coderabbitai help to get the list of available commands.}

openshift-ci-robot · 2026-07-31T08:45:17Z

@simonpasquier: This pull request references Jira Issue OCPBUGS-100352, which is invalid:

expected the bug to target only the "4.21.z" version, but multiple target versions were set
expected dependent Jira Issue OCPBUGS-100351 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is Closed (Cannot Reproduce) instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

simonpasquier · 2026-07-31T08:45:57Z

/jira backport release-4.20,release-4.19,release-4.18,release-4.17,release-4.16,release-4.15,release-4.14,release-4.13,release-4.12

simonpasquier · 2026-07-31T08:46:02Z

/jira refresh

openshift-ci-robot · 2026-07-31T08:46:07Z

@simonpasquier: This pull request references Jira Issue OCPBUGS-100352, which is invalid:

expected dependent Jira Issue OCPBUGS-100351 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is Closed (Cannot Reproduce) instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

simonpasquier · 2026-07-31T08:47:13Z

/jira refresh

openshift-ci-robot · 2026-07-31T08:47:20Z

@simonpasquier: This pull request references Jira Issue OCPBUGS-100352, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.21.z) matches configured target version for branch (4.21.z)
bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
release note text is set and does not match the template
dependent bug Jira Issue OCPBUGS-100351 is in the state Closed (Done), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
dependent Jira Issue OCPBUGS-100351 targets the "4.22.0" version, which is one of the valid target versions: 4.22.0
bug has dependents

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

simonpasquier · 2026-07-31T08:48:10Z

/label backport-risk-assessed
/verified by unit tests

openshift-ci-robot · 2026-07-31T08:48:15Z

@simonpasquier: This PR has been marked as verified by unit tests.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

simonpasquier · 2026-07-31T08:52:16Z

/jira backport release-4.20,release-4.19,release-4.18,release-4.17,release-4.16,release-4.15,release-4.14,release-4.13,release-4.12

openshift-ci-robot · 2026-07-31T08:56:11Z

@simonpasquier: The following backport issues have been created:

Jira Issue OCPBUGS-100353 for branch release-4.20
Jira Issue OCPBUGS-100354 for branch release-4.19
Jira Issue OCPBUGS-100355 for branch release-4.18
Jira Issue OCPBUGS-100356 for branch release-4.17
Jira Issue OCPBUGS-100357 for branch release-4.16
Jira Issue OCPBUGS-100358 for branch release-4.15
Jira Issue OCPBUGS-100360 for branch release-4.14
Jira Issue OCPBUGS-100362 for branch release-4.13
Jira Issue OCPBUGS-100364 for branch release-4.12

Queuing cherrypicks to the requested branches to be created after this PR merges:
/cherrypick release-4.20
/cherrypick release-4.19
/cherrypick release-4.18
/cherrypick release-4.17
/cherrypick release-4.16
/cherrypick release-4.15
/cherrypick release-4.14
/cherrypick release-4.13
/cherrypick release-4.12

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-cherrypick-robot · 2026-07-31T08:56:14Z

@openshift-ci-robot: once the present PR merges, I will cherry-pick it on top of release-4.12, release-4.13, release-4.14, release-4.15, release-4.16, release-4.17, release-4.18, release-4.19, release-4.20 in new PRs and assign them to you.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci-robot · 2026-07-31T08:56:58Z

@simonpasquier: The following backport issues have been created:

Jira Issue OCPBUGS-100353 for branch release-4.20
Jira Issue OCPBUGS-100354 for branch release-4.19
Jira Issue OCPBUGS-100355 for branch release-4.18
Jira Issue OCPBUGS-100356 for branch release-4.17
Jira Issue OCPBUGS-100357 for branch release-4.16
Jira Issue OCPBUGS-100359 for branch release-4.15
Jira Issue OCPBUGS-100361 for branch release-4.14
Jira Issue OCPBUGS-100363 for branch release-4.13
Jira Issue OCPBUGS-100365 for branch release-4.12

Queuing cherrypicks to the requested branches to be created after this PR merges:
/cherrypick release-4.20
/cherrypick release-4.19
/cherrypick release-4.18
/cherrypick release-4.17
/cherrypick release-4.16
/cherrypick release-4.15
/cherrypick release-4.14
/cherrypick release-4.13
/cherrypick release-4.12

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-cherrypick-robot · 2026-07-31T08:57:01Z

@openshift-ci-robot: once the present PR merges, I will cherry-pick it on top of release-4.12, release-4.13, release-4.14, release-4.15, release-4.16, release-4.17, release-4.18, release-4.19, release-4.20 in new PRs and assign them to you.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

slashpai

/lgtm

openshift-ci · 2026-07-31T09:31:09Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: simonpasquier, slashpai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [simonpasquier,slashpai]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

simonpasquier · 2026-07-31T10:29:36Z

/test okd-scos-images

simonpasquier · 2026-07-31T11:16:26Z

/test okd-scos-images

danielmellado · 2026-07-31T11:47:25Z

error: failed to push image registry.build12.ci.openshift.org/ci-op-hhk2bjqs/release:latest: unable to upload new layer (0): Patch "https://registry.build12.ci.openshift.org/v2/ci-op-hhk2bjqs/release/blobs/uploads/52576157-304d-4a01-98bd-f1b9176ad76e?_state=xN0yGMR9jpLyFAitzjteciSTYDkBzUK7_imjVML2M7d7Ik5hbWUiOiJjaS1vcC1oaGsyYmpxcy9yZWxlYXNlIiwiVVVJRCI6IjUyNTc2MTU3LTMwNGQtNGEwMS05OGJkLWYxYjkxNzZhZDc2ZSIsIk9mZnNldCI6MCwiU3RhcnRlZEF0IjoiMjAyNi0wNy0zMVQxMToxNzoxNi44NDY1NzEwMTJaIn0%3D": operator "machine-config-operator" contained an invalid image-references file: no input image tag named "keepalived-ipfailover"

I think the issue is unrelated to your patch

danielmellado · 2026-07-31T11:47:32Z

/test okd-scos-images

simonpasquier · 2026-07-31T13:00:59Z

/override ci/prow/okd-scos-images

openshift-ci · 2026-07-31T13:01:16Z

@simonpasquier: Overrode contexts on behalf of simonpasquier: ci/prow/okd-scos-images

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci · 2026-07-31T13:01:18Z

@simonpasquier: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/okd-scos-images	`1ed4327`	link	true	`/test okd-scos-images`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci-robot · 2026-07-31T13:03:55Z

@simonpasquier: Jira Issue Verification Checks: Jira Issue OCPBUGS-100352
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-100352 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-cherrypick-robot · 2026-07-31T13:04:43Z

@openshift-ci-robot: new pull request created: #146

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-cherrypick-robot · 2026-07-31T13:05:25Z

@openshift-ci-robot: new pull request created: #147

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-cherrypick-robot · 2026-07-31T13:06:06Z

@openshift-ci-robot: new pull request created: #148

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-cherrypick-robot · 2026-07-31T13:06:47Z

@openshift-ci-robot: new pull request created: #149

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-cherrypick-robot · 2026-07-31T13:07:27Z

@openshift-ci-robot: new pull request created: #150

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-cherrypick-robot · 2026-07-31T13:08:08Z

@openshift-ci-robot: new pull request created: #151

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-cherrypick-robot · 2026-07-31T13:08:49Z

@openshift-ci-robot: new pull request created: #152

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-cherrypick-robot · 2026-07-31T13:09:29Z

@openshift-ci-robot: new pull request created: #153

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-cherrypick-robot · 2026-07-31T13:10:10Z

@openshift-ci-robot: new pull request created: #154

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-merge-robot · 2026-08-01T09:32:34Z

Fix included in release 4.21.0-0.nightly-2026-08-01-002544

Set testdata CA expiry to 20 years from issue date (prometheus#4112)

1ed4327

Also add human-readable x509 text format. Signed-off-by: Daniel Swarbrick <daniel.swarbrick@gmail.com>

openshift-ci Bot requested review from danielmellado and rexagod July 31, 2026 07:10

openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 31, 2026

simonpasquier changed the title ~~Set testdata CA expiry to 20 years from issue date (#4112)~~ OCPBUGS-100352: Set testdata CA expiry to 20 years from issue date (#4112) Jul 31, 2026

openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jul 31, 2026

openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Jul 31, 2026

openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Jul 31, 2026

openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Jul 31, 2026

openshift-ci Bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Jul 31, 2026

slashpai reviewed Jul 31, 2026

View reviewed changes

openshift-ci Bot assigned slashpai Jul 31, 2026

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jul 31, 2026

openshift-merge-bot Bot merged commit c027844 into openshift:release-4.21 Jul 31, 2026
11 checks passed

openshift-cherrypick-robot mentioned this pull request Jul 31, 2026

[release-4.16] OCPBUGS-100357: Set testdata CA expiry to 20 years from issue date (#4112) #146

Merged

openshift-cherrypick-robot mentioned this pull request Jul 31, 2026

[release-4.14] OCPBUGS-100361: Set testdata CA expiry to 20 years from issue date (#4112) #147

Merged

openshift-cherrypick-robot mentioned this pull request Jul 31, 2026

[release-4.18] OCPBUGS-100355: Set testdata CA expiry to 20 years from issue date (#4112) #148

Merged

openshift-cherrypick-robot mentioned this pull request Jul 31, 2026

[release-4.20] OCPBUGS-100353: Set testdata CA expiry to 20 years from issue date (#4112) #149

Merged

This was referenced Jul 31, 2026

[release-4.19] OCPBUGS-100354: Set testdata CA expiry to 20 years from issue date (#4112) #150

Merged

[release-4.17] OCPBUGS-100356: Set testdata CA expiry to 20 years from issue date (#4112) #151

Merged

openshift-cherrypick-robot mentioned this pull request Jul 31, 2026

[release-4.13] OCPBUGS-100363: Set testdata CA expiry to 20 years from issue date (#4112) #152

Open

openshift-cherrypick-robot mentioned this pull request Jul 31, 2026

[release-4.15] OCPBUGS-100359: Set testdata CA expiry to 20 years from issue date (#4112) #153

Merged

openshift-cherrypick-robot mentioned this pull request Jul 31, 2026

[release-4.12] OCPBUGS-100365: Set testdata CA expiry to 20 years from issue date (#4112) #154

Open

simonpasquier deleted the fix-certificate-tests branch July 31, 2026 13:16

Uh oh!

Conversation

simonpasquier commented Jul 31, 2026

Uh oh!

coderabbitai Bot commented Jul 31, 2026

Review skipped

Uh oh!

openshift-ci-robot commented Jul 31, 2026

Uh oh!

simonpasquier commented Jul 31, 2026

Uh oh!

simonpasquier commented Jul 31, 2026

Uh oh!

openshift-ci-robot commented Jul 31, 2026

Uh oh!

simonpasquier commented Jul 31, 2026

Uh oh!

openshift-ci-robot commented Jul 31, 2026

Uh oh!

simonpasquier commented Jul 31, 2026

Uh oh!

openshift-ci-robot commented Jul 31, 2026

Uh oh!

simonpasquier commented Jul 31, 2026

Uh oh!

openshift-ci-robot commented Jul 31, 2026

Uh oh!

openshift-cherrypick-robot commented Jul 31, 2026

Uh oh!

openshift-ci-robot commented Jul 31, 2026

Uh oh!

openshift-cherrypick-robot commented Jul 31, 2026

Uh oh!

slashpai left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-ci Bot commented Jul 31, 2026

Uh oh!

simonpasquier commented Jul 31, 2026

Uh oh!

simonpasquier commented Jul 31, 2026

Uh oh!

danielmellado commented Jul 31, 2026

Uh oh!

danielmellado commented Jul 31, 2026

Uh oh!

simonpasquier commented Jul 31, 2026

Uh oh!

openshift-ci Bot commented Jul 31, 2026

Uh oh!

openshift-ci Bot commented Jul 31, 2026

Uh oh!

Uh oh!

openshift-ci-robot commented Jul 31, 2026

Uh oh!

openshift-cherrypick-robot commented Jul 31, 2026

Uh oh!

openshift-cherrypick-robot commented Jul 31, 2026

Uh oh!

openshift-cherrypick-robot commented Jul 31, 2026

Uh oh!

openshift-cherrypick-robot commented Jul 31, 2026

Uh oh!

openshift-cherrypick-robot commented Jul 31, 2026

Uh oh!

openshift-cherrypick-robot commented Jul 31, 2026

Uh oh!

openshift-cherrypick-robot commented Jul 31, 2026

Uh oh!

openshift-cherrypick-robot commented Jul 31, 2026

Uh oh!

openshift-cherrypick-robot commented Jul 31, 2026

Uh oh!

openshift-merge-robot commented Aug 1, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone