Governance umbrella#2804
Conversation
🛡️ AI Review — Skeptic (security review)VERDICT: SAFE BASELINE scrutiny: l0r1s is an established contributor with repository write permission; no Gittensor allowlist hit found; governance-umbrella -> devnet-ready. Cached PR metadata reports 0 changed files, 0 additions, and 0 deletions. FindingsNo findings. ConclusionNo malicious code or security vulnerability is present in the cached diff because this PR currently contains no file changes. Re-run Skeptic after substantive commits are pushed. 🔍 AI Review — Auditor (domain review)VERDICT: 👍 Gittensor: UNKNOWN; author has repository write permission and substantial prior contribution history. Diff is empty, with no overlapping changed files. The prefetched PR diff is empty ( No spec-version bump is required. I did not run builds or tests because there is no changed code to confirm. FindingsNo findings. ConclusionApproved for the current empty diff only. The stacked governance PRs still need their own full domain reviews before they are merged into this umbrella branch. |
|
🔄 AI review updated — Skeptic: SAFE Auditor: 👍 |
|
🔄 AI review updated — Skeptic: SAFE Auditor: 👍 |
|
🔄 AI review updated — Skeptic: SAFE Auditor: 👍 |
Summary
Umbrella PR for the Subtensor on-chain governance stack.
This branch intentionally starts without implementation code. The stacked PRs below will be merged into this branch so reviewers can inspect the full governance system in one place before the umbrella is merged into the base branch.
The full stack introduces a two-stage on-chain governance flow for root calls: proposers submit, the Triumvirate approves or rejects, and the Economic + Building review set can fast-track, delay, or cancel enactment.
Stack
Review Notes
The first three implementation PRs add generic pallets and shared interfaces without wiring them into the runtime. The final wiring PR defines Subtensor's concrete governance model and connects the pallets together.
The stacked PRs include exhaustive README documentation for each layer:
pallets/multi-collective/README.md- collective membership model, extrinsics, hooks, rotation, and configuration.pallets/signed-voting/README.md- voting backend lifecycle, voter snapshots, tally updates, and cleanup.pallets/referenda/README.md- track state machine, decision strategies, scheduling, and dispatch safety.docs/governance/README.mdandruntime/src/governance/README.md- the concrete Subtensor governance model.Testing
Testing is covered in the stacked PRs: pallet unit tests, benchmarks/generated weights, Subtensor integration tests, and TypeScript E2E governance suites.