Skip to content

Governance umbrella#2804

Open
l0r1s wants to merge 2 commits into
devnet-readyfrom
governance-umbrella
Open

Governance umbrella#2804
l0r1s wants to merge 2 commits into
devnet-readyfrom
governance-umbrella

Conversation

@l0r1s

@l0r1s l0r1s commented Jun 29, 2026

Copy link
Copy Markdown
Collaborator

Summary

Umbrella PR for the Subtensor on-chain governance stack.

This branch intentionally starts without implementation code. The stacked PRs below will be merged into this branch so reviewers can inspect the full governance system in one place before the umbrella is merged into the base branch.

The full stack introduces a two-stage on-chain governance flow for root calls: proposers submit, the Triumvirate approves or rejects, and the Economic + Building review set can fast-track, delay, or cancel enactment.

Stack

  1. [Governance 1/4] Introduce pallet-multi-collective #2805 - generic collective membership pallet.
  2. [Governance 2/4] Introduce pallet-signed-voting #2806 - signed aye/nay voting backend.
  3. [Governance 3/4] Introduce pallet-referenda #2807 - track-based referendum state machine.
  4. [Governance 4/4] Runtime wiring #2808- Subtensor runtime wiring, root-registration integration, docs, benchmarks, and E2E tests.

Review Notes

The first three implementation PRs add generic pallets and shared interfaces without wiring them into the runtime. The final wiring PR defines Subtensor's concrete governance model and connects the pallets together.

The stacked PRs include exhaustive README documentation for each layer:

Testing

Testing is covered in the stacked PRs: pallet unit tests, benchmarks/generated weights, Subtensor integration tests, and TypeScript E2E governance suites.

@github-actions

github-actions Bot commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

🛡️ AI Review — Skeptic (security review)

VERDICT: SAFE

BASELINE scrutiny: l0r1s is an established contributor with repository write permission; no Gittensor allowlist hit found; governance-umbrella -> devnet-ready.

Cached PR metadata reports 0 changed files, 0 additions, and 0 deletions. /tmp/ai-review-context/pr-diff.patch is empty, so there are no PR-side .github/ai-review/* or .github/copilot-instructions.md changes to flag in this snapshot.

Findings

No findings.

Conclusion

No malicious code or security vulnerability is present in the cached diff because this PR currently contains no file changes. Re-run Skeptic after substantive commits are pushed.


🔍 AI Review — Auditor (domain review)

VERDICT: 👍

Gittensor: UNKNOWN; author has repository write permission and substantial prior contribution history. Diff is empty, with no overlapping changed files.

The prefetched PR diff is empty (pr-diff.patch is 0 bytes) and pr-files.json lists no changed files, so there is no runtime, pallet, node, dependency, or tooling change to audit. The PR body is substantive and accurately describes this as an umbrella branch for stacked governance PRs.

No spec-version bump is required. I did not run builds or tests because there is no changed code to confirm.

Findings

No findings.

Conclusion

Approved for the current empty diff only. The stacked governance PRs still need their own full domain reviews before they are merged into this umbrella branch.

@github-actions

Copy link
Copy Markdown
Contributor

🔄 AI review updated — Skeptic: SAFE Auditor: 👍

@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

🔄 AI review updated — Skeptic: SAFE Auditor: 👍

@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

🔄 AI review updated — Skeptic: SAFE Auditor: 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant