Backport hotfixes 29-06-2026#2814
Conversation
…ensor into fix/balancer-performance
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…g back the initial stake when the recycle or burn leg fails.
Fix balancer performance
Apply tx & dispatch extensions conditionally
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
|
||
| // Temporarily allow the destination coldkey to receive this stake even if some of it is | ||
| // locked; swap_coldkey_locks will copy the source AccountFlags over afterward. | ||
| Self::set_accept_locked_alpha(new_coldkey, true); |
There was a problem hiding this comment.
[MEDIUM] Coldkey swap now writes AccountFlags without a weight update
This call mutates AccountFlags before every coldkey swap, and swap_coldkey_locks now also removes/inserts AccountFlags when moving the source flags to the destination. The generated weights still list AccountFlags as r:1 w:0 for both swap_coldkey_announced and swap_coldkey, and weights.rs is unchanged in this PR, so these runtime extrinsics are undercharged for the new storage writes. Regenerate the benchmarks/weights, or manually update the swap weights to include the additional AccountFlags read/write operations.
🛡️ AI Review — Skeptic (security review)VERDICT: VULNERABLE BASELINE scrutiny: l0r1s has repo write permission, an established account, and substantial prior subtensor activity; branch hotfixes-29-06-2026 -> devnet-ready; no Gittensor allowlist match found. The diff does not modify Findings
Prior-comment reconciliation
ConclusionThe PR appears legitimate, but the coldkey-swap locked-alpha change still undercharges newly-added runtime storage writes. Regenerate or adjust the affected weights before merge. 📜 Previous run (superseded)
# 🔍 AI Review — Auditor (domain review) has not yet run on this PR. |
|
🔄 AI review updated — Skeptic: VULNERABLE |
l0r1s
added
the
skip-cargo-audit
|
|
||
| // Temporarily allow the destination coldkey to receive this stake even if some of it is | ||
| // locked; swap_coldkey_locks will copy the source AccountFlags over afterward. | ||
| Self::set_accept_locked_alpha(new_coldkey, true); |
There was a problem hiding this comment.
[MEDIUM] Coldkey swap still writes AccountFlags without a weight update
do_swap_coldkey now calls set_accept_locked_alpha, and swap_coldkey_locks now moves/removes AccountFlags, but generated WeightInfo::{swap_coldkey, swap_coldkey_announced} still account AccountFlags as r:1 w:0; the PR does not update pallets/subtensor/src/weights.rs. These extrinsics therefore undercharge the added runtime storage writes. Regenerate benchmarks or manually bump both weights to include the new AccountFlags reads/writes before merge.
|
🔄 AI review updated — Skeptic: VULNERABLE |
3 participants
Backports the following hotfixes to devnet-ready: