Skip to content

Conversation

@gimmyhehe
Copy link
Member

@gimmyhehe gimmyhehe commented Dec 12, 2025

PR

边框模式下,表格新增上边框。 & 优化表格editor的文档events示例

PR Checklist

before:
image

after:
image

Please check if your PR fulfills the following requirements:

  • The commit message follows our Commit Message Guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Summary by CodeRabbit

  • Documentation

    • Updated API documentation reference for the grid-column renderer property.
  • Improvements

    • Added change event handling to TinySelect editor components for capturing and responding to value changes.
  • Style

    • Enhanced grid table styling with a top border on the table body for improved visual separation.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Dec 12, 2025

Walkthrough

This pull request updates grid editor examples and styling: documentation metadata references are corrected, event handlers are added to two custom editor components to log select value changes, and a border-top style rule is introduced to the grid table body styling.

Changes

Cohort / File(s) Summary
Documentation metadata reference
examples/sites/demos/apis/grid.js
Updated grid-column renderer prop's pcDemo reference from grid-renderer#renderer-custom-renderer to grid-editor#editor-custom-editor-select
Editor component event handlers
examples/sites/demos/pc/app/grid/editor/custom-editor-select-composition-api.vue, examples/sites/demos/pc/app/grid/editor/custom-editor-select.vue
Added hangeChange(value) event handler to TinySelect editor components; logs received value on selection change
Grid table styling
packages/theme/src/grid/table.less
Added border-top: 1px solid var(--tv-Grid-border-color-divider) rule to table body within border-enabled section

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

  • The changes consist of straightforward, repetitive pattern additions (identical event handler addition across two files)
  • Documentation reference update is a simple string replacement
  • CSS rule addition is a single, isolated style declaration
  • No complex logic, control flow changes, or interdependencies introduced

Poem

🐰 A border adorns the table below,
Event logs now gracefully flow,
Docs point the way with renewed care,
Select changes echo through the air! ✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Title check ✅ Passed The PR title 'fix(grid): add border-top when set border is true' accurately reflects the main change: adding a border-top to the grid table body when borders are enabled. This is clearly supported by the packages/theme/src/grid/table.less changes.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch cgm/fix-border-grid

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions bot added the bug Something isn't working label Dec 12, 2025
@gimmyhehe gimmyhehe changed the title fix(grid): add border-top when set boder is true fix(grid): add border-top when set border is true Dec 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants