Newly created spans should be activated#21
Open
kohegen wants to merge 1 commit intoopentracing-contrib:masterfrom
Open
Newly created spans should be activated#21kohegen wants to merge 1 commit intoopentracing-contrib:masterfrom
kohegen wants to merge 1 commit intoopentracing-contrib:masterfrom
Conversation
Author
|
Hi guys, can you review please? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Newly created spans were created but not activated in
TracedRunnableastracer.activeSpan()is always null at that point.My change is just doing it in same way as it's done in
TracedExecutorService, where we are checking if there is a span to activate instead checking activated span.