EXCH-12051 - Deduplicate requests#102
Open
Rafał Sieczka (bukrain) wants to merge 20 commits intomasterfrom
Open
EXCH-12051 - Deduplicate requests#102Rafał Sieczka (bukrain) wants to merge 20 commits intomasterfrom
Rafał Sieczka (bukrain) wants to merge 20 commits intomasterfrom
Conversation
Bumps [qs](https://github.com/ljharb/qs) from 6.14.1 to 6.14.2. - [Changelog](https://github.com/ljharb/qs/blob/main/CHANGELOG.md) - [Commits](ljharb/qs@v6.14.1...v6.14.2) --- updated-dependencies: - dependency-name: qs dependency-version: 6.14.2 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [fast-xml-parser](https://github.com/NaturalIntelligence/fast-xml-parser) from 5.3.4 to 5.3.6. - [Release notes](https://github.com/NaturalIntelligence/fast-xml-parser/releases) - [Changelog](https://github.com/NaturalIntelligence/fast-xml-parser/blob/master/CHANGELOG.md) - [Commits](NaturalIntelligence/fast-xml-parser@v5.3.4...v5.3.6) --- updated-dependencies: - dependency-name: fast-xml-parser dependency-version: 5.3.6 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Core: add bidder-scoped floor enforcement * Core: enforce floors allowlist against adapterCode
| bidRequestsWithMediaTypes[0].params.delDomain = 'domain-a.test'; | ||
| bidRequestsWithMediaTypes[1].params.delDomain = 'domain-b.test'; | ||
| const request = spec.buildRequests(bidRequestsWithMediaTypes, mockBidderRequest); | ||
| expect(request[0].data.ext.delDomain).to.equal('domain-a.test'); |
There was a problem hiding this comment.
[question] Now bids with different delDomains into one request and only first bid's delDomain is sent and others are dropped?
* Core: remove legacy GPT targeting fallbacks * Reconciliation RTD Provider: handle missing RSDK_ADID targeting * Core: fix targetingLock GPT test mock for getConfig
* TargetVideo bid adapter: send price floor param * Add support for the price floors module * Add imports * Fix getBidFloor function floor params --------- Co-authored-by: dnrstc <danrstc@gmail.com>
Co-authored-by: Verben <support_trading@verben.com> Co-authored-by: Patrick McCann <patmmccann@gmail.com>
* Update Proxistore endpoint URLs in adapter and tests Updated the Proxistore `COOKIE_BASE_URL` and `COOKIE_LESS_URL` to the new `abs` domain in both the adapter and its corresponding test file. This ensures consistency with the updated API endpoints. * Integrate OpenRTB converter for Proxistore bid adapter, and add OpenRTB request as a separate field. * Refactor Proxistore bid adapter to improve OpenRTB handling, add GDPR-specific URL selection, and enhance test coverage. * Add support for website and language parameters in Proxistore bid adapter requests, with corresponding test coverage. * Handle empty response body in Proxistore bid adapter to avoid runtime errors. --------- Co-authored-by: Anthony Richir <anthony.richir@proxistore.com>
* Floxis Bid Adapter : initial release
* Added ORTB parameters for blocking
* Adjusted documentation with maintainer info
* Added more validations, extracted converter to a const
* Floxis Bid Adapter: redesign to seat-based architecture with ortbConverter
Major rewrite replacing teqblazeUtils with ortbConverter for ORTB 2.x compliance.
Changes:
- New params: seat (required), region (required), partner (required)
- Endpoint URL: https://{subdomain}.floxis.tech/pbjs?seat={seat}
- subdomain = region for 'floxis' partner
- subdomain = {partner}-{region} for white-label partners
- ORTB-native implementation with Floors Module support
- 40 comprehensive tests with full code coverage
- Updated documentation with examples
Addresses all PR prebid#13934 review comments from @osazos
* Rename FloxisBidAdapter.md to floxisBidAdapter.md
* Code review adjustments
---------
Co-authored-by: Patrick McCann <pmccann@cafemedia.com>
* InsurAds Bid Adapter Implementation * Remove test alias * Storage Settings Example * Adapter rename 1/2 * Adapter rename 2/2 * Update modules/insuradsBidAdapter.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update modules/insuradsBidAdapter.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update test/spec/modules/insuradsBidAdapter_spec.js Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * The params need to be registered under nexx360 --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* LeagueM BId Adapter: initial release * Update test/spec/modules/leagueMBidAdapter_spec.js Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update test/spec/modules/leagueMBidAdapter_spec.js Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update test/spec/modules/leagueMBidAdapter_spec.js Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update modules/leagueMBidAdapter.md Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Patrick McCann <patmmccann@gmail.com>
* new adapter harion * refactor(adapter): guard added to interpretResponse
* Core: disabling fingerprinting apis * getFallbackWindow -> utils
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| if (isFingerprintingApiDisabled('webdriver')) { | ||
| return false; | ||
| } | ||
| return getFallbackWindow(win).navigator?.webdriver === true; |
Check warning
Code scanning / CodeQL
Use of browser API associated with fingerprinting Warning
| deepSetNotEmptyValue(qs, '51D_ScreenPixelsHeight', _window?.screen?.height); | ||
| deepSetNotEmptyValue(qs, '51D_ScreenPixelsWidth', _window?.screen?.width); | ||
| deepSetNotEmptyValue(qs, '51D_PixelRatio', _window?.devicePixelRatio); | ||
| deepSetNotEmptyValue(qs, '51D_PixelRatio', getDevicePixelRatio(_window)); |
Check warning
Code scanning / CodeQL
Use of browser API associated with fingerprinting Warning
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
15 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Bugfix
Feature
New bidder adapter
Updated bidder adapter
Code style update (formatting, local variables)
Refactoring (no functional changes, no api changes)
Build related changes
CI related changes
Does this change affect user-facing APIs or examples documented on http://prebid.org?
Other
Description of change
Other information